Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 23 Oct 2020 16:02:03 +0000
To:     =?utf-8?Q?Ville_Syrj=C3=A4l=C3=A4?= <ville.syrjala@linux.intel.com>
From:   Simon Ser <contact@emersion.fr>
Cc:     Randy Dunlap <rdunlap@infradead.org>,
        David Airlie <airlied@linux.ie>,
        intel-gfx <intel-gfx@lists.freedesktop.org>,
        LKML <linux-kernel@vger.kernel.org>,
        dri-devel <dri-devel@lists.freedesktop.org>,
        Pekka Paalanen <ppaalanen@gmail.com>
Reply-To: Simon Ser <contact@emersion.fr>
Subject: Re: [Intel-gfx] drm_modes: signed integer overflow
Message-ID: <X9esEo-xzBmrNZ9Y-H6RJrhH6Y8UNavk58gdBtmbHKmMLNnVIoCq3g-h8boShQUBWYta6AgzqEc6eNSyXjweZ3F4EVfCtLMa5ySdJmQ60C8=@emersion.fr>
In-Reply-To: <20201023152719.GV6112@intel.com>
References: <47527cdb-2eda-b5a3-d77c-3855b91a0b61@infradead.org> <20201022101423.GI6112@intel.com> <BaLsmzqZNUi-nVbYiLstRgspKGlLahAI8vM2_NPfos2PxM0N9lycj-Zn5TdqNtEHB-jeWgmzw9EHJxq4H5552tVi4bAZXTLnP0y1QsTPFtY=@emersion.fr> <20201023152719.GV6112@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Friday, October 23, 2020 5:27 PM, Ville Syrj=C3=A4l=C3=A4 <ville.syrjala=
@linux.intel.com> wrote:

> These are two extreme cases:

Thanks!

> > I'm trying to get
> > a fix for my user-space 1, and I'm wondering if int32_t is enough
> > after dividing by mode->htotal.
> > CC Pekka, just FYI (I think Weston has similar code).
>
> What's with those 1000000LL constants? Are you storing
> clock in Hz units?

We're storing the vertical refresh rate in mHz (milli-Hertz).