Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Sagar Kadam <sagar.kadam@openfive.com>
To:     Peter Korsgaard <peter@korsgaard.com>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-riscv@lists.infradead.org" <linux-riscv@lists.infradead.org>,
        "linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
        "andrew@lunn.ch" <andrew@lunn.ch>,
        "Paul Walmsley ( Sifive)" <paul.walmsley@sifive.com>,
        "palmer@dabbelt.com" <palmer@dabbelt.com>,
        "aou@eecs.berkeley.edu" <aou@eecs.berkeley.edu>
Subject: RE: [PATCH v4 1/1] i2c: ocores: fix polling mode workaround on
 FU540-C000 SoC
Thread-Topic: [PATCH v4 1/1] i2c: ocores: fix polling mode workaround on
 FU540-C000 SoC
Thread-Index: AQHWp7mCMMY56WVnp06VcwClNA/CpKmiM0MCgALidpA=
Date:   Fri, 23 Oct 2020 11:55:38 +0000
Message-ID: <DM6PR13MB3451537F5778BCE2E1210D53971A0@DM6PR13MB3451.namprd13.prod.outlook.com>
References: <1603291814-240377-1-git-send-email-sagar.kadam@sifive.com>
        <1603291814-240377-2-git-send-email-sagar.kadam@sifive.com>
 <87k0vjk2ek.fsf@dell.be.48ers.dk>
In-Reply-To: <87k0vjk2ek.fsf@dell.be.48ers.dk>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 57899e2e-6604-46d0-39ed-08d8774a8ef3
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Oct 2020 11:55:38.1086
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 22f88e9d-ae0d-4ed9-b984-cdc9be1529f1
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ogZ+FgWT+aRWqQVyMO78/VKsVeQ1+7man37YnxChJDVoIwo67BYct9Be9+Wl6Uj3t3U1AnoB0v+aFoKqohAPLQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR13MB1164
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello Peter,

> -----Original Message-----
> From: Peter Korsgaard <jacmet@gmail.com> On Behalf Of Peter Korsgaard
> Sent: Wednesday, October 21, 2020 9:16 PM
> To: Sagar Kadam <sagar.kadam@openfive.com>
> Cc: linux-kernel@vger.kernel.org; linux-riscv@lists.infradead.org; linux-
> i2c@vger.kernel.org; andrew@lunn.ch; Paul Walmsley ( Sifive)
> <paul.walmsley@sifive.com>; palmer@dabbelt.com;
> aou@eecs.berkeley.edu
> Subject: Re: [PATCH v4 1/1] i2c: ocores: fix polling mode workaround on
> FU540-C000 SoC
>=20
> [External Email] Do not click links or attachments unless you recognize t=
he
> sender and know the content is safe
>=20
> >>>>> "Sagar" =3D=3D Sagar Shrikant Kadam <sagar.kadam@sifive.com> writes=
:
>=20
>  > The FU540-C000 has a broken IRQ and support was added earlier
>  > so that it will operate in polling mode, but seems to work only
>  > in case interrupts property is missing from the i2c0 dt-node.
>  > This should not be the case and the driver should handle polling
>  > mode with the interrupt property present in i2c0 node of the
>  > device tree.
>  > So check if it's the FU540-C000 soc and enable polling mode master
>  > xfers, as the IRQ for this chip is broken.
>=20
>  > Fixes commit c45d4ba86731 ("i2c: ocores: add polling mode workaround
>  > for Sifive FU540-C000 SoC")
>=20
>  > Signed-off-by: Sagar Shrikant Kadam <sagar.kadam@sifive.com>
>=20
> LGTM, thanks.
>=20
> Acked-by: Peter Korsgaard <peter@korsgaard.com>
>=20

Thank you for the review and "Acked-by"

BR,
Sagar
> --
> Bye, Peter Korsgaard