Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp707875pxu; Fri, 23 Oct 2020 11:14:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzQaV6jJDi3qSOSdTiBNfZk7mjmDkoLkv0P23dXms8whwge+umNBdctNiNsWqv89KJszqsj X-Received: by 2002:aa7:d64e:: with SMTP id v14mr3590143edr.66.1603476854902; Fri, 23 Oct 2020 11:14:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1603476854; cv=none; d=google.com; s=arc-20160816; b=xLLcwiozIxIQg94js5xVyqwmceeXTR4wcfHeGi2zok8U16tZxJ+wWw3Ro4kFx5wlq3 QhBVparwjADvBHPjjjyuBFqg6B58pYghQ+csYdQnAMLC40AzlFkdxfbE9tvvIA/+80Qe C9vZa1RP/jEASWCwwthFKBl/Pw6KbEIV2jQUxKAlzjaibG3IGyW3TiLnscmHRyRNjZ/4 F0AEJQP6nNOxsSmnFOuuASNoxT7yO0zRTKT5ToctYJoOfl3gYSSquPJQJg/g2KKpWAyH K9aUoxguUSUK8bPOScvVvV4/BrTwMpePTXHaCe10YgOJTOpf1FAt+4bfeSpacwh+j5MR AyLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:organization :autocrypt:from:references:cc:to:subject:dkim-signature; bh=3uSckI+lbava8os593cWItFr0sz4xH3c8LAg7n/KznY=; b=MVCykOCh9z62Zv2phV43QqUTI8mC1pqhbE9MAcSU9uUIH4YOzzg04MRSZo/0M+MB0x ALzm6X8naeuGPNEMcq4pK30wg4cWwJaSFogjAFMmylhspjs1pTRvCGx3a1+q1wwPnST+ yDFENWWfqO3e/wkBr92X5Eu4qC0GWM8aEMl6gJHy0C5Hik5cyDK3EidrLbD70fhef5l8 65mFC9OLeqB1tfMLu4h3ITrxEkp2Ti/qJ/oONCrkMNleolncBi/xBCeChTS5+6Pk892o qaA43j9GiS2/DlBr9Y4fAf8fz15lgreBgMeV4LIzR6MJh+Vrqgrf1Z2QaED/fw26tW+S jc7Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=YwNpohiR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l2si1430837ejf.667.2020.10.23.11.13.52; Fri, 23 Oct 2020 11:14:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=YwNpohiR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S463794AbgJWM2j (ORCPT + 99 others); Fri, 23 Oct 2020 08:28:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38940 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S372436AbgJWM2i (ORCPT ); Fri, 23 Oct 2020 08:28:38 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A8DCEC0613CE for ; Fri, 23 Oct 2020 05:28:37 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id l15so1318637wmi.3 for ; Fri, 23 Oct 2020 05:28:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:autocrypt:organization:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=3uSckI+lbava8os593cWItFr0sz4xH3c8LAg7n/KznY=; b=YwNpohiRi4geEFtkg+5A+0ckqajpwMQUnplFHStvXQ6cd4YyRBEfQpuaAuL/LZ/Evf 771E5z3M3RzMhbGTUFbo/reIkoqeXUGRo8AMNZajrB45GfTG186HvZJJMYpbTGfGPT2N 3EEC5JBdcbkXw+pM2omenlw9w1baRHy9G6pecIOn4p9kIcpCrVLX34IzivdZdTuDhIpi LoS5ZOUntfCE/23DO1q1UOl/Gnlrkp6aB/6KrH3pvWkNTNEkg/e09FDVLd8LQjlxNW92 G66JaQtzotsYM7JX+GOCyYNoVoieULfqCJyhB/SKgd+nRs2vwst9aBXB6B5nK1RSne6G 1szw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :organization:message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=3uSckI+lbava8os593cWItFr0sz4xH3c8LAg7n/KznY=; b=kfHJcwLleIbVmdElsT5lCG/544DEk1BURsdgA/B+GVza5ZKY+wZ9YigZgc1SCRJ1/3 loBsx/PRz4lQ11velmivBCpTRPYaLuahgtnOqpvyxobYYcXBtLXIpp1OqehsHAmujvp3 9ip6ld206IIjjHE7bM0N635Ag0g79C1V3AZhIt6fxYxWuDCJx+EdJTdSYO0WrlfLLDJ9 BqGBjCxgXldzssNZMMcjrYhuGYWA3UsYHrK6EEII/SKtutPyUESX1iwHXmZOELZ2M2yN VzS4bBYcXvz9Ip7VMpUHJGk1bCf+L1gCbD4syG777O6DF7GWChymBmqX7xUrLt6fRIZQ mtsw== X-Gm-Message-State: AOAM532F/DVjZLZfjko/alVK8qM3/wfCpxxuQXRz22igf83JT3oPfPrB 32nKKwi0rezyJgp9kpkx14RLuL4nIo6aSCSH X-Received: by 2002:a7b:c20a:: with SMTP id x10mr1498959wmi.29.1603456112947; Fri, 23 Oct 2020 05:28:32 -0700 (PDT) Received: from ?IPv6:2a01:e35:2ec0:82b0:c079:8e13:bc2b:9142? ([2a01:e35:2ec0:82b0:c079:8e13:bc2b:9142]) by smtp.gmail.com with ESMTPSA id y10sm3077748wrq.73.2020.10.23.05.28.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 Oct 2020 05:28:32 -0700 (PDT) Subject: Re: [PATCH] arm64: dts: meson: odroid-n2 plus: fix vddcpu_a pwm To: Jerome Brunet , Kevin Hilman Cc: linux-amlogic@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20201023094139.809379-1-jbrunet@baylibre.com> From: Neil Armstrong Autocrypt: addr=narmstrong@baylibre.com; prefer-encrypt=mutual; keydata= mQENBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAG0KE5laWwgQXJtc3Ryb25nIDxuYXJtc3Ryb25nQGJheWxpYnJlLmNvbT6JATsEEwEKACUC GyMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheABQJXDO2CAhkBAAoJEBaat7Gkz/iubGIH/iyk RqvgB62oKOFlgOTYCMkYpm2aAOZZLf6VKHKc7DoVwuUkjHfIRXdslbrxi4pk5VKU6ZP9AKsN NtMZntB8WrBTtkAZfZbTF7850uwd3eU5cN/7N1Q6g0JQihE7w4GlIkEpQ8vwSg5W7hkx3yQ6 2YzrUZh/b7QThXbNZ7xOeSEms014QXazx8+txR7jrGF3dYxBsCkotO/8DNtZ1R+aUvRfpKg5 ZgABTC0LmAQnuUUf2PHcKFAHZo5KrdO+tyfL+LgTUXIXkK+tenkLsAJ0cagz1EZ5gntuheLD YJuzS4zN+1Asmb9kVKxhjSQOcIh6g2tw7vaYJgL/OzJtZi6JlIW5AQ0ETVkGzwEIALyKDN/O GURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYpQTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXM coJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hi SvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY4yG6xI99NIPEVE9lNBXBKIlewIyVlkOa YvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoMMtsyw18YoX9BqMFInxqYQQ3j/HpVgTSv mo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUXoUk33HEAEQEAAYkBHwQYAQIACQUCTVkG zwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfnM7IbRuiSZS1unlySUVYu3SD6YBYnNi3G 5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa33eDIHu/zr1HMKErm+2SD6PO9umRef8V8 2o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCSKmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+ RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJ C3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTTQbM0WUIBIcGmq38+OgUsMYu4NzLu7uZF Acmp6h8guQINBFYnf6QBEADQ+wBYa+X2n/xIQz/RUoGHf84Jm+yTqRT43t7sO48/cBW9vAn9 GNwnJ3HRJWKATW0ZXrCr40ES/JqM1fUTfiFDB3VMdWpEfwOAT1zXS+0rX8yljgsWR1UvqyEP 3xN0M/40Zk+rdmZKaZS8VQaXbveaiWMEmY7sBV3QvgOzB7UF2It1HwoCon5Y+PvyE3CguhBd 9iq5iEampkMIkbA3FFCpQFI5Ai3BywkLzbA3ZtnMXR8Qt9gFZtyXvFQrB+/6hDzEPnBGZOOx zkd/iIX59SxBuS38LMlhPPycbFNmtauOC0DNpXCv9ACgC9tFw3exER/xQgSpDVc4vrL2Cacr wmQp1k9E0W+9pk/l8S1jcHx03hgCxPtQLOIyEu9iIJb27TjcXNjiInd7Uea195NldIrndD+x 58/yU3X70qVY+eWbqzpdlwF1KRm6uV0ZOQhEhbi0FfKKgsYFgBIBchGqSOBsCbL35f9hK/JC 6LnGDtSHeJs+jd9/qJj4WqF3x8i0sncQ/gszSajdhnWrxraG3b7/9ldMLpKo/OoihfLaCxtv xYmtw8TGhlMaiOxjDrohmY1z7f3rf6njskoIXUO0nabun1nPAiV1dpjleg60s3OmVQeEpr3a K7gR1ljkemJzM9NUoRROPaT7nMlNYQL+IwuthJd6XQqwzp1jRTGG26J97wARAQABiQM+BBgB AgAJBQJWJ3+kAhsCAikJEBaat7Gkz/iuwV0gBBkBAgAGBQJWJ3+kAAoJEHfc29rIyEnRk6MQ AJDo0nxsadLpYB26FALZsWlN74rnFXth5dQVQ7SkipmyFWZhFL8fQ9OiIoxWhM6rSg9+C1w+ n45eByMg2b8H3mmQmyWztdI95OxSREKwbaXVapCcZnv52JRjlc3DoiiHqTZML5x1Z7lQ1T3F 8o9sKrbFO1WQw1+Nc91+MU0MGN0jtfZ0Tvn/ouEZrSXCE4K3oDGtj3AdC764yZVq6CPigCgs 6Ex80k6QlzCdVP3RKsnPO2xQXXPgyJPJlpD8bHHHW7OLfoR9DaBNympfcbQJeekQrTvyoASw EOTPKE6CVWrcQIztUp0WFTdRGgMK0cZB3Xfe6sOp24PQTHAKGtjTHNP/THomkH24Fum9K3iM /4Wh4V2eqGEgpdeSp5K+LdaNyNgaqzMOtt4HYk86LYLSHfFXywdlbGrY9+TqiJ+ZVW4trmui NIJCOku8SYansq34QzYM0x3UFRwff+45zNBEVzctSnremg1mVgrzOfXU8rt+4N1b2MxorPF8 619aCwVP7U16qNSBaqiAJr4e5SNEnoAq18+1Gp8QsFG0ARY8xp+qaKBByWES7lRi3QbqAKZf yOHS6gmYo9gBmuAhc65/VtHMJtxwjpUeN4Bcs9HUpDMDVHdfeRa73wM+wY5potfQ5zkSp0Jp bxnv/cRBH6+c43stTffprd//4Hgz+nJcCgZKtCYIAPkUxABC85ID2CidzbraErVACmRoizhT KR2OiqSLW2x4xdmSiFNcIWkWJB6Qdri0Fzs2dHe8etD1HYaht1ZhZ810s7QOL7JwypO8dscN KTEkyoTGn6cWj0CX+PeP4xp8AR8ot4d0BhtUY34UPzjE1/xyrQFAdnLd0PP4wXxdIUuRs0+n WLY9Aou/vC1LAdlaGsoTVzJ2gX4fkKQIWhX0WVk41BSFeDKQ3RQ2pnuzwedLO94Bf6X0G48O VsbXrP9BZ6snXyHfebPnno/te5XRqZTL9aJOytB/1iUna+1MAwBxGFPvqeEUUyT+gx1l3Acl ZaTUOEkgIor5losDrePdPgE= Organization: Baylibre Message-ID: Date: Fri, 23 Oct 2020 14:28:31 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201023094139.809379-1-jbrunet@baylibre.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 23/10/2020 11:41, Jerome Brunet wrote: > On the odroid N2 plus, cpufreq is not available due to an error on the cpu > regulators. vddcpu a and b get the same PWM. The one provided to vddcpu A > is incorrect. Because vddcpu B PWM is busy the regulator cannot register: > >> pwm-regulator regulator-vddcpu-b: Failed to get PWM: -16 > > Like on the odroid n2, use PWM A out of GPIOE_2 for vddcpu A to fix the > problem > > Fixes: 98d24896ee11 ("arm64: dts: meson: add support for the ODROID-N2+") > Signed-off-by: Jerome Brunet > --- > arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2-plus.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2-plus.dts b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2-plus.dts > index 5de2815ba99d..ce1198ad34e4 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2-plus.dts > +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2-plus.dts > @@ -19,7 +19,7 @@ &vddcpu_a { > regulator-min-microvolt = <680000>; > regulator-max-microvolt = <1040000>; > > - pwms = <&pwm_AO_cd 1 1500 0>; > + pwms = <&pwm_ab 0 1500 0>; > }; > > &vddcpu_b { > Nice catch, thanks Acked-by: Neil Armstrong