Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Parshuram Raju Thombare <pthombar@cadence.com>
To:     Russell King - ARM Linux admin <linux@armlinux.org.uk>
CC:     "andrew@lunn.ch" <andrew@lunn.ch>,
        "nicolas.ferre@microchip.com" <nicolas.ferre@microchip.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Milind Parab <mparab@cadence.com>
Subject: RE: [PATCH v3] net: macb: add support for high speed interface
Thread-Topic: [PATCH v3] net: macb: add support for high speed interface
Thread-Index: AQHWp9HS4UctazNdVUWuQbMULgmNwKmiZpMAgAEAG1CAAY/28IAAGDyAgAAhBDA=
Date:   Fri, 23 Oct 2020 13:34:09 +0000
Message-ID: <DM5PR07MB31961A008F4EFA98443E63C6C11A0@DM5PR07MB3196.namprd07.prod.outlook.com>
References: <1603302245-30654-1-git-send-email-pthombar@cadence.com>
 <20201021185056.GN1551@shell.armlinux.org.uk>
 <DM5PR07MB31961F14DD8A38B7FFA8DA24C11D0@DM5PR07MB3196.namprd07.prod.outlook.com>
 <DM5PR07MB3196723723F236F6113DDF9EC11A0@DM5PR07MB3196.namprd07.prod.outlook.com>
 <20201023112549.GB1551@shell.armlinux.org.uk>
In-Reply-To: <20201023112549.GB1551@shell.armlinux.org.uk>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 397d7b56-9c1e-4c28-ed03-08d8775852a3
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Oct 2020 13:34:09.8847
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: d36035c5-6ce6-4662-a3dc-e762e61ae4c9
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: o/8YQYpfuwJoc57tdJx0E9MPoTiUcC/ac6ml1sv5+OUZVMHeDg1Ihf3i3BKYzYG+/rdAW7bW1h9RkPs30C01UxFxJgxo4d98pyVF0GRbiqE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR07MB4874
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235,18.0.737
 definitions=2020-10-23_07:2020-10-23,2020-10-23 signatures=0
X-Proofpoint-Spam-Details: rule=outbound_check_notspam policy=outbound_check score=0 clxscore=1015
 mlxlogscore=754 phishscore=0 suspectscore=0 malwarescore=0 impostorscore=0
 adultscore=0 lowpriorityscore=0 mlxscore=0 priorityscore=1501 bulkscore=0
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2009150000 definitions=main-2010230094
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>Whenever the interface changes, we go through the full reconfiguration
>procedure that I've already outlined. This involves calling the
>mac_prepare() method which calls into mvpp2_mac_prepare() and its
>child mvpp2__mac_prepare().

Ok, I misunderstood it as interface mode change between successive mac_prep=
are().
If major reconfiguration is certain to happen after every interface mode ch=
ange,
I will make another small modification in mac_prepare method to set appropr=
iate
pcs_ops for selected interface mode.=20
pcs_ops for low speed, however, will just be existing non 10GBASE-R functio=
ns renamed.
This will allow us to get rid of old API's for non 10GBASE-R PCS. I hope yo=
u are ok with
these changes done in the same patch.