Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp734005pxu; Fri, 23 Oct 2020 11:56:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwH7LbWzlVujf8Br789fDjzDqCjjsys2LsQU02pHYYmB9StGPg2Pq9e0RAoHNLhD6ZyMxy4 X-Received: by 2002:a17:906:51d0:: with SMTP id v16mr3454446ejk.493.1603479378150; Fri, 23 Oct 2020 11:56:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1603479378; cv=none; d=google.com; s=arc-20160816; b=kPFlyDpKSp9zoA3i/VzXAtAt9nTBqVIfIJLOI9jwAID0cEXBNtXwFFp/qOqAYaKRx+ U/Eh9ftPljK7SB9e/Xno/IQlLqwj588Yo52fxv57e8z5B/2HdXGyFfQ18+boR0ws774H HVGWdMDD4KrgMKcYmh6ywtdoRYySLcA5/TlI5vq60JkI/59n0c9Yc50sIjOOeocQDIET vVI8wTXMk+Gvjy/P3F29FDwbqnB7q4uppedQ8UE7ehcdvKNNDJZAEZcpVx09qkKWRgZI c8Lob+emPmFyOE2dNAy8g4m+ShY+w01sxbjaxOa0vjsJsnQ1ndDrHbG2wUiv59B/aVM2 Przg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=DmFI4CxVV7TudqMTviEtcNfGxb5h9F5Q2IKtouYB1hE=; b=Jo6fTYqkxSQFkVUNiGyTBNR1EPP2ndsqyYvVhnz68ZmWfd2vfQG79aqM22khkSG4XG i60Nh/jhlgfD6jfSCXvqo2hxAZ7L8yrqdpnTiEsGoiVvbtlKZoujdxlrmmgMNlP5wpN8 f0iK9deZHxMgYdq6Ty9tYqrHkbghVsr6CKt+0EGoajDRtEr6c4sVOr0movy9mYDVptQC 6Pu7XEnIldlJMxVGdJBjCIVsb6WznL7m1Z0CwTbxC+Cu2SB640CeZIPgR/9kRB2i7PRU KeFEZjTEF9nDDoT6bGCs8yyDDkawaeVa/j5IvH1LQJRIT9gCcMIgzbp9Pm3nuSZFeKwe TOvA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=LlEXD4kL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e5si1402466eds.367.2020.10.23.11.55.56; Fri, 23 Oct 2020 11:56:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=LlEXD4kL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752881AbgJWQv3 (ORCPT + 99 others); Fri, 23 Oct 2020 12:51:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51854 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752837AbgJWQvS (ORCPT ); Fri, 23 Oct 2020 12:51:18 -0400 Received: from mail-io1-xd44.google.com (mail-io1-xd44.google.com [IPv6:2607:f8b0:4864:20::d44]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EFFFAC0613D2 for ; Fri, 23 Oct 2020 09:51:17 -0700 (PDT) Received: by mail-io1-xd44.google.com with SMTP id z17so2556994iog.11 for ; Fri, 23 Oct 2020 09:51:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=DmFI4CxVV7TudqMTviEtcNfGxb5h9F5Q2IKtouYB1hE=; b=LlEXD4kLLiSoxBpI240zn1UfC62F49ZtKjMvF7CB1GROCq0qmKooibsDhIvGz6T+zn ngUdE1T1VPuBbRSV6FN9EbPP5YCrueaZXLSZjxWWWO5fi/5v5QJlJZ2xdbx3cKeFT+Sf Lx3p6yf6euF32EFur+ZK8MY/7pb0qhd6GO0zGx0qjH7H6w663MSiiTtgPKxqrp/xsIN1 y4wrsfeLtnZuGcQisWiNSuhVqL/rynqfVT8IqlxVD4bF+2gCRaef89YfKB8Zf+1+54HI Kld3Uqyg56crCtv+Q7aLeUcIGooWEQb3ZqsDCYqKU3iokdXYffcjIORoIBve8dyAxDsd TwZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DmFI4CxVV7TudqMTviEtcNfGxb5h9F5Q2IKtouYB1hE=; b=KiXlbA2sShHMnnm/wdtnl4iVjrMapdB9NJLXT63EMqa9PjhFSDfqDpliepLGGdSuLN MsmD7tgV3K2yFtt8O+KFsWIvRbetKNagDJuI0XvomeEN3za1Z6H/it99t0zJy8VElJ52 U8a1HAilW5FK19A0qgdNTtqGQ5EA/MQ3iiNjUDLBj7psbP2uiJZgrM9GNRjjiBFk+wMX Vg8A62ggTvslYM6YsLaKEcjztluXegjxuQ0+DkakcnngDK+faLEVnpBIitpx+EM/cz7c zRr9TBnHWog3eWk6LM+w91Em7RgaRdtRQAyCHvIBE/Z3kQ00jLGFSzyaNhoBfX0eGv8T 5fLA== X-Gm-Message-State: AOAM532Ix4Uu7qwWFFKLAHE2wy+8yUgWjyTvmzBn15xGoRJQkVntR5kg rz+Dg2u+pxT9FwlnJ8iu+xr/0plSWGdn0FqiAvyyWg== X-Received: by 2002:a5e:9411:: with SMTP id q17mr2266246ioj.157.1603471877101; Fri, 23 Oct 2020 09:51:17 -0700 (PDT) MIME-Version: 1.0 References: <20201023111352.GA289522@rdias-suse-pc.lan> <20201023155145.GA316015@rdias-suse-pc.lan> <20201023160628.GA316690@rdias-suse-pc.lan> <20201023164825.GA321826@rdias-suse-pc.lan> In-Reply-To: <20201023164825.GA321826@rdias-suse-pc.lan> From: Eric Dumazet Date: Fri, 23 Oct 2020 18:51:05 +0200 Message-ID: Subject: Re: [PATCH] tcp: fix race condition when creating child sockets from syncookies To: Ricardo Dias Cc: David Miller , Jakub Kicinski , Alexey Kuznetsov , Hideaki YOSHIFUJI , netdev , LKML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 23, 2020 at 6:48 PM Ricardo Dias wrote: > > In that case, I can change the patch to only iterate the ehash bucket > only when the listening socket is using the loopback interface, correct? No, the fix should be generic. We could still have bad NIC, or bad configuration, spreading packets on random cpus ;)