From: Dmitry Torokhov <dtor@insightbb.com>
To: Florin Malita <fmalita@gmail.com>
Subject: Re: [PATCH] atkbd.c: overrun in atkbd_set_repeat_rate()
Date: Sun, 13 Aug 2006 19:50:28 -0400
User-Agent: KMail/1.9.3
Cc: linux-kernel@vger.kernel.org, akpm@osdl.org
References: <44DF953B.6010707@gmail.com>
In-Reply-To: <44DF953B.6010707@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200608131950.28720.dtor@insightbb.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1087
Lines: 35

On Sunday 13 August 2006 17:10, Florin Malita wrote:
> This was introduced in commit 3d0f0fa0cb554541e10cb8cb84104e4b10828468:
> bounds checking is performed against period[32] while indexing delay[4].
> 
> Spotted by Coverity, CID 1376.
> 

Will apply, thank you.

> Signed-off-by: Florin Malita <fmalita@gmail.com>
> ---
> 
> diff --git a/drivers/input/keyboard/atkbd.c b/drivers/input/keyboard/atkbd.c
> index 6bfa0cf..a86afd0 100644
> --- a/drivers/input/keyboard/atkbd.c
> +++ b/drivers/input/keyboard/atkbd.c
> @@ -498,7 +498,7 @@ static int atkbd_set_repeat_rate(struct 
>  		i++;
>  	dev->rep[REP_PERIOD] = period[i];
>  
> -	while (j < ARRAY_SIZE(period) - 1 && delay[j] < dev->rep[REP_DELAY])
> +	while (j < ARRAY_SIZE(delay) - 1 && delay[j] < dev->rep[REP_DELAY])
>  		j++;
>  	dev->rep[REP_DELAY] = delay[j];
>  
> 
> 

-- 
Dmitry
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/