Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp735462pxu; Fri, 23 Oct 2020 11:58:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz/1W6c24yypbvyNCy6JFUS4Q3wPb4fXe2qY3GAqI9ejGguCYdJZC52QGLKCzynnH1Z9em+ X-Received: by 2002:a17:906:86da:: with SMTP id j26mr3358430ejy.35.1603479527547; Fri, 23 Oct 2020 11:58:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1603479527; cv=none; d=google.com; s=arc-20160816; b=PkP4l754VoVk3evtxCDVOCB1NqKADvDj/XTgnPO9xsvJ50isPyCBxGbZiOjAiSrKj3 HogKzN4q3Alsu5iYr+CmHMf2PsRoN8ka7N7Ux+7AudrM0KNyBfkyoDGu/nMNwrrq4Pfh 8C9k0narOW1ax1PNafq07qMGNxWQnWtcdDHueLmVjIymgrN55ekMxL+tTgZmKq9M8V0K s8QysYfZ82QwmenFbM0ie0gjI+o4ZR38UwYkhX5k3eILMk7hcu5dePDAgABcFczhfpce B1ylDKWb3DoncEP7B8fOco+UbohOIDg7Rbm5FdwGPZ1k6eBPtQXtT2zxoDTGC1CXmuiU O29g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:mail-followup-to:reply-to:message-id :subject:cc:to:from:date; bh=fOMd6sAU0KWsoM9IZ1XMXvmVrcgl1me0MPneW3rj/X4=; b=VlErku+2ysmxzFYpV5ChY4NXVI74msPLH+gTA3TVBlTpi9ZZLoVgKQpBeqAY14xUaB lVdWKwmkMnJ/FKZ4WWnpIjfl0VlRksYosPrU5IPtFZ+LoWxYhUnVu5BhEchplfZIycDy HIyfgwVICwX/5kX91vCkf1Hf0dTvW+XIptQuvJPXbLMYHAg103vc4L5HatvcV+Dk+EIf ZUWj1PRjlyYhyzMYUZGLppsiLaM/ES9xU/in35JjmaQyOKfQKc10hc5SdtbtzQazqlCZ 6a6eP/9EBwjx/OogLUhYnnfC2zC38wAJFs6dsLi1fNK0YjO+XBZkrhxzqmKX5nE/qmSU gQmw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z13si308009edq.478.2020.10.23.11.58.25; Fri, 23 Oct 2020 11:58:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751621AbgJWQ6A (ORCPT + 99 others); Fri, 23 Oct 2020 12:58:00 -0400 Received: from mx2.suse.de ([195.135.220.15]:34396 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S461384AbgJWQ6A (ORCPT ); Fri, 23 Oct 2020 12:58:00 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id C78C7AB95; Fri, 23 Oct 2020 16:57:58 +0000 (UTC) Received: by ds.suse.cz (Postfix, from userid 10065) id 65831DA7F1; Fri, 23 Oct 2020 18:56:26 +0200 (CEST) Date: Fri, 23 Oct 2020 18:56:26 +0200 From: David Sterba To: Davidlohr Bueso Cc: dsterba@suse.com, a.darwish@linutronix.de, linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, Davidlohr Bueso Subject: Re: [PATCH] btrfs: convert data_seqcount to seqcount_mutex_t Message-ID: <20201023165626.GK6756@twin.jikos.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, Davidlohr Bueso , dsterba@suse.com, a.darwish@linutronix.de, linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, Davidlohr Bueso References: <20201021201724.27213-1-dave@stgolabs.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201021201724.27213-1-dave@stgolabs.net> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 21, 2020 at 01:17:24PM -0700, Davidlohr Bueso wrote: > By doing so we can associate the sequence counter to the chunk_mutex > for lockdep purposes (compiled-out otherwise) and also avoid > explicitly disabling preemption around the write region as it will now > be done automatically by the seqcount machinery based on the lock type. Thanks, the enhanced seqlock is new to me and makes sense regarding lockdep. I've added a comment to mention the mutex association and added it to misc-next.