Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751247AbWHNBBc (ORCPT ); Sun, 13 Aug 2006 21:01:32 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751244AbWHNBBc (ORCPT ); Sun, 13 Aug 2006 21:01:32 -0400 Received: from omx1-ext.sgi.com ([192.48.179.11]:10660 "EHLO omx1.americas.sgi.com") by vger.kernel.org with ESMTP id S1751181AbWHNBBb (ORCPT ); Sun, 13 Aug 2006 21:01:31 -0400 Date: Sun, 13 Aug 2006 18:00:54 -0700 From: Paul Jackson To: Daniel Phillips Cc: a.p.zijlstra@chello.nl, jeff@garzik.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, indan@nul.nu, johnpol@2ka.mipt.ru, riel@redhat.com, davem@davemloft.net, Nick Piggin Subject: Re: rename *MEMALLOC flags Message-Id: <20060813180054.65201239.pj@sgi.com> In-Reply-To: <44DFBEA3.5070305@google.com> References: <20060812141415.30842.78695.sendpatchset@lappy> <20060812141445.30842.47336.sendpatchset@lappy> <44DDE8B6.8000900@garzik.org> <1155395201.13508.44.camel@lappy> <44DFBEA3.5070305@google.com> Organization: SGI X-Mailer: Sylpheed version 2.2.4 (GTK+ 2.8.3; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 946 Lines: 24 Daniel wrote: > Inventing a new name for an existing thing is very poor taste on grounds of > grepability alone. I wouldn't say 'very poor taste' -- just something that should be done infrequently, with good reason, and with reasonable concensus, especially from the key maintainers in the affected area. Good names are good taste, in my book. But stable naming is good too. I wonder what Nick thinks of this? Looks like he added __GFP_NOMEMALLOC a year ago, following the naming style of PF_MEMALLOC. I added him to the cc list. -- I won't rest till it's the best ... Programmer, Linux Scalability Paul Jackson 1.925.600.0401 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/