Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp904018pxu;
        Fri, 23 Oct 2020 16:53:44 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJzsTOSpBK0CfM16pADWF2PrQ3grrcSQVre20btxbnWrEX4wo9nTvE03tEi4lqcxHRVGdXVw
X-Received: by 2002:aa7:c6d9:: with SMTP id b25mr4557962eds.27.1603497224588;
        Fri, 23 Oct 2020 16:53:44 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1603497224; cv=none;
        d=google.com; s=arc-20160816;
        b=Gq8P34fORj+a7yL2b/0blSJEXANXXGHpeFRTt+ao2RNIkDgIYwnFij6Cj1MTRbBGen
         /UXfkJM3poX1boIIHZD8Afm3yLEkaI9o/UrO5Ti8D4RM68m7yQlHV4TSZbiUv4bxS+Oc
         quGd0Pur95HgwvVgBL6f3yg5KnV5+dMw99B9SB8LOWAL6ASpAoqcBtXge5jUYWtihJOM
         WPjaSG1iMaxNk91e6IW7IuoaKEmghz7pzevTXTpJrBo6eQ+3pfMt7HKljdEAQUy2LMHq
         Gjwm9G6iinuR9ZdzGaG9hDtO2tHOjm7q2qBZp1IEOSIJTA+O/e9rFs84O8WtUmMzGKwg
         CjzA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:dkim-signature:mime-version:references
         :in-reply-to:message-id:date:subject:cc:to:from;
        bh=dZDk41IQVmye1tm/HGRwkE9LdTLqCSACL+m5qHhAk84=;
        b=oe9Y21MwniNYzG2x1zR3YtvPtN06Uqe2hPqFOK8v8vPDXp4yom3aAfPqRxx4UU2jvZ
         CCU4wq/WqZhFbbohtWeVoYdarHGJuqiUltrAZFVl1cRiM5GZTO51xcHjp70XH5yG3xJw
         D6qyewSJyDFKzA4kGp7arB/y+7xjZjCZNwhoKpvxkKc1rjB//Kn6XPS6Jiboe6invULk
         UP7RLNYo4sFLd5QySb2UzG0Ba7nnPafIHDu/FHFA2DbVAfFcvGP5neg7sbtLyUMALMrE
         3oJKE67zi09tFNn/14ypPUbBB1oAxR2iljI2Y1Dv9NejBK3hEtPaxOheyyVRTGlnoaEx
         UC9g==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=MUPvimuP;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id p6si1831245edd.206.2020.10.23.16.53.22;
        Fri, 23 Oct 2020 16:53:44 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=MUPvimuP;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1755231AbgJWT5M (ORCPT <rfc822;crosarcplusplustest@gmail.com>
        + 99 others); Fri, 23 Oct 2020 15:57:12 -0400
Received: from hqnvemgate26.nvidia.com ([216.228.121.65]:17013 "EHLO
        hqnvemgate26.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1755224AbgJWT5L (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 23 Oct 2020 15:57:11 -0400
Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, AES256-SHA)
        id <B5f9335820001>; Fri, 23 Oct 2020 12:56:50 -0700
Received: from HQMAIL101.nvidia.com (172.20.187.10) by HQMAIL107.nvidia.com
 (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 23 Oct
 2020 19:57:08 +0000
Received: from vidyas-desktop.nvidia.com (10.124.1.5) by mail.nvidia.com
 (172.20.187.10) with Microsoft SMTP Server id 15.0.1473.3 via Frontend
 Transport; Fri, 23 Oct 2020 19:57:04 +0000
From:   Vidya Sagar <vidyas@nvidia.com>
To:     <jingoohan1@gmail.com>, <gustavo.pimentel@synopsys.com>,
        <lorenzo.pieralisi@arm.com>, <bhelgaas@google.com>,
        <amurray@thegoodpenguin.co.uk>, <robh@kernel.org>,
        <treding@nvidia.com>, <jonathanh@nvidia.com>
CC:     <linux-pci@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <kthota@nvidia.com>, <mmaddireddy@nvidia.com>, <vidyas@nvidia.com>,
        <sagar.tv@gmail.com>
Subject: [PATCH 1/3] PCI: of: Warn if non-prefetchable memory aperture size is > 32-bit
Date:   Sat, 24 Oct 2020 01:26:53 +0530
Message-ID: <20201023195655.11242-2-vidyas@nvidia.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20201023195655.11242-1-vidyas@nvidia.com>
References: <20201023195655.11242-1-vidyas@nvidia.com>
X-NVConfidentiality: public
MIME-Version: 1.0
Content-Type: text/plain
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
        t=1603483010; bh=dZDk41IQVmye1tm/HGRwkE9LdTLqCSACL+m5qHhAk84=;
        h=From:To:CC:Subject:Date:Message-ID:X-Mailer:In-Reply-To:
         References:X-NVConfidentiality:MIME-Version:Content-Type;
        b=MUPvimuPnqr3XPUjB4q6/Dj7ubZaHhEo0+gV52RMHfZ4mYxdou9Zqu5NgiqjRHMuS
         FXaHoyWLhYg5ehKsTCM1IPfbDoPskyW8it7uf78Rr6m7b8yJkWHAeDB358HKOD+I4/
         5mmb6v7pHFH7GPFUlMuZxx6LjIeZ5ztneBe9u6sfYgJlTSqvi9stNYUW++rnw2Xula
         C9FKqzGpWq2PRyPziAshq+DYdbP26/jtJ1uzkTfd1IzAfitSPjPyVA+AelpnvW0YTA
         Wq61YOuYyP+K7xzDTXXsaf6X0Qz7GUqUXMzffgJNHaq05ZxgJ32RhL+QIiy3w+lanK
         ZWgt4uOWwtKDQ==
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

As per PCIe spec r5.0, sec 7.5.1.3.8 only 32-bit BAR registers are defined
for non-prefetchable memory and hence a warning should be reported when
the size of them go beyond 32-bits.

Signed-off-by: Vidya Sagar <vidyas@nvidia.com>
---
 drivers/pci/of.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/pci/of.c b/drivers/pci/of.c
index ac24cd5439a9..5ea472ae22ac 100644
--- a/drivers/pci/of.c
+++ b/drivers/pci/of.c
@@ -556,6 +556,11 @@ static int pci_parse_request_of_pci_ranges(struct device *dev,
 			break;
 		case IORESOURCE_MEM:
 			res_valid |= !(res->flags & IORESOURCE_PREFETCH);
+
+			if (!(res->flags & IORESOURCE_PREFETCH))
+				if (upper_32_bits(resource_size(res)))
+					dev_warn(dev, "Memory resource size exceeds max for 32 bits\n");
+
 			break;
 		}
 	}
-- 
2.17.1