Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp922848pxu; Fri, 23 Oct 2020 17:30:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzswMYeyU7EC3rbv23sYsv+zW/GoMo6jTAFhm4Q2Xng9ISEvir7b5oDlT1B9dK1U0O/bbP3 X-Received: by 2002:a50:e79d:: with SMTP id b29mr4840299edn.57.1603499431431; Fri, 23 Oct 2020 17:30:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1603499431; cv=none; d=google.com; s=arc-20160816; b=uO8X6Qw7lrPmA/iVBpjkmdmDOXdx5Gh7aMZwd6GKs7hIrdzQ4iQM16tJujwiPvNKw+ aaQuaOBFairUNMLmr0/cJzpmeIu/0ttc4WUOGw0bs0hPFeMpY3BBF0SqJwu4RN23WHqb MZkuW73txslJzBwPVY1lbCBCXubw3IMY1NBFYv3r/rtQMN96fMsYtsKZFAzcJtzPRv06 0IoGzozuwomhb8ROMecV2pjytgsgzjGHlzvdDKmmPa76JMZUAUBg+8xtxSjY/m4D3Xmp T9wIc7XdBUi/nwQu1hw9+9GBr/sAcbxRBJOHUrNpMmv9oKpWhmpSFod2/2qZvl/Sfg8d pmNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=1+qspH0nc4Q8m5YccGALbjZnD8YSqPTCAkoXmEV2KNI=; b=uv20edM404wBUfrzpmmXv+Z2mgvSfPOK0/yj51ysWFDfO0kecp2TvWWwoE3thrfIp0 bTx8zLZVhcIkG9oE+ZVWgvppYjxa1gAynY1QCHtBl1dU4/Y7SxbDydkADiNyTv0yv+4P QdfKkoiEHgqE9rLLfGxjfqBR1LWWJ9UkWQRKCVdT2g+t5Fb6S0ufQim0sZzFfGVpJeNY D7KWWK7lSW6Drg8NqN7Mdrac+KaEyGVYqg7kXJr/fXGe2P/YoVKHq1IcFuMfbYCBc1BO no1AmC2Pb23SgpuXFlOkP48F4HQN5LzCW7XFYsGuWIq7jpp4UV7pm4Bl8rLFmWwlP/T1 qQJQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v4si1762434edx.148.2020.10.23.17.30.09; Fri, 23 Oct 2020 17:30:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752357AbgJWVEd (ORCPT + 99 others); Fri, 23 Oct 2020 17:04:33 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:42410 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751213AbgJWVEd (ORCPT ); Fri, 23 Oct 2020 17:04:33 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1kW4Eb-003Azi-6p; Fri, 23 Oct 2020 23:04:25 +0200 Date: Fri, 23 Oct 2020 23:04:25 +0200 From: Andrew Lunn To: Mauro Carvalho Chehab Cc: Linux Doc Mailing List , "David S. Miller" , Jonathan Corbet , Heiner Kallweit , Jakub Kicinski , Russell King , linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH v3 18/56] net: phy: fix kernel-doc markups Message-ID: <20201023210425.GG752111@lunn.ch> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 23, 2020 at 06:33:05PM +0200, Mauro Carvalho Chehab wrote: > Some functions have different names between their prototypes > and the kernel-doc markup. > > Signed-off-by: Mauro Carvalho Chehab > --- > drivers/net/phy/mdio_bus.c | 2 +- > drivers/net/phy/phy-c45.c | 2 +- > drivers/net/phy/phy.c | 2 +- > drivers/net/phy/phy_device.c | 2 +- > drivers/net/phy/phylink.c | 2 +- > 5 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/net/phy/mdio_bus.c b/drivers/net/phy/mdio_bus.c > index 757e950fb745..e59067c64e97 100644 > --- a/drivers/net/phy/mdio_bus.c > +++ b/drivers/net/phy/mdio_bus.c > @@ -472,7 +472,7 @@ static inline void of_mdiobus_link_mdiodev(struct mii_bus *mdio, > #endif > > /** > - * mdiobus_create_device_from_board_info - create a full MDIO device given > + * mdiobus_create_device - create a full MDIO device given > * a mdio_board_info structure > * @bus: MDIO bus to create the devices on > * @bi: mdio_board_info structure describing the devices Hi Mauro If you need to repost, could you make use of: -U --unified= Generate diffs with lines of context instead of the usual three. to increase the number of lines of context. Often three lines is not enough to include the function declaration in the patch, so i need to go look at the sources to do a review. Reviewed-by: Andrew Lunn Andrew