Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 23 Oct 2020 15:52:00 -0700
User-Agent: K-9 Mail for Android
In-Reply-To: <CAHk-=wg9L3EZk=cBjt5R3LkE8Y6swwOZ8sxhpQYcJO3Fj1wLbQ@mail.gmail.com>
References: <20201023203154.27335-1-linux@rasmusvillemoes.dk> <CAHk-=wj1m3cvS-3dOYzNavYWLFu=9fwo0-6HTHJhG-X5B73gZg@mail.gmail.com> <8820745F-E761-42E6-8A70-7B04EE70692C@zytor.com> <CAHk-=wg9L3EZk=cBjt5R3LkE8Y6swwOZ8sxhpQYcJO3Fj1wLbQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PATCH] x86/uaccess: fix code generation in put_user()
To:     Linus Torvalds <torvalds@linux-foundation.org>
CC:     Rasmus Villemoes <linux@rasmusvillemoes.dk>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        the arch/x86 maintainers <x86@kernel.org>,
        Sean Christopherson <sean.j.christopherson@intel.com>,
        Naresh Kamboju <naresh.kamboju@linaro.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
From:   hpa@zytor.com
Message-ID: <06B6997A-81AC-409D-A654-309FA8697F0C@zytor.com>
Precedence: bulk

On October 23, 2020 2:11:19 PM PDT, Linus Torvalds <torvalds@linux-foundati=
on=2Eorg> wrote:
>On Fri, Oct 23, 2020 at 2:00 PM <hpa@zytor=2Ecom> wrote:
>>
>> There is no same reason to mess around with hacks when we are talking
>about dx:ax, though=2E
>
>Sure there is=2E
>
>"A" doesn't actually mean %edx:%eax like you seem to think=2E
>
>It actually means %eax OR %edx, and then if given a 64-bit value, it
>will use the combination (with %edx being the high bits)=2E
>
>So using "A" unconditionally doesn't work - it gives random behavior
>for 32-bit (or smaller) types=2E
>
>Or you'd have to cast the value to always be 64-bit, and have the
>extra code generation=2E
>
>IOW, an unconditional "A" is wrong=2E
>
>And the alternative is to just duplicate things, and go back to the
>explicit size testing, but honestly, I really think that's much worse
>than relying on a documented feature of "register asm()" that gcc
>_documents_ is for this kind of inline asm use=2E
>
>So the "don't do pointless conditional duplication" is certainly a
>very sane reason for the code=2E
>
>            Linus

Unconditional "A" is definitely wrong, no argument there=2E
--=20
Sent from my Android device with K-9 Mail=2E Please excuse my brevity=2E