Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 0/3] drm/amd/display: Fix kernel panic by breakpoint
To:     Takashi Iwai <tiwai@suse.de>, dri-devel@lists.freedesktop.org
Cc:     linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org
References: <20201023074656.11855-1-tiwai@suse.de>
From:   Luben Tuikov <luben.tuikov@amd.com>
Message-ID: <1d3e22ef-a301-f557-79ca-33d6520bb64e@amd.com>
Date:   Fri, 23 Oct 2020 19:16:38 -0400
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.12.1
In-Reply-To: <20201023074656.11855-1-tiwai@suse.de>
Content-Type: text/plain; charset=utf-8
Content-Language: en-CA
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from [10.252.35.64] (165.204.54.211) by YT1PR01CA0044.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:2e::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.19 via Frontend Transport; Fri, 23 Oct 2020 23:16:40 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-HT: Tenant
X-MS-Office365-Filtering-Correlation-Id: 1a0bf8ac-5911-4459-c47f-08d877a9b305
X-MS-TrafficTypeDiagnostic: DM6PR12MB3178:
X-Microsoft-Antispam-PRVS: <DM6PR12MB31785147DB7FADDDEDF00C50991A0@DM6PR12MB3178.namprd12.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:5797;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: LMQA1s1QMS8QQYzSTcyQJ4lJkHxFXimd/Cp0CB2ejXi3kBpmxXxodvHcWiu0873CmmQ0u/bzPhXn7x76r0toO1BcAAld+J9FCLFdAjIWdayMMqHlLZR14v+xgMhMEnREFhpVQQzQveQzEEhpYLxfD99Lqpff2BKXhFg6YZXcPaAX3/6CBzFldtEpj0Z4AUmRy4Z/YLOK6kMMOyKmRNNXIF+Xpa0jwn7GXvFSC6dSUK0k7lWfcMBg5OihOW+9H01DJ8Am1XtNAP4soOz4sw6HfUgO+6HHtgHlMU5YwEoK7U5HxC8XuQUg0QZhsJvaDlGbXiyy6Ck33Kwqyioxw0E3FgAnCgDiaYuwtBxqFS7l7YJ6bNFyaLbBZLKes9wOMFcG
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR12MB3962.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(376002)(396003)(366004)(39860400002)(136003)(4001150100001)(86362001)(31686004)(6486002)(5660300002)(4744005)(316002)(16576012)(478600001)(4326008)(956004)(186003)(16526019)(44832011)(2616005)(66476007)(53546011)(66556008)(83380400001)(66946007)(26005)(2906002)(31696002)(8936002)(8676002)(52116002)(36756003)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: 7dbEk3JnBpW2f/UekSLoEVuOi6XKccGc6GMl32hH41lzr/FWZv9O3C6eLbmTOkmYPutYbECR+22/PSRuB3ktNxK8xdga4cl8YKQyNscW2HQUHWYb3OlZccgdgBT1Vh9h2grwYz0iD0v5wuWG3jjafXQaIXWV8qsYkRNpMbep8ZLP9caa3qKoM5g+tSH96/5sSqCNHTowCovagP0TS8KdmHt+ihKwvw0+yqdug6ZCKjteRKt4Bxz0HJ8Ho95tMTZV60dbV6EvCNcCX0jGvNzRgclQLqYW57Fs8bC9pd9/7b57b7r6dHdFZJUQEHz6vwY49kCs5jQOx2T7Fv2mHK1sU3JkBRzdDUl9OnTdMK6+iEf16PCXy9J0btFnNWnT657CiKQs1TPMytFao48RQqAiHfAeSOn5CwkenHkiiy+rvQD3TPLZFz3p3Et1B8hOyCOdJMBsxzVy5YZwHzay7arHkmKem8jXUUS5K+Z1Q/5q7zFtKfXcgxBU8TXFkKrFkVs6Mo+oXqVQJB5hGYu/zfrJwTGntsSZY5xB2sM9Gvxyzo7na9U16bJW5MxEtpRiymx94Q23Xn55W4JYriPSB6xkdBxX1hNBN3U5RZKEgj3KqGzjVB8c7421v769Hph8xaEOuKLuEAGi8dTPNwdOUnW0xg==
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1a0bf8ac-5911-4459-c47f-08d877a9b305
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3962.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Oct 2020 23:16:41.9527
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vllPQH3w3wENFP4jqtOndXMRL5DWJoJ6zP4BqgLSMbXSlgnUwuVgILYyhSdKz7Z3
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3178
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2020-10-23 03:46, Takashi Iwai wrote:
> Hi,
> 
> the amdgpu driver's ASSERT_CRITICAL() macro calls the
> kgdb_breakpoing() even if no debug option is set, and this leads to a
> kernel panic on distro kernels.  The first two patches are the
> oneliner fixes for those, while the last one is the cleanup of those
> debug macros.

This looks like good work and solid. Hopefully it gets picked up.

Regards,
Luben

> 
> 
> Takashi
> 
> ===
> 
> Takashi Iwai (3):
>   drm/amd/display: Fix kernel panic by dal_gpio_open() error
>   drm/amd/display: Don't invoke kgdb_breakpoint() unconditionally
>   drm/amd/display: Clean up debug macros
> 
>  drivers/gpu/drm/amd/display/Kconfig             |  1 +
>  drivers/gpu/drm/amd/display/dc/gpio/gpio_base.c |  4 +--
>  drivers/gpu/drm/amd/display/dc/os_types.h       | 33 +++++++++----------------
>  3 files changed, 15 insertions(+), 23 deletions(-)
>