Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp970076pxu; Fri, 23 Oct 2020 19:05:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyNKk4cyOIXVuRxzb+7p6K6OgMOW5oBrwRBxC+2SVwxvDWC4zzCW5bnuTuMg0L67f248qMe X-Received: by 2002:a05:6402:941:: with SMTP id h1mr4965398edz.154.1603505116436; Fri, 23 Oct 2020 19:05:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1603505116; cv=none; d=google.com; s=arc-20160816; b=mzdhN7x9Uxmn5zg+leVMnEMU46hMrpVmu3/vkbXVGud+NIjRXZmG1558Ue/vlZUBCH JEbeIzVwsGAYWmy3cGxi99RCaeY5IgBtoHXBu1k7MOoPY0Zb3O1pGAssMtZA6vr4TEC2 jigCVGbjQknL9puWj3KHQi3dvZWmxNMIdzYrigaNjK4jfBgs1b/LNuh4VICdce7SJRD0 /+4MFAxHZUW/ONht0MSbVR1maWMf6JGNe4VLCQBHmA5lFaCj48oKgxLGMBNhT4/PQh70 vYckE9lI0z5eGP7lVItJv2i6uPeT0yuBLWSLyYiRyABRoyyUSWC+IGCNLMEEd5PiiFTm gBvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:subject:references:in-reply-to:cc:to:from:date :dkim-signature; bh=P2IhFvz/4z59Bqkyc69Sm89qXkIqhJ+Rj/4KqeD/WWI=; b=LwdBm+yIJNll4KHj9YfMkC0bs8joUMNXq0ra6Lgs2YZdp7xQn5lflELeQuUvGuteqk l9Bs7S8SPC2kgT94RLHnJ+nJ0Hd5CAbd0VlxIzt6Hy6C7tnvDQQ4HsqukUQnGrr19/SP K5/Emx20lzrMKwSqCb9rK3GumrQmTDpxb+V0NfXKt8LB8RNZO5jBHSksprb+lVVvJpP3 ModlxdQlevG4ljLYtoSfXiyUcQTXcaHpjdW/tNHENgHsw78916f2UreZ4a9k+FjzAcHS hnbanZOHlJSQFKBkNYx73CyiuwhJM2sBaylEg7pKZgqOzNZEIU809iywI1kBrsHrWV2h vGQg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=dQ4WtqDR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i27si2071915edb.55.2020.10.23.19.04.54; Fri, 23 Oct 2020 19:05:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=dQ4WtqDR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756449AbgJXA24 (ORCPT + 99 others); Fri, 23 Oct 2020 20:28:56 -0400 Received: from mail.kernel.org ([198.145.29.99]:41920 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755505AbgJXA2z (ORCPT ); Fri, 23 Oct 2020 20:28:55 -0400 Received: from localhost (cpc102338-sgyl38-2-0-cust404.18-2.cable.virginm.net [77.102.33.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B76A42225E; Sat, 24 Oct 2020 00:28:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603499335; bh=+FhP76HiOXe3pLSCqtvML2xh8BV++5Vbe3/EWxwGkS0=; h=Date:From:To:Cc:In-Reply-To:References:Subject:From; b=dQ4WtqDRR9mWnKyBXxnLs1n5kJnoMWQ+fNdXS+7h3F1eWUPtwmG/YfyflQSUmTckJ xSD5QvPO5yw1C+LiYg1Az8ytrcMrDCZHcvBxNpCoKDe+qMjjf6bR40myzgnrLgS6QJ XP5lQqGlOZopAoGcU4sp8UyUKud4YuN/z10SQ0s4= Date: Sat, 24 Oct 2020 01:28:53 +0100 From: Mark Brown To: lgirdwood@gmail.com, perex@perex.cz, Olivier Moysan , alexandre.torgue@st.com, tiwai@suse.com, arnaud.patard@rtp-net.org Cc: alsa-devel@alsa-project.org, arnaud.pouliquen@st.com, linux-stm32@st-md-mailman.stormreply.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org In-Reply-To: <20201020150109.482-1-olivier.moysan@st.com> References: <20201020150109.482-1-olivier.moysan@st.com> Subject: Re: [PATCH v2] ASoC: cs42l51: manage mclk shutdown delay Message-Id: <160349931941.28438.14503960964995572782.b4-ty@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 20 Oct 2020 17:01:09 +0200, Olivier Moysan wrote: > A delay must be introduced before the shutdown down of the mclk, > as stated in CS42L51 datasheet. Otherwise the codec may > produce some noise after the end of DAPM power down sequence. > The delay between DAC and CLOCK_SUPPLY widgets is too short. > Add a delay in mclk shutdown request to manage the shutdown delay > explicitly. From experiments, at least 10ms delay is necessary. > Set delay to 20ms as recommended in Documentation/timers/timers-howto.rst > when using msleep(). Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: cs42l51: manage mclk shutdown delay commit: 20afe581c9b980848ad097c4d54dde9bec7593ef All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark