Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 23 Oct 2020 22:09:35 +0100
From:   Matthew Wilcox <willy@infradead.org>
To:     Rik van Riel <riel@surriel.com>
Cc:     Hugh Dickins <hughd@google.com>, Yu Xu <xuyu@linux.alibaba.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Mel Gorman <mgorman@suse.de>,
        Andrea Arcangeli <aarcange@redhat.com>, linux-mm@kvack.org,
        kernel-team@fb.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] mm,thp,shmem: limit shmem THP alloc gfp_mask
Message-ID: <20201023210935.GG20115@casper.infradead.org>
References: <20201023164708.5842f3fb@imladris.surriel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201023164708.5842f3fb@imladris.surriel.com>
Precedence: bulk

On Fri, Oct 23, 2020 at 04:47:08PM -0400, Rik van Riel wrote:
> +++ b/include/linux/gfp.h
> @@ -614,6 +614,8 @@ bool gfp_pfmemalloc_allowed(gfp_t gfp_mask);
>  extern void pm_restrict_gfp_mask(void);
>  extern void pm_restore_gfp_mask(void);
>  
> +extern gfp_t alloc_hugepage_direct_gfpmask(struct vm_area_struct *vma);

Without the types, the name of this function makes me think it allocates
something.  Like alloc_hugepage_vma() does.  With the types, it's obvious
that it gets the gfpmask.  Can this patch rename it, perhaps to

gfp_t vma_thp_gfp_mask(struct vm_area_struct *vma);

(hugepage is also ambiguous because it might be for hugetlbfs and we use,
eg, mapping_gfp_mask, not mapping_gfpmask).