Date: Sun, 13 Aug 2006 21:02:02 -0700 (PDT)
Message-Id: <20060813.210202.127668846.davem@davemloft.net>
To: kaber@trash.net
Cc: akpm@osdl.org, mita@miraclelinux.com, linux-kernel@vger.kernel.org,
       netdev@vger.kernel.org
Subject: Re: [PATCH] fix use after free in netlink_kernel_create()
From: David Miller <davem@davemloft.net>
In-Reply-To: <44DF7422.2090904@trash.net>
References: <44DF129A.6060607@trash.net>
	<20060813104405.a5c8db00.akpm@osdl.org>
	<44DF7422.2090904@trash.net>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1268
Lines: 33

From: Patrick McHardy <kaber@trash.net>
Date: Sun, 13 Aug 2006 20:49:06 +0200

> Andrew Morton wrote:
> > On Sun, 13 Aug 2006 13:52:58 +0200
> > Patrick McHardy <kaber@trash.net> wrote:
> > 
> >>Quite a few users of netlink_kernel_create will panic when creating
> >>the socket fails (rtnetlink for example, which is always present),
> >>so you might as well call panic here directly.
> > 
> > 
> > That's a bit lame.  Panicing at do_initcalls() time is OK (something is
> > seriously screwed anyway) but we usually try to handle the ENOMEM nicely if
> > it happens at modprobe-time.
> 
> The users I looked at can't be built as modules (rtnetlink, genetlink,
> audit subsystem), I'm not aware of any modules panicing on
> netlink_kernel_create failure. But all of netlink, genetlink and
> rtnetlink are always built-in when CONFIG_NET=y, so we might as well
> panic here.

Agreed.

netlink_proto_init() is a core_initcall(), we are pretty much in
an irrecoverable bind if that thing fails, so panic() is appropriate
here.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/