Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp1359043pxu; Sat, 24 Oct 2020 08:14:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz6rSHBQctHVZTte9nyumSWDufFczWjiuuFOHG60Hpoq5ax0XvX2rU1xiunWbnKn8gAaNv1 X-Received: by 2002:a05:6402:104d:: with SMTP id e13mr7371757edu.322.1603552492127; Sat, 24 Oct 2020 08:14:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1603552492; cv=none; d=google.com; s=arc-20160816; b=ItnvfE4mf2eGmg06GZ54SUyqst2QEuWXs/R+jJvIUl9MFGzznijAbWxNtBa+ycQS1X tn+KYXpY/cpSyyrRmcCj44dx9LdB0PSQGxymgmgwaBFzBH1WyHpi4n80jTR3cb3rOY+s wqRGuGAS8UPBfm7K48b36phGpmE5VpEUXiTp80C6Cc+N8okoWk7mE9B7f19b80uICref dSO2rxhnYG3ApjlztJx/boUMOO4UFu6JresaHJ2Gef7CqNoYm1ajoTm3Pl7vItAbhAtn EPvoohJ1gxjgM/XhL+wwoaPbNlSUKCpiJoUzJAXsgAtk9Oj889oq94iKvOxtK3RIPA2I e+lQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from; bh=+ueCZ0PEyqzDXwGBOmXLpAJ7pNtqdMq1mok42LiW4n4=; b=BHKdg9PCMI6zw+HvIeROKeqpKHVTg/PzfM/vNBL+f8poikJPiZqIQLKtYJDLUoCh6u 9zTmDRHa4r9iI84obGbmFTBvN5Zw92inbPlmKzK07ohYT8p+XxPKYUK9Dq+F8qL6+TA/ xJ9IrCN01JG/Qd5iJCGD784chDdf4heqZ8nrXEXLtWbylr5TOBZk6+6FpoK9mzQZ29B+ s+rGllD0vMwpO1SOJYUlB1glw7BO15PaRhrIhM+k2RFe1E5eBzIMQ968CeaSiH9UiRCf QhLAgMRNwpdZS6Yzarj87w6DZ2qfVRYHJFnHFL6gW4L448/Vj27WxAP4OYoFpakfy1DW AjWg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id lg21si3303638ejb.136.2020.10.24.08.14.30; Sat, 24 Oct 2020 08:14:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761323AbgJXMP0 (ORCPT + 99 others); Sat, 24 Oct 2020 08:15:26 -0400 Received: from inva020.nxp.com ([92.121.34.13]:35194 "EHLO inva020.nxp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761240AbgJXMOl (ORCPT ); Sat, 24 Oct 2020 08:14:41 -0400 Received: from inva020.nxp.com (localhost [127.0.0.1]) by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id 56A531A0BF9; Sat, 24 Oct 2020 14:14:39 +0200 (CEST) Received: from inva024.eu-rdc02.nxp.com (inva024.eu-rdc02.nxp.com [134.27.226.22]) by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id 3DF2D1A0BF8; Sat, 24 Oct 2020 14:14:39 +0200 (CEST) Received: from fsr-ub1864-126.ea.freescale.net (fsr-ub1864-126.ea.freescale.net [10.171.82.212]) by inva024.eu-rdc02.nxp.com (Postfix) with ESMTP id 259C2202EC; Sat, 24 Oct 2020 14:14:38 +0200 (CEST) From: Ioana Ciornei To: Andrew Lunn , Heiner Kallweit , Russell King , Jakub Kicinski , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Ioana Ciornei , Alexandru Ardelean , Andre Edich , Antoine Tenart , Baruch Siach , Christophe Leroy , Dan Murphy , Divya Koppera , Florian Fainelli , Hauke Mehrtens , Jerome Brunet , Kavya Sree Kotagiri , Linus Walleij , Marco Felsch , Marek Vasut , Martin Blumenstingl , Mathias Kresin , Maxim Kochetkov , Michael Walle , Neil Armstrong , Nisar Sayed , Oleksij Rempel , Philippe Schenker , Willy Liu , Yuiko Oshino Subject: [RFC net-next 3/5] net: phy: make .ack_interrupt() optional Date: Sat, 24 Oct 2020 15:14:10 +0300 Message-Id: <20201024121412.10070-4-ioana.ciornei@nxp.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201024121412.10070-1-ioana.ciornei@nxp.com> References: <20201024121412.10070-1-ioana.ciornei@nxp.com> X-Virus-Scanned: ClamAV using ClamSMTP Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org As a first step into making phylib and all PHY drivers to actually have support for shared IRQs, make the .ack_interrupt() callback optional. After all drivers have been moved to implement the generic interrupt handle, the phy_drv_supports_irq() check will be changed again to only require the .handle_interrupts() callback. Cc: Alexandru Ardelean Cc: Andre Edich Cc: Antoine Tenart Cc: Baruch Siach Cc: Christophe Leroy Cc: Dan Murphy Cc: Divya Koppera Cc: Florian Fainelli Cc: Hauke Mehrtens Cc: Heiner Kallweit Cc: Jerome Brunet Cc: Kavya Sree Kotagiri Cc: Linus Walleij Cc: Marco Felsch Cc: Marek Vasut Cc: Martin Blumenstingl Cc: Mathias Kresin Cc: Maxim Kochetkov Cc: Michael Walle Cc: Neil Armstrong Cc: Nisar Sayed Cc: Oleksij Rempel Cc: Philippe Schenker Cc: Willy Liu Cc: Yuiko Oshino Signed-off-by: Ioana Ciornei --- drivers/net/phy/phy_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c index 413a0a2c5d51..f54f483d7fd6 100644 --- a/drivers/net/phy/phy_device.c +++ b/drivers/net/phy/phy_device.c @@ -2815,7 +2815,7 @@ EXPORT_SYMBOL(phy_get_internal_delay); static bool phy_drv_supports_irq(struct phy_driver *phydrv) { - return phydrv->config_intr && phydrv->ack_interrupt; + return phydrv->config_intr && (phydrv->ack_interrupt || phydrv->handle_interrupt); } /** -- 2.28.0