Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <5c11f284872f3b2b017d9d27d4075582c1a40eab.camel@perches.com>
Subject: Re: [PATCH v3] checkpatch: fix false positives in REPEATED_WORD
 warning
From:   Joe Perches <joe@perches.com>
To:     Aditya <yashsri421@gmail.com>,
        Lukas Bulwahn <lukas.bulwahn@gmail.com>
Cc:     linux-kernel@vger.kernel.org,
        linux-kernel-mentees@lists.linuxfoundation.org,
        dwaipayanray1@gmail.com
Date:   Sat, 24 Oct 2020 08:33:46 -0700
In-Reply-To: <c9512657-d7d0-bf04-0e40-b3463c9f5e1b@gmail.com>
References: <20201023133828.19609-1-yashsri421@gmail.com>
         <alpine.DEB.2.21.2010232104150.11676@felia>
         <c9512657-d7d0-bf04-0e40-b3463c9f5e1b@gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.38.1-1 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Sat, 2020-10-24 at 18:54 +0530, Aditya wrote:
> > Would you like to work on 
> > further rules that can be improved with your evaluation approach?
> 
> Yes, I would like work on further rules.

Some generic ideas:

How about working to reduce runtime and complexity by
making the rules extensible or separable at startup.

Maybe move each existing rules into a separate
directory as an individual file and aggregate them at
checkpatch startup.

Maybe look at the existing rules that do not have a
$fix option and add them as appropriate.

You could fix the multiline indentation where the
current warning and fix is only for a single line

	value = function(arg1,
		arg2,
		arg3);

where checkpatch emits only single warning and fix
for the line with arg2, but not the line with arg3);

Maybe try to make the coding styles supported more
flexible:

Allow braces in different places, support different
tab indentation sizes, spacing rules around operators,
function definition layouts, etc.