Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp179800pxu; Sat, 24 Oct 2020 20:21:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyW98Kws5z38LJBCP2j172d6EusNwFuAOHE4eyaDZPfaflLLxdJab9kMjfZ+S4VUEBuZ/9N X-Received: by 2002:a05:6402:392:: with SMTP id o18mr9833388edv.283.1603596066956; Sat, 24 Oct 2020 20:21:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1603596066; cv=none; d=google.com; s=arc-20160816; b=cN6ap8mjx7Gde+kWLr5Z2B928uRly2QDxNJ51LILINiMygmmC3HWpN8sD2clk37UBy /hRHRSer2d/Hfd+44zHpVc1f3YwkSuMDVztAbCknY8lYYawxSSUlzvDjPMCVG38lgWB8 zTdGsmT02G0f1EUQ04YRGiROCjocNgfnVFxxmEa72ibJViOTLCQWspyZcGwnBcfyPNh8 7YDpEa1Kk8IJ0359fzLjljmSI7NfrQ16bi+D3My0ndSlCWHIk+TGdAQz2K2+tFUlMkvH GqpnNdx4IL+8WeDRUglrC0wQvD+EF7A/zPaVOzIq68hpMTiV1rilvsKFc0za0hmtiaNQ qYmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-language:content-transfer-encoding :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=DLMvmiGErsLTvHJlAUfm5XCoZVDF9c6VQwTXEbmBAMM=; b=DBbfKnyU14xW9s7nLAzUsEH5mZ2KxGaxui8tTurecU9HgRBJEI5WM7UFI9FzveR6XK xVCmbiJtmzNfD3/w8Mn+SX5EI+JsDq4zAirwUAfdQReQjyvRU+dSrxyVrU0Ohh2f2CA/ S9S6WIeFysI1UvxzviX9JFDNrYjtJY4KwP55e/Rm0Qrhui7tpLZ5rk4NrhXWtxsM9j65 zYJk27F0faZkgf7oHt4lr7yKJ8SYdo3hBR+SHgnFw6IYL6R4c4meyu2dI5EWDV9unkat 9OhbHh6YIy6t0jAS7I7uB2SchW8Yx/0Dn5XIKTavdwx2sXOsmsP0fjD+p6um2rJyZxog 0Kig== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=bd++ygZp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 23si4242924ejx.661.2020.10.24.20.20.44; Sat, 24 Oct 2020 20:21:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=bd++ygZp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762570AbgJXW2K (ORCPT + 99 others); Sat, 24 Oct 2020 18:28:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42128 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1762500AbgJXW2K (ORCPT ); Sat, 24 Oct 2020 18:28:10 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B6066C0613CE; Sat, 24 Oct 2020 15:28:09 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id y12so7366322wrp.6; Sat, 24 Oct 2020 15:28:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=DLMvmiGErsLTvHJlAUfm5XCoZVDF9c6VQwTXEbmBAMM=; b=bd++ygZpbXy8AU457/vEPIxmaxI41RoSc7HV9NEpYgjV94zX40vQnhaI/0AaGiMjZQ 4+jZ3jVjSOljKUV5OlU3napeL52DOdD4nV1Squ6cqsU0uKSNDZKPYAujgkYfJk5fJusz 0+RXWAZqd7R2R+pk7PEju/O+41yVvP+h72Hn2J+dVg4ggFqM8mrnG2KLdFk02dM6eTPb PV+uCFdSEXKMjXlojQKDrUApuz7QRtw1VCi9i1i2X1J5pUdssgZX8c7RCrDWgpoLblWW JeGDGxvYiJrzX8MkBkH7ThyL3JoOXd6ixmKBzogEv+CNMV8v3VF+l6EqgLrzU52B9+N2 shsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=DLMvmiGErsLTvHJlAUfm5XCoZVDF9c6VQwTXEbmBAMM=; b=fVu8HMxJx3aGFjsXNs4kkNoanw8X0N9seRaNvzh1H367QyA5AWeNe7qURaj2tC1twD ZCFoqX/cIyYfhRlFIjc6uDTSq6PNLO5r5WtIUeBA9fCfgrTxsGO260+Vw5QgJ6uzrhU3 X+rXFp49W9wteWGfNiwaks5dSmwy1dNG6DjQ7jhIez3ISSZO86envMZ5uEUWeX2XklAc yhgDwREBclJHu40oOQH/dsB1/ba6FK7aYF57EmMs6zI027FojIDo90WePAxYU+hU89SH R1GlX57EoGjjTG46bVnoYCW0Bzu+aZEH/Cz0x3unryhMA37HEMnBY42V8gh0Ss1tKMNV 6FDg== X-Gm-Message-State: AOAM530jdqrwIViGjjxCtPiz3tE0/6ASN8oxdxVcfht8YnYO3/XrbNY8 /5/rPO/U8rJBsItEOBYyKSE= X-Received: by 2002:adf:d849:: with SMTP id k9mr9317520wrl.332.1603578488363; Sat, 24 Oct 2020 15:28:08 -0700 (PDT) Received: from [192.168.1.158] ([2.29.20.56]) by smtp.gmail.com with ESMTPSA id 4sm14205299wrn.48.2020.10.24.15.28.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 24 Oct 2020 15:28:07 -0700 (PDT) Subject: Re: [RFC PATCH v3 9/9] ipu3-cio2: Add functionality allowing software_node connections to sensors on platforms designed for Windows To: Laurent Pinchart Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linus.walleij@linaro.org, prabhakar.mahadev-lad.rj@bp.renesas.com, heikki.krogerus@linux.intel.com, dmitry.torokhov@gmail.com, laurent.pinchart+renesas@ideasonboard.com, kieran.bingham+renesas@ideasonboard.com, jacopo+renesas@jmondi.org, robh@kernel.org, davem@davemloft.net, linux@rasmusvillemoes.dk, andriy.shevchenko@linux.intel.com, sergey.senozhatsky@gmail.com, rostedt@goodmis.org, pmladek@suse.com, mchehab@kernel.org, tian.shu.qiu@intel.com, bingbu.cao@intel.com, sakari.ailus@linux.intel.com, yong.zhi@intel.com, rafael@kernel.org, gregkh@linuxfoundation.org, kitakar@gmail.com References: <20201019225903.14276-1-djrscally@gmail.com> <20201019225903.14276-10-djrscally@gmail.com> <20201024012411.GT5979@pendragon.ideasonboard.com> <20201024093702.GA3939@pendragon.ideasonboard.com> From: Daniel Scally Message-ID: <748d34c3-a146-12fe-22c0-8dfef9006ea0@gmail.com> Date: Sat, 24 Oct 2020 23:28:06 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201024093702.GA3939@pendragon.ideasonboard.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Laurent On 24/10/2020 10:37, Laurent Pinchart wrote: > >>> I wonder if we could avoid depending on the I2C device being created by >>> getting the fwnode from adev, and setting ->secondary manually. adev >>> would need to be passed to get_acpi_ssdb_sensor_data() instead of dev. >> Let me try that; I initially wanted to do >> set_secondary_fwnode(&adev->dev, fwnode) to avoid depending on the I2C >> dev being created but it turns out &adev->dev isn't the same pointer. I >> shall try it and see. Actually, thinking on this further I think maybe we can't avoid that - it's not actually in this patch series but during assigning GPIO resources parsed from PMIC's ACPI node to the sensor, I'm using dev_name() on the i2c dev to pass to .dev_id member of gpiod_lookup_table