Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: roVLaPsccHjPrP0y/OFFQ8FdQOHw0HklyDmpaVtJbpYHVodY1jMfE0BT9FvvvB0sDxrUMr127C
 I6uby+z1rPsw==
IronPort-SDR: UqOdMLpqeaOJGRdmFtchIX7fm31n+hGQHCbX4LZQi8RbkzJGrpwKZeKY8xGIIc1SlqSSAiA39G
 fMPzU6lzAXWQ==
Date:   Sat, 24 Oct 2020 22:30:45 -0700
From:   Andi Kleen <ak@linux.intel.com>
To:     Namhyung Kim <namhyung@kernel.org>
Cc:     Arnaldo Carvalho de Melo <acme@kernel.org>,
        Jiri Olsa <jolsa@redhat.com>, Ingo Molnar <mingo@kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Stephane Eranian <eranian@google.com>,
        Ian Rogers <irogers@google.com>
Subject: Re: [PATCH 1/2] perf test: Use generic event for
 expand_libpfm_events()
Message-ID: <20201025053045.GV466880@tassilo.jf.intel.com>
References: <20201024025918.453431-1-namhyung@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201024025918.453431-1-namhyung@kernel.org>
Precedence: bulk

On Sat, Oct 24, 2020 at 11:59:17AM +0900, Namhyung Kim wrote:
> I found that the UNHALTED_CORE_CYCLES event is only available in the
> Intel machines and it makes other vendors/archs fail on the test.  As
> libpfm4 can parse the generic events like cycles, let's use them.
> 
> Fixes: 40b74c30ffb9 ("perf test: Add expand cgroup event test")
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>

So would the test still fail when libpfm is not compiled in?

-Andi