Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201024061552.4497-1-coiby.xu@gmail.com>
In-Reply-To: <20201024061552.4497-1-coiby.xu@gmail.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Sun, 25 Oct 2020 19:12:16 +0200
Message-ID: <CAHp75VdRBPcdRaTjnDNk5nSN8fMY--Gq=042+fYGddv=Xs6uHw@mail.gmail.com>
Subject: Re: [PATCH] pinctrl: amd: print debounce filter info in debugfs
To:     Coiby Xu <coiby.xu@gmail.com>
Cc:     "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        Hans de Goede <hdegoede@redhat.com>,
        open list <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sat, Oct 24, 2020 at 2:32 PM Coiby Xu <coiby.xu@gmail.com> wrote:
>
> Print out the status of debounce filter as follows,
> $ cat /sys/kernel/debug/gpio|grep pin130
> pin130          interrupt is disabled| interrupt is masked| disable wakeup in S0i3 state| disable wakeup in S3 state|
>  disable wakeup in S4/S5 state| input is high|   pull-up is disabled| Pull-down is disabled|   output is disabled| debouncing filter (high) enabled| debouncing timeout is 124800 (us)| 0x503c8


> +                               if (!tmr_large) {
> +                                       if (!tmr_out_unit)
> +                                               unit = 61;
> +                                       else
> +                                               unit = 244;
> +                               } else {
> +                                       if (!tmr_out_unit)
> +                                               unit = 15600;
> +                                       else
> +                                               unit = 62500;
> +                               }

In all three if:s can you use positive conditionals?

-- 
With Best Regards,
Andy Shevchenko