Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: irs/A6VTzQ1otfWw+OYX1rPeXUsbACh5xG2/x/7IKAUOnPMSojcEOx5EXe2RTUAwrsPBZ24LAI
 hxTDtTUsbYXUFV/wu4fDExux5gE0iUbH8T5FjUNSsVqDotaRbF7GVWrRdrX7y4c6nQoxZv1h32
 wekjhy22VXEeNhBHo/BlS+6YZRe+jj3PUMX55rJXS456vlc5fy3TJRXF2aOiSeKKz9K0db9MFL
 wvcg1RvtJkrkNlcRHcGngGqhyxuTfy/qeGA0uFfGdD7C1LbTDkeZQUB+njwSp08kXq+kuRKElX
 ArA=
From:   Avri Altman <Avri.Altman@wdc.com>
To:     Can Guo <cang@codeaurora.org>
CC:     "asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
        "nguyenb@codeaurora.org" <nguyenb@codeaurora.org>,
        "hongwus@codeaurora.org" <hongwus@codeaurora.org>,
        "rnayak@codeaurora.org" <rnayak@codeaurora.org>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "kernel-team@android.com" <kernel-team@android.com>,
        "saravanak@google.com" <saravanak@google.com>,
        "salyzyn@google.com" <salyzyn@google.com>,
        Alim Akhtar <alim.akhtar@samsung.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        Stanley Chu <stanley.chu@mediatek.com>,
        Bean Huo <beanhuo@micron.com>,
        Bart Van Assche <bvanassche@acm.org>,
        open list <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2 1/1] scsi: ufs: Fix unexpected values get from
 ufshcd_read_desc_param()
Thread-Topic: [PATCH v2 1/1] scsi: ufs: Fix unexpected values get from
 ufshcd_read_desc_param()
Thread-Index: AQHWqDiMF/4I9jj2BU+KaBIJftcln6mjKqFAgAYSn4CAACGX0A==
Date:   Mon, 26 Oct 2020 05:22:49 +0000
Message-ID: <BY5PR04MB67056EDDDA22DEDAFD1972C1FC190@BY5PR04MB6705.namprd04.prod.outlook.com>
References: <1603346348-14149-1-git-send-email-cang@codeaurora.org>
 <BY5PR04MB6705D719530D5E188ECB724EFC1D0@BY5PR04MB6705.namprd04.prod.outlook.com>
 <5271e570f2e38770da3b23f13e739e41@codeaurora.org>
In-Reply-To: <5271e570f2e38770da3b23f13e739e41@codeaurora.org>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 1359f5bd-4735-4da5-c2ed-08d8796f2e07
X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Oct 2020 05:22:49.2690
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: wb4I1FnugmlSGJUacoraYboC5vidFrdRK0LtxrtWTKwji295rNrNmFn8o1Yprnhhfcifadoyi/QF/Xfp/ULnsQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR04MB6454
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

=20
> On 2020-10-22 14:37, Avri Altman wrote:
> >> Since WB feature has been added, WB related sysfs entries can be
> >> accessed
> >> even when an UFS device does not support WB feature. In that case, the
> >> descriptors which are not supported by the UFS device may be wrongly
> >> reported when they are accessed from their corrsponding sysfs entries.
> >> Fix it by adding a sanity check of parameter offset against the actual
> >> decriptor length.s
> > This should be a bug fix IMO, and be dealt with similarly like
> > ufshcd_is_wb_attrs or ufshcd_is_wb_flag.
> > Thanks,
> > Avri
>=20
> Could you please elaborate on ufshcd_is_wb_attrs or ufshcd_is_wb_flag?
> Sorry that I don't quite get it.
Since this change is only protecting illegal access from sysfs entries,
I am suggesting to handle it there, just like ufshcd_is_wb_attrs or ufshcd_=
is_wb_flag
Are doing it for flags and attributes.

Thanks,
Avri