Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201021081030.160-1-zhenzhong.duan@gmail.com> <20201022152148.GA23673@infradead.org>
In-Reply-To: <20201022152148.GA23673@infradead.org>
From:   Zhenzhong Duan <zhenzhong.duan@gmail.com>
Date:   Mon, 26 Oct 2020 10:52:10 +0800
Message-ID: <CAFH1YnNQ5fL3TFQg_UqcFH6-fgmR8ZN9WkFUF9ZWNtb8k6zvvA@mail.gmail.com>
Subject: Re: [PATCH 1/2] PCI: export pci_match_device()
To:     Christoph Hellwig <hch@infradead.org>
Cc:     linux-kernel <linux-kernel@vger.kernel.org>,
        linux-pci@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Oct 22, 2020 at 11:21 PM Christoph Hellwig <hch@infradead.org> wrote:
>
> On Wed, Oct 21, 2020 at 04:10:29PM +0800, Zhenzhong Duan wrote:
> > pci_match_id() is deprecated as it doesn't catch any dynamic ids that
> > a driver might want to check for.
> >
> > Export pci_match_device() as a replacement which supports both dynamic
> > and static ids.
>
> You don't actually seems to add any user outside of the PCI core,
> so I think you only need to drop the static specifier and add a
> prototype.
Thanks for review, will do it. I'll combine the two patches into one
if no need to export.