Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp960447pxu; Sun, 25 Oct 2020 23:42:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzGZ+Lt71GJvc5D3HcOF2vrdY3hysimpHe+LLz6h5OEvtIZJKmiY9gtau3ODotjwR1NUcR9 X-Received: by 2002:a17:906:cc18:: with SMTP id ml24mr13557161ejb.298.1603694550840; Sun, 25 Oct 2020 23:42:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1603694550; cv=none; d=google.com; s=arc-20160816; b=XZepqX+4zSLdEnV3zSRjLxqL3XELvEqJ3qqrdlGFKILeQbVc2Vr2Fizysv5G+iYIFT 5WPU7KRHqqbuuFV7/hvsVy0vS8O25zQlUlPKcMElV0+4/jHuB1DFncrvgVmX5izbWSZo IjvG2rE2LeNJiStAvzfATDpLs32W30js9gu0011WVK8fEgX98ocohOgnACY1KJZ/a+rf P6/XgdYZeIKTwsTUJok0qPIYF4xaAIkX7+K0yp55exZ/3hhcuNih9HXWDJT6I3+UwJc7 KX4r1O3z2rSIzHcFrigo8e/39YbbQtuTx6E+C45pIJryWxyJqsE1lC1W7BZlEsxrpWfP E8NQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:message-id:references:in-reply-to :subject:cc:to:from:date:content-transfer-encoding:mime-version :sender:dkim-signature; bh=OSXsVLrma060OniBpnUdo6WkNY5oB43KMgRGs3wI2Mg=; b=BoDHuGXJSVNNaebr5vX4Z3bqnKSrBhBkOw9jPMLZezNS1O5JgF7icitufrFAOm3ymg tNcHUPc3bwMs2C4kKJyjZR4UexjGBVmYhwQQ38SsIJ7K4jaeaaxrSUGKb0qeokxlX86w s5npu53+7MIw43aLaASsziB9fwNNqkQUlWtcT2rSWQVyNm16DlZT3SWYc3xnzXslzRJX tSj9eLJsldUH0KkFWJAyYl1VcEeFuC61F88v2mzz+UQSwIcvJ/BoZZ+6IC10iUhLDJS8 1q0+sj4oW6OvPg7MQJYDD+8prpEEPbYqGlehliLGIA1hDLiReUdGh/tXYXP/bcCBCEb9 doQg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=wpGd44or; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a1si6321678ejt.206.2020.10.25.23.42.09; Sun, 25 Oct 2020 23:42:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=wpGd44or; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1421883AbgJZDT6 (ORCPT + 99 others); Sun, 25 Oct 2020 23:19:58 -0400 Received: from z5.mailgun.us ([104.130.96.5]:16865 "EHLO z5.mailgun.us" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389878AbgJZDT6 (ORCPT ); Sun, 25 Oct 2020 23:19:58 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1603682397; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=OSXsVLrma060OniBpnUdo6WkNY5oB43KMgRGs3wI2Mg=; b=wpGd44orEp8uaJ7rek2tNJuETrTX6jVJlRKJRnbkgKp1ESE4TwlR4ru79Lc4WCf4Ldrow9+L nrCYasVk0oT3GKagsJdhzjEEVG+x7l1Kp86vYZeLM3lB9nzrS0n9Cn/BvayIEE/VmpG9cOII 0MQVC8fmKjA5TPUhq23NoUi8sZE= X-Mailgun-Sending-Ip: 104.130.96.5 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n05.prod.us-west-2.postgun.com with SMTP id 5f9640505ac36f7b89a02ebe (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Mon, 26 Oct 2020 03:19:44 GMT Sender: cang=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 57681C433A1; Mon, 26 Oct 2020 03:19:44 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=ALL_TRUSTED,BAYES_00 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: cang) by smtp.codeaurora.org (Postfix) with ESMTPSA id 89741C433F0; Mon, 26 Oct 2020 03:19:43 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 26 Oct 2020 11:19:43 +0800 From: Can Guo To: Avri Altman Cc: asutoshd@codeaurora.org, nguyenb@codeaurora.org, hongwus@codeaurora.org, rnayak@codeaurora.org, linux-scsi@vger.kernel.org, kernel-team@android.com, saravanak@google.com, salyzyn@google.com, Alim Akhtar , "James E.J. Bottomley" , "Martin K. Petersen" , Stanley Chu , Bean Huo , Bart Van Assche , open list Subject: Re: [PATCH v2 1/1] scsi: ufs: Fix unexpected values get from ufshcd_read_desc_param() In-Reply-To: References: <1603346348-14149-1-git-send-email-cang@codeaurora.org> Message-ID: <5271e570f2e38770da3b23f13e739e41@codeaurora.org> X-Sender: cang@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Avri, On 2020-10-22 14:37, Avri Altman wrote: >> Since WB feature has been added, WB related sysfs entries can be >> accessed >> even when an UFS device does not support WB feature. In that case, the >> descriptors which are not supported by the UFS device may be wrongly >> reported when they are accessed from their corrsponding sysfs entries. >> Fix it by adding a sanity check of parameter offset against the actual >> decriptor length.s > This should be a bug fix IMO, and be dealt with similarly like > ufshcd_is_wb_attrs or ufshcd_is_wb_flag. > Thanks, > Avri Could you please elaborate on ufshcd_is_wb_attrs or ufshcd_is_wb_flag? Sorry that I don't quite get it. Thanks, Can Guo.