Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp960990pxu; Sun, 25 Oct 2020 23:43:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJynAe52TdBimssnkaZmMP1Ky8x/MQg+BtsJl9JZXdcPSCi7I719ICVwp5Ocn+Ubh/uSshmD X-Received: by 2002:a50:d555:: with SMTP id f21mr14704716edj.334.1603694619634; Sun, 25 Oct 2020 23:43:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1603694619; cv=none; d=google.com; s=arc-20160816; b=FjdIJmrjPxzhQA+0pG+qavPNvqsA/fUQ7e5uscamqsOzaQYT2mrrnDQ5jt9CWA1ade 4N4K7G7X7SdjhHcRABozx5I69srTV/RDLIbt9kFuKKeqEw+f1+iS6Cpkx+GuWljCgPGI Y9wcuu1O/xKPTlPjrCfA4OGBwac8RSt8dL2IaHROsHxhIsmQGwdYQlfoMvPUJ6++HEQ3 QXD7V8KhNm5J0V44YWgEWqUNoMgy0fJUOUD1ECSHxi5LHKoQI7+v8LPc8fgo4spTfayr x+f8ib016OLjyrOqJwL0KparLS9BYSP0K0WPkf8G7eoDT9NkSPW7t8D5C5wSSPNgznsJ sxYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :content-language:accept-language:in-reply-to:references:message-id :date:thread-index:thread-topic:subject:cc:to:from:dkim-signature; bh=WGPCTWXGaFEQAPnwBl3aSCOFQLjbIQTV4mrYNZQcNU4=; b=VwfrFFPnX6tq63/F/gdXVTpF94dWvRKHwAdJ4noPa4HsoIM0I9nOsTY13mKTVa4rc4 LqmAPHxwvQAmbReI755UL6KAYdzt/1byv5lDDPZwBv6bhOMz8sJ1A5/5uy4VELVxa82Q cvzkOwqiKN4k0gYEGWl9Gw0nCTIrMmHxABFAy8F8Jju24Yz+cQT07uelIh5GxUBgEq6W OO7d8a0en97uGQr2zbY4Vc49f1Kz0AD1HbdzYL76qFxaIPobo5P47AK0Rj40nzqy7BcT V0KxUeznTjWh6ukNs8weHNRqXlaZFTJ3l3KMwbFY5fqryU1Y0zL8yQf/nFSi+Cg21Gqh R/CQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=cO30POYX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id oi22si7556385ejb.754.2020.10.25.23.43.17; Sun, 25 Oct 2020 23:43:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=cO30POYX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726589AbgJZEIZ (ORCPT + 99 others); Mon, 26 Oct 2020 00:08:25 -0400 Received: from mail-pl1-f194.google.com ([209.85.214.194]:46484 "EHLO mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725988AbgJZEIZ (ORCPT ); Mon, 26 Oct 2020 00:08:25 -0400 Received: by mail-pl1-f194.google.com with SMTP id x10so1850759plm.13; Sun, 25 Oct 2020 21:08:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:thread-topic:thread-index:date:message-id :references:in-reply-to:accept-language:content-language :content-transfer-encoding:mime-version; bh=WGPCTWXGaFEQAPnwBl3aSCOFQLjbIQTV4mrYNZQcNU4=; b=cO30POYX/sxN9MDmzXtb087me5okMwPuXuVbzkxYNtKc/rLmzcOCszVtrj6+smGPJe LEEfnZT1eNX4jNO9D7D3qkbJzkaPXPXFOokoRCKyBGZFHGNDwtsO3d34rFjOfyOg+vaW /brioPH9sS7g24qKl+S37+iC5Tlz4v1M4KSq8MGOh+GlFTePvDvDSzYbh6/fh2IS2aRc nVYLkH/xn+4EsLbzrwcuyEJmF0gQv2vBCfbbGsfYBkCdHs3qRsXThuAUpclayXRhio7n grY/fVWYR6MDPvzbhj08LCZG1EejT8zL20mQTBu8qpe6UidX0fQevzouc9WTAfpZw34N z9bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:thread-topic:thread-index :date:message-id:references:in-reply-to:accept-language :content-language:content-transfer-encoding:mime-version; bh=WGPCTWXGaFEQAPnwBl3aSCOFQLjbIQTV4mrYNZQcNU4=; b=JgherFLoUuH4AObvFUzT0IoZsocecWijmmnpdEmM6lvSxulNPLE4EzLnmibNo1QPiB psVCg1DQln/yPC2LjyhB2yw86CJkIu8WporAXGxiIY1qNgBdJDmNDK3yz6G879MuYQnw wq1YnrlVlL9GwzX5PIXlyoWvGguvz8bZiVNDCPJrwQDVsu5BxLaKWuBwuQVFpSGe7GRZ Jw8Rh+7noiP4omd4NKkfEYp+Y16rEdFFNwaA8gc2Z+dT2RJD/dZaP5uWNx8mK3A5jtV4 vus5ayB0AYlbb5E6RdZ870I3Ztqt+CfEgNfQl1NZarcgRs3vJkXJwj7E0TsBznbKUUcN 7NRQ== X-Gm-Message-State: AOAM531VQtmYn2cXBxWxFCZFRJ0ocFy91u13Soc+3UFT4UYHPFzwq4SI H0oiQkExQYlxAOHN6USPri4= X-Received: by 2002:a17:90a:c388:: with SMTP id h8mr14628176pjt.100.1603685304291; Sun, 25 Oct 2020 21:08:24 -0700 (PDT) Received: from SLXP216MB0477.KORP216.PROD.OUTLOOK.COM ([2603:1046:100:9::5]) by smtp.gmail.com with ESMTPSA id x19sm10918981pjk.25.2020.10.25.21.08.20 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 25 Oct 2020 21:08:23 -0700 (PDT) From: Jingoo Han To: Jaehoon Chung , Marek Szyprowski , "linux-samsung-soc@vger.kernel.org" , "linux-pci@vger.kernel.org" CC: "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Krzysztof Kozlowski , Bjorn Helgaas , Lorenzo Pieralisi , Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Han Jingoo Subject: Re: [PATCH v2 5/6] pci: dwc: pci-exynos: rework the driver to support Exynos5433 variant Thread-Topic: [PATCH v2 5/6] pci: dwc: pci-exynos: rework the driver to support Exynos5433 variant Thread-Index: ATYzNHA3LqEW/SeHeSezfbTZ8+mXqGl5LTQyaXktNDK6VWtTUoADHkoAgAAV8aw= X-MS-Exchange-MessageSentRepresentingType: 1 Date: Mon, 26 Oct 2020 04:08:18 +0000 Message-ID: References: <20201023075744.26200-1-m.szyprowski@samsung.com> <20201023075744.26200-6-m.szyprowski@samsung.com> <29fa2071-dd4e-4528-d2db-dcd86e443794@samsung.com> In-Reply-To: <29fa2071-dd4e-4528-d2db-dcd86e443794@samsung.com> Accept-Language: ko-KR, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-Exchange-Organization-SCL: -1 X-MS-TNEF-Correlator: X-MS-Exchange-Organization-RecordReviewCfmType: 0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/25/20, 10:49 PM, Jaehoon Chung wrote: >=20 > Dear Jingoo, Hi Jaehoon, > On 10/24/20 12:12 PM, Jingoo Han wrote: > > On 10/23/20, 3:58 AM, Marek Szyprowski wrote: > >> > >> From: Jaehoon Chung > >> > >> Exynos5440 SoC support has been dropped since commit 8c83315da1cf ("AR= M: > >> dts: exynos: Remove Exynos5440"). Rework this driver to support DWC PC= Ie > >> variant found in the Exynos5433 SoCs. > >> > >> The main difference in Exynos5433 variant is lack of the MSI support > >> (the MSI interrupt is not even routed to the CPU). > >> > >> Signed-off-by: Jaehoon Chung > >> [mszyprow: reworked the driver to support only Exynos5433 variant, > >> simplified code, rebased onto current kernel code, added > >> regulator support, converted to the regular platform driver, > >> removed MSI related code, rewrote commit message] > >> Signed-off-by: Marek Szyprowski > >> Acked-by: Krzysztof Kozlowski > >> --- > >> drivers/pci/controller/dwc/Kconfig | 3 +- > >> drivers/pci/controller/dwc/pci-exynos.c | 358 ++++++++++-------------= - > >> drivers/pci/quirks.c | 1 + > >> 3 files changed, 145 insertions(+), 217 deletions(-) > >=20 > > [....] > >=20 > >> diff --git a/drivers/pci/controller/dwc/pci-exynos.c b/drivers/pci/con= troller/dwc/pci-exynos.c > >> index 242683cde04a..58056fbdc2fa 100644 > >> --- a/drivers/pci/controller/dwc/pci-exynos.c > >> +++ b/drivers/pci/controller/dwc/pci-exynos.c > >> @@ -2,26 +2,23 @@ > >> /* > >> * PCIe host controller driver for Samsung Exynos SoCs > >> * > >> - * Copyright (C) 2013 Samsung Electronics Co., Ltd. > >> + * Copyright (C) 2013-2020 Samsung Electronics Co., Ltd. > >> * https://www.samsung.com > >> * > >> * Author: Jingoo Han > >> + * Jaehoon Chung > >=20 > > Would you explain the reason why you add him as an author? > > If reasonable, I will accept it. Also, I want gentle discussion, not ag= gressive one. > > Thank you. > > It's not important to add me as author. :) > If you don't want to accept it, i think it can be removed it. > I think that pci-exynos was supported on only exynos5440. > As you know, exynos5440 was not common as compared with other exynos SoC. > After this patch, pci-exynos is re-newed. Ah, I just thought that you are not interested in Exynos PCIe anymore. How= ever, if you want to submit other patches for supporting other Exynos PCIe, adding you as an = author is ok. There are many Exynos SoCs that support PCIe IP. So, if someone like you wh= o have good experience on Exynos, helps submitting patches for Exynos PCIe, it would be= very helpful. :-) Thank you. Best regards, Jingoo Han > > Best Regards, > Jaehoon Chung > > >=20 > > Best regards, > > Jingoo Han > >=20 > >> */ > >=20 > > [....] > >=20