Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2 14/15] perf record: start threads in the beginning of
 trace streaming
To:     Jiri Olsa <jolsa@redhat.com>,
        Alexey Budankov <alexey.budankov@linux.intel.com>
Cc:     Arnaldo Carvalho de Melo <acme@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Andi Kleen <ak@linux.intel.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        budankov.lore@gmail.com
References: <1ec29ed6-0047-d22f-630b-a7f5ccee96b4@linux.intel.com>
 <0584888b-17b3-7a62-e585-8582d8a2d439@linux.intel.com>
 <20201024154416.GF2589351@krava>
From:   Alexei Budankov <budankov.lore@gmail.com>
Organization: Intel Corp.
Message-ID: <18730616-8e60-70df-9624-d1fbc0a0893e@gmail.com>
Date:   Mon, 26 Oct 2020 11:39:43 +0300
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.4.0
MIME-Version: 1.0
In-Reply-To: <20201024154416.GF2589351@krava>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 24.10.2020 18:44, Jiri Olsa wrote:
> On Wed, Oct 21, 2020 at 07:10:09PM +0300, Alexey Budankov wrote:
>>
>> Start threads in detached state because its management is possible
>> via messaging. Block signals prior the threads start so only main
>> tool thread would be notified on external async signals during data
>> collection. Streaming threads connect one-to-one to mapped data
>> buffers and write into per-CPU trace files located at data directory.
>> Data buffers and threads are affined to local NUMA nodes and monitored
>> CPUs according to system topology. --cpu option can be used to specify
>> CPUs to be monitored.
>>
>> Signed-off-by: Alexey Budankov <alexey.budankov@linux.intel.com>
>> ---
>>  tools/perf/builtin-record.c | 128 +++++++++++++++++++++++++++++++++---
>>  1 file changed, 120 insertions(+), 8 deletions(-)
>>
>> diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
>> index a15642656066..1d41e996a994 100644
>> --- a/tools/perf/builtin-record.c
>> +++ b/tools/perf/builtin-record.c
>> @@ -56,6 +56,7 @@
>>  #include <poll.h>
>>  #include <pthread.h>
>>  #include <unistd.h>
>> +#include <sys/syscall.h>
>>  #include <sched.h>
>>  #include <signal.h>
>>  #ifdef HAVE_EVENTFD_SUPPORT
>> @@ -1377,6 +1378,62 @@ static void record__thread_munmap_filtered(struct fdarray *fda, int fd,
>>  		perf_mmap__put(map);
>>  }
>>  
>> +static void *record__thread(void *arg)
>> +{
>> +	enum thread_msg msg = THREAD_MSG__READY;
>> +	bool terminate = false;
>> +	struct fdarray *pollfd;
>> +	int err, ctlfd_pos;
>> +
>> +	thread = arg;
>> +	thread->tid = syscall(SYS_gettid);
>> +
>> +	err = write(thread->comm.ack[1], &msg, sizeof(msg));
>> +	if (err == -1)
>> +		pr_err("threads: %d failed to notify on start. Error %m", thread->tid);
>> +
>> +	pollfd = &(thread->pollfd);
> 
> I don't think braces are necessary in here

Corrected in v3.

Alexei