Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2 09/15] perf record: introduce thread specific objects
 for trace streaming
To:     Jiri Olsa <jolsa@redhat.com>,
        Alexey Budankov <alexey.budankov@linux.intel.com>
Cc:     Arnaldo Carvalho de Melo <acme@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Andi Kleen <ak@linux.intel.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        linux-kernel <linux-kernel@vger.kernel.org>
References: <1ec29ed6-0047-d22f-630b-a7f5ccee96b4@linux.intel.com>
 <bede5b00-8419-c03f-8595-7011679d363a@linux.intel.com>
 <20201024154431.GH2589351@krava>
From:   Alexei Budankov <budankov.lore@gmail.com>
Organization: Intel Corp.
Message-ID: <04657d10-dd5c-1dc6-77b8-665265ea66b9@gmail.com>
Date:   Mon, 26 Oct 2020 11:53:21 +0300
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.4.0
MIME-Version: 1.0
In-Reply-To: <20201024154431.GH2589351@krava>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 24.10.2020 18:44, Jiri Olsa wrote:
> On Wed, Oct 21, 2020 at 07:03:48PM +0300, Alexey Budankov wrote:
>>
>> Introduce thread local data object and its array to be used for
>> threaded trace streaming.
>>
>> Signed-off-by: Alexey Budankov <alexey.budankov@linux.intel.com>
>> ---
>>  tools/perf/builtin-record.c | 18 ++++++++++++++++++
>>  1 file changed, 18 insertions(+)
>>
>> diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
>> index ba26d75c51d6..8e512096a060 100644
>> --- a/tools/perf/builtin-record.c
>> +++ b/tools/perf/builtin-record.c
>> @@ -85,11 +85,29 @@ struct switch_output {
>>  	int		 cur_file;
>>  };
>>  
>> +struct thread_data {
>> +	pid_t		   tid;
>> +	struct {
>> +		int	   msg[2];
>> +		int	   ack[2];
>> +	} comm;
>> +	struct fdarray	   pollfd;
>> +	int		   ctlfd_pos;
>> +	struct mmap	   *maps;
>> +	int		   nr_mmaps;
>> +	struct record	   *rec;
>> +	unsigned long long samples;
>> +	unsigned long	   waking;
>> +	u64		   bytes_written;
>> +};
> 
> please merge the struct with the code that's using it

Corrected in v3.

Thanks,
Alexei

> 
> jirka
> 
>> +
>>  struct record {
>>  	struct perf_tool	tool;
>>  	struct record_opts	opts;
>>  	u64			bytes_written;
>>  	struct perf_data	data;
>> +	struct thread_data	*thread_data;
>> +	int			nr_thread_data;
>>  	struct auxtrace_record	*itr;
>>  	struct evlist	*evlist;
>>  	struct perf_session	*session;
>> -- 
>> 2.24.1
>>
>