Received: by 2002:a05:6a10:9e8c:0:0:0:0 with SMTP id y12csp229202pxx; Mon, 26 Oct 2020 07:20:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwu1fExt1pT/9V8hnLCQSW63mPfD/dkOyKqV8UZqP65Ae/L0/7j0EKveJlZ/NPGYY9CXcsF X-Received: by 2002:a17:906:4a97:: with SMTP id x23mr15554431eju.471.1603722043271; Mon, 26 Oct 2020 07:20:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1603722043; cv=none; d=google.com; s=arc-20160816; b=aanoTHubm9tcPkBQffU/MyVEpv/5TVJ7A/2SmA4q6m2Xn9uS84QD95stOKItZF+57o RV3pFRobSEYwi2Imyyt2PBt/ECUavxIvX77GfOFzRBuXmUhUByrQeJd1EbyqGhUWzTqO En6p7MEvBtOL9ezPBsWfij4a5fvB/6h5fW7eoa0fEAViKuc3zPEB9nxx+f728PjrKj1T Pq+vBzxSsUsDenpIHd44Jt1XQQye/T8W4PKgTMyfJgNMTHBpw3d03yoGDpw3mvYLYRKR 621/h2m+b9CCiNkWcVH5Qc5YAHCQ/O9Z4RaNusesVohIKdAdZy/XSnxPdBcro81PFYRr IeYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=5ZuZpYg69r5PObH7IRvC4Tr2npq7JAYOYMSheDEmb1Q=; b=AOgmSLkxIimRGuYP11bAqAH1biMS1r8yfmhae/ZJ9tN9rYIo2DRjqRw38VZn3vBEhV cVf2fPjn0gLT9jKUzg3K0Ddh7+2C8rlGvUx+TdvTLRncqx8V9rdZFVeLxDU9qW3iLeEy G7l3oikXw//sXJqTclzsqtBFioFjxsDfDa2v9A1Y1f69bx8CJByK2OJG7plBiQ8PLq8A SS8XylYhcC2bUb8SATiHSUs2QubTe5TyHGnijAMWCX/r043jwwpSY47L07sfKciUTJy5 xP0EhyFn7XigNA5/Q2ZIUwaNyxiwaRshtHpx4pr8rRdu1unBOOzIX4tneL6vHYOrLmvW gbZw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@broadcom.com header.s=google header.b=h+9WeuMS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=broadcom.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g1si6978761edt.484.2020.10.26.07.20.20; Mon, 26 Oct 2020 07:20:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@broadcom.com header.s=google header.b=h+9WeuMS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=broadcom.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1780692AbgJZNwn (ORCPT + 99 others); Mon, 26 Oct 2020 09:52:43 -0400 Received: from mail-lf1-f66.google.com ([209.85.167.66]:47035 "EHLO mail-lf1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1421385AbgJZNwn (ORCPT ); Mon, 26 Oct 2020 09:52:43 -0400 Received: by mail-lf1-f66.google.com with SMTP id v6so12155390lfa.13 for ; Mon, 26 Oct 2020 06:52:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5ZuZpYg69r5PObH7IRvC4Tr2npq7JAYOYMSheDEmb1Q=; b=h+9WeuMSwCaBkbJSCocPhM+/1imk/oHX8Qp+rOnX7PequFyXy45QxOdjlvAU8k8vq6 lOxpFEN5fMMKEl174OKNTsk0WmUA3DxE+O9jdAsm+N1R3k3yRYEZjvfHEU8FoWTw+jM0 S249+moOla6Licm7geXiHgkXLVo6YYZcLopmY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5ZuZpYg69r5PObH7IRvC4Tr2npq7JAYOYMSheDEmb1Q=; b=qiNYEKsRJ2wIn2RI/CxfIlCHA2Qr86NItb3aaMqRxeOb8FScdIG+y1wEtax6I3wN4p I9C+za3n4FDVplCZWN/LqVKr8wR96e3JdB9SzGnrqdoRfzGxBW4exJ6iSCpcpBLIlg/S J+tbN0sr4HMPuXv0vSk4OPne/K9PKtaIa3zinivmUpurJZq/IcvCEj8xlfm8UZlnPBVd CKYtVN1a6La5ttK/2AR8++GZM8BloBgFnAbeEmfJ5s1WtHcM8tpBE3AaO07F+zwUJJDs fwjLyGMGOSyWPkyxXnCzVlcdbh3/AfvMo0SOdFhFh53zFME9tQu0LUSsT6oLqD5cGvgv iVoA== X-Gm-Message-State: AOAM532j9GzPIHYLhYpD3fIoZWQyyTDtjjH+s53/Jb6I/VlS6Nu7UlIJ juOmZedQVVHWIt7NRxbSI03bLnfc13+TcqVUHkf2AQ== X-Received: by 2002:a19:8988:: with SMTP id l130mr4879722lfd.126.1603720358904; Mon, 26 Oct 2020 06:52:38 -0700 (PDT) MIME-Version: 1.0 References: <20201011182254.17776-1-rayagonda.kokatanur@broadcom.com> <20201011182254.17776-5-rayagonda.kokatanur@broadcom.com> <6232a47d-9ff1-9c4a-6ed1-80b4c6222cc0@broadcom.com> In-Reply-To: <6232a47d-9ff1-9c4a-6ed1-80b4c6222cc0@broadcom.com> From: Rayagonda Kokatanur Date: Mon, 26 Oct 2020 19:22:27 +0530 Message-ID: Subject: Re: [PATCH v1 4/6] i2c: iproc: fix typo in slave_isr function To: Ray Jui Cc: Ray Jui , Scott Branden , BCM Kernel Feedback , Wolfram Sang , Florian Fainelli , Brendan Higgins , Andy Shevchenko , Lori Hikichi , Dhananjay Phadke , linux-i2c , linux-arm Mailing List , Linux Kernel Mailing List Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="00000000000058819a05b2933e39" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --00000000000058819a05b2933e39 Content-Type: text/plain; charset="UTF-8" On Fri, Oct 23, 2020 at 10:51 PM Ray Jui wrote: > > > > On 10/11/2020 11:22 AM, Rayagonda Kokatanur wrote: > > Fix typo in bcm_iproc_i2c_slave_isr(). > > > > Fixes: c245d94ed106 ("i2c: iproc: Add multi byte read-write support for slave mode") > > This is merely a fix of typo in code comment and there's no functional > impact. Why do we need a Fixes tag on this (which indicates the fix > needs to be backported to LTS kernels)? Thank you Ray. I will remove Fixes tag and push patch v2. Best regards, Rayagonda > > > Signed-off-by: Rayagonda Kokatanur > > --- > > drivers/i2c/busses/i2c-bcm-iproc.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/i2c/busses/i2c-bcm-iproc.c b/drivers/i2c/busses/i2c-bcm-iproc.c > > index cd687696bf0b..7a235f9f5884 100644 > > --- a/drivers/i2c/busses/i2c-bcm-iproc.c > > +++ b/drivers/i2c/busses/i2c-bcm-iproc.c > > @@ -382,7 +382,7 @@ static bool bcm_iproc_i2c_slave_isr(struct bcm_iproc_i2c_dev *iproc_i2c, > > if (status & BIT(IS_S_START_BUSY_SHIFT)) { > > i2c_slave_event(iproc_i2c->slave, I2C_SLAVE_STOP, &value); > > /* > > - * Enable interrupt for TX FIFO becomes empty and > > + * Disable interrupt for TX FIFO becomes empty and > > * less than PKT_LENGTH bytes were output on the SMBUS > > */ > > val = iproc_i2c_rd_reg(iproc_i2c, IE_OFFSET); > > --00000000000058819a05b2933e39 Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" Content-Description: S/MIME Cryptographic Signature MIIQVwYJKoZIhvcNAQcCoIIQSDCCEEQCAQExDzANBglghkgBZQMEAgEFADALBgkqhkiG9w0BBwGg gg2sMIIE6DCCA9CgAwIBAgIOSBtqCRO9gCTKXSLwFPMwDQYJKoZIhvcNAQELBQAwTDEgMB4GA1UE CxMXR2xvYmFsU2lnbiBSb290IENBIC0gUjMxEzARBgNVBAoTCkdsb2JhbFNpZ24xEzARBgNVBAMT Ckdsb2JhbFNpZ24wHhcNMTYwNjE1MDAwMDAwWhcNMjQwNjE1MDAwMDAwWjBdMQswCQYDVQQGEwJC RTEZMBcGA1UEChMQR2xvYmFsU2lnbiBudi1zYTEzMDEGA1UEAxMqR2xvYmFsU2lnbiBQZXJzb25h bFNpZ24gMiBDQSAtIFNIQTI1NiAtIEczMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA tpZok2X9LAHsYqMNVL+Ly6RDkaKar7GD8rVtb9nw6tzPFnvXGeOEA4X5xh9wjx9sScVpGR5wkTg1 fgJIXTlrGESmaqXIdPRd9YQ+Yx9xRIIIPu3Jp/bpbiZBKYDJSbr/2Xago7sb9nnfSyjTSnucUcIP ZVChn6hKneVGBI2DT9yyyD3PmCEJmEzA8Y96qT83JmVH2GaPSSbCw0C+Zj1s/zqtKUbwE5zh8uuZ p4vC019QbaIOb8cGlzgvTqGORwK0gwDYpOO6QQdg5d03WvIHwTunnJdoLrfvqUg2vOlpqJmqR+nH 9lHS+bEstsVJtZieU1Pa+3LzfA/4cT7XA/pnwwIDAQABo4IBtTCCAbEwDgYDVR0PAQH/BAQDAgEG MGoGA1UdJQRjMGEGCCsGAQUFBwMCBggrBgEFBQcDBAYIKwYBBQUHAwkGCisGAQQBgjcUAgIGCisG AQQBgjcKAwQGCSsGAQQBgjcVBgYKKwYBBAGCNwoDDAYIKwYBBQUHAwcGCCsGAQUFBwMRMBIGA1Ud EwEB/wQIMAYBAf8CAQAwHQYDVR0OBBYEFGlygmIxZ5VEhXeRgMQENkmdewthMB8GA1UdIwQYMBaA FI/wS3+oLkUkrk1Q+mOai97i3Ru8MD4GCCsGAQUFBwEBBDIwMDAuBggrBgEFBQcwAYYiaHR0cDov L29jc3AyLmdsb2JhbHNpZ24uY29tL3Jvb3RyMzA2BgNVHR8ELzAtMCugKaAnhiVodHRwOi8vY3Js Lmdsb2JhbHNpZ24uY29tL3Jvb3QtcjMuY3JsMGcGA1UdIARgMF4wCwYJKwYBBAGgMgEoMAwGCisG AQQBoDIBKAowQQYJKwYBBAGgMgFfMDQwMgYIKwYBBQUHAgEWJmh0dHBzOi8vd3d3Lmdsb2JhbHNp Z24uY29tL3JlcG9zaXRvcnkvMA0GCSqGSIb3DQEBCwUAA4IBAQConc0yzHxn4gtQ16VccKNm4iXv 6rS2UzBuhxI3XDPiwihW45O9RZXzWNgVcUzz5IKJFL7+pcxHvesGVII+5r++9eqI9XnEKCILjHr2 DgvjKq5Jmg6bwifybLYbVUoBthnhaFB0WLwSRRhPrt5eGxMw51UmNICi/hSKBKsHhGFSEaJQALZy 4HL0EWduE6ILYAjX6BSXRDtHFeUPddb46f5Hf5rzITGLsn9BIpoOVrgS878O4JnfUWQi29yBfn75 HajifFvPC+uqn+rcVnvrpLgsLOYG/64kWX/FRH8+mhVe+mcSX3xsUpcxK9q9vLTVtroU/yJUmEC4 OcH5dQsbHBqjMIIDXzCCAkegAwIBAgILBAAAAAABIVhTCKIwDQYJKoZIhvcNAQELBQAwTDEgMB4G A1UECxMXR2xvYmFsU2lnbiBSb290IENBIC0gUjMxEzARBgNVBAoTCkdsb2JhbFNpZ24xEzARBgNV BAMTCkdsb2JhbFNpZ24wHhcNMDkwMzE4MTAwMDAwWhcNMjkwMzE4MTAwMDAwWjBMMSAwHgYDVQQL ExdHbG9iYWxTaWduIFJvb3QgQ0EgLSBSMzETMBEGA1UEChMKR2xvYmFsU2lnbjETMBEGA1UEAxMK R2xvYmFsU2lnbjCCASIwDQYJKoZIhvcNAQEBBQADggEPADCCAQoCggEBAMwldpB5BngiFvXAg7aE yiie/QV2EcWtiHL8RgJDx7KKnQRfJMsuS+FggkbhUqsMgUdwbN1k0ev1LKMPgj0MK66X17YUhhB5 uzsTgHeMCOFJ0mpiLx9e+pZo34knlTifBtc+ycsmWQ1z3rDI6SYOgxXG71uL0gRgykmmKPZpO/bL yCiR5Z2KYVc3rHQU3HTgOu5yLy6c+9C7v/U9AOEGM+iCK65TpjoWc4zdQQ4gOsC0p6Hpsk+QLjJg 6VfLuQSSaGjlOCZgdbKfd/+RFO+uIEn8rUAVSNECMWEZXriX7613t2Saer9fwRPvm2L7DWzgVGkW qQPabumDk3F2xmmFghcCAwEAAaNCMEAwDgYDVR0PAQH/BAQDAgEGMA8GA1UdEwEB/wQFMAMBAf8w HQYDVR0OBBYEFI/wS3+oLkUkrk1Q+mOai97i3Ru8MA0GCSqGSIb3DQEBCwUAA4IBAQBLQNvAUKr+ yAzv95ZURUm7lgAJQayzE4aGKAczymvmdLm6AC2upArT9fHxD4q/c2dKg8dEe3jgr25sbwMpjjM5 RcOO5LlXbKr8EpbsU8Yt5CRsuZRj+9xTaGdWPoO4zzUhw8lo/s7awlOqzJCK6fBdRoyV3XpYKBov Hd7NADdBj+1EbddTKJd+82cEHhXXipa0095MJ6RMG3NzdvQXmcIfeg7jLQitChws/zyrVQ4PkX42 68NXSb7hLi18YIvDQVETI53O9zJrlAGomecsMx86OyXShkDOOyyGeMlhLxS67ttVb9+E7gUJTb0o 2HLO02JQZR7rkpeDMdmztcpHWD9fMIIFWTCCBEGgAwIBAgIMPD6uL5K0fOjo8ln8MA0GCSqGSIb3 DQEBCwUAMF0xCzAJBgNVBAYTAkJFMRkwFwYDVQQKExBHbG9iYWxTaWduIG52LXNhMTMwMQYDVQQD EypHbG9iYWxTaWduIFBlcnNvbmFsU2lnbiAyIENBIC0gU0hBMjU2IC0gRzMwHhcNMjAwOTIxMTQw OTQ5WhcNMjIwOTIyMTQwOTQ5WjCBnDELMAkGA1UEBhMCSU4xEjAQBgNVBAgTCUthcm5hdGFrYTES MBAGA1UEBxMJQmFuZ2Fsb3JlMRYwFAYDVQQKEw1Ccm9hZGNvbSBJbmMuMRwwGgYDVQQDExNSYXlh Z29uZGEgS29rYXRhbnVyMS8wLQYJKoZIhvcNAQkBFiByYXlhZ29uZGEua29rYXRhbnVyQGJyb2Fk Y29tLmNvbTCCASIwDQYJKoZIhvcNAQEBBQADggEPADCCAQoCggEBAN9ijdrC8+HqBpo0E+Ls+FXg gOtAgdzwYtCbNN0FYITddIelxuEryOGaYFXqdi3WiAeyCbHIy0pRxs5Zqq0SLiAuaHbHc2t3cTGA WQ4i1+Z5ElQVIpZeHqb/exklZ7ZCZ8iUygtNsZqKyqgmFmDMkpEl0CT08yp8/xbhge9NVXOqmA0w O9iP6hfXOost0TwtIL/JlL94BiyaEOL7a3BwSRXhR2fJO17WpT8X27Dr0gJMx6X0rXkpiiF091Ml xVUYGnc0GLrYeHC2X4wJbUsgi+UFM/rVW0RKe5Sg4xmLXWc/rBhXDBVPeFVdN2dYsk5MyDRM/fXj cAA+xTX+SQGoND8CAwEAAaOCAdcwggHTMA4GA1UdDwEB/wQEAwIFoDCBngYIKwYBBQUHAQEEgZEw gY4wTQYIKwYBBQUHMAKGQWh0dHA6Ly9zZWN1cmUuZ2xvYmFsc2lnbi5jb20vY2FjZXJ0L2dzcGVy c29uYWxzaWduMnNoYTJnM29jc3AuY3J0MD0GCCsGAQUFBzABhjFodHRwOi8vb2NzcDIuZ2xvYmFs c2lnbi5jb20vZ3NwZXJzb25hbHNpZ24yc2hhMmczME0GA1UdIARGMEQwQgYKKwYBBAGgMgEoCjA0 MDIGCCsGAQUFBwIBFiZodHRwczovL3d3dy5nbG9iYWxzaWduLmNvbS9yZXBvc2l0b3J5LzAJBgNV HRMEAjAAMEQGA1UdHwQ9MDswOaA3oDWGM2h0dHA6Ly9jcmwuZ2xvYmFsc2lnbi5jb20vZ3NwZXJz b25hbHNpZ24yc2hhMmczLmNybDArBgNVHREEJDAigSByYXlhZ29uZGEua29rYXRhbnVyQGJyb2Fk Y29tLmNvbTATBgNVHSUEDDAKBggrBgEFBQcDBDAfBgNVHSMEGDAWgBRpcoJiMWeVRIV3kYDEBDZJ nXsLYTAdBgNVHQ4EFgQU1rE7oQJ7FiSTADFOqokePoGwIq4wDQYJKoZIhvcNAQELBQADggEBAD8I VcITGu1E61LQLR1zygqFw8ByKPgiiprMuQB74Viskl7pAZigzYJB8H3Mpd2ljve+GRo8yvbBC76r Gi5WdS06XI5vuImDJ2g6QUt754rj7xEYftM5Gy9ZMslKNvSiPPh1/ACx5w7ecD1ZK0YLMKGATeBD XybduRFIEPZBAjgJ5LOYT2ax3ZesfAkan1XJ97yLA93edgTTO2cbUAADTIMFWm4lI/e14wdGmK0I FtqJWw6DATg5ePiAAn+S0JoIL1xqKsZi2ioNqm02QMFb7RbB3yEGb/7ZLAGcPW666o5GSLsUnPPq YOfL/3X6tVfGeoi3IgfI+z76/lXk8vOQzQQxggJvMIICawIBATBtMF0xCzAJBgNVBAYTAkJFMRkw FwYDVQQKExBHbG9iYWxTaWduIG52LXNhMTMwMQYDVQQDEypHbG9iYWxTaWduIFBlcnNvbmFsU2ln biAyIENBIC0gU0hBMjU2IC0gRzMCDDw+ri+StHzo6PJZ/DANBglghkgBZQMEAgEFAKCB1DAvBgkq hkiG9w0BCQQxIgQgDv4ODrKMTuqJI/VI5FwV4oPnpApdbM7vAITGfG6CAOIwGAYJKoZIhvcNAQkD MQsGCSqGSIb3DQEHATAcBgkqhkiG9w0BCQUxDxcNMjAxMDI2MTM1MjM5WjBpBgkqhkiG9w0BCQ8x XDBaMAsGCWCGSAFlAwQBKjALBglghkgBZQMEARYwCwYJYIZIAWUDBAECMAoGCCqGSIb3DQMHMAsG CSqGSIb3DQEBCjALBgkqhkiG9w0BAQcwCwYJYIZIAWUDBAIBMA0GCSqGSIb3DQEBAQUABIIBAEH7 VD3x34pY3WiQWXKn3oBb77HaXiC9LgYqr68kNzfZttt/zBSd55jAQ2BGSnaRfbOGFrJnF4jeIuqi efvKEFgUzoWZbXFKjzLZcanIm/OhUSm5ffrYGnme5Fgc9fkP/YxCuhkp5JNG8/KGdlfyUwy//oV7 UsD8KGBvJ43yVYrN/3wBFHhQibJ/hdoMB+b9bXhjJ3x8kmifsdlffXygyujl+ICUKa7UOpUdLONJ MuNSJGrI3sEyiaifNoOg4VZod95LH8SgK2rR64SdW/m5nLrQk44sqQf6OkkbIeIK1YrVI3U7hRor 6q/yIxvMBDgINJ9BUJHsHn5S3t9E6yc9jJQ= --00000000000058819a05b2933e39--