Received: by 2002:a05:6a10:9e8c:0:0:0:0 with SMTP id y12csp234717pxx; Mon, 26 Oct 2020 07:28:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxWbAay8vpKmABqkvKDUNe1y90EtTmaLx0aWid7pTnVnahx1v6vx3zAx/LC8PH5NfVnrWGO X-Received: by 2002:a17:906:318f:: with SMTP id 15mr15285781ejy.180.1603722496921; Mon, 26 Oct 2020 07:28:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1603722496; cv=none; d=google.com; s=arc-20160816; b=XQNf4GAX7Ai2EbjuBJ8/2oQYlJ4u+5C1KkVQUifB5wDnRHYDKOvxF/kM1bb1ufHk7L EmA2+Ijf3BOfKJNOFdgMlV5LeX7mJJOWfar9aodKwNspSYp4PG0pA23iJK74MMqK7Ke5 TeTKJEZ9lHzEOZv38qywt0ub4IT+ntZJAXe9toMRj8Gu+98UfcJ3ZZ+Y7y9+V9+6D1b6 Nvp/vF4gu9CyaBheNjOunctnzv7SxIWqQkV1TkiKtlUDgCwAXwJuv8ZodUBORE4lwe06 ImLkf8pW3A1VNgVgr7dICOq496CkCVpvJdzX2QMkxauAti22w3wUdr2JzK6or/DBtG7A itSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:autocrypt:from :references:cc:to:subject:ironport-sdr:ironport-sdr; bh=VQIhEuQPJsSbD4FJIdaKdPqn1tntjpgcXUVvI2ve+oY=; b=Bm5S4LYAemhNlDGJFS0O/p09PKSN/vdbCEBaSwqa53EMX1RRdNso+CgIAZirHp1OfS LAck7iEK1rUBECgzuV69eM3oGfZk24FAs1FU1iYshJhnTpfnCdfEzxhpRdmp8J/N0f77 TJHmgPzlM8kbFv0KHu6M0IOFHBOlO0jTu7iSKBxzGNPgYqWFC1GYbOVJhxg7i90FQvPe ZVhS0mfKDuCA7BkQUIjzYt1eBFo0kHG4vytTm2ITQHiQ/iPr0+e1zmgb4zrf3km4xMhR 9/evxdlMotzq89PIcJo83gORlYVjTy3Y+4921GXe+9VGSukeKHA7LsfvVck1cPyYR9t4 QmLg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s12si6628279edy.583.2020.10.26.07.27.54; Mon, 26 Oct 2020 07:28:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1780921AbgJZOWX (ORCPT + 99 others); Mon, 26 Oct 2020 10:22:23 -0400 Received: from mga11.intel.com ([192.55.52.93]:59469 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1780807AbgJZOWX (ORCPT ); Mon, 26 Oct 2020 10:22:23 -0400 IronPort-SDR: 5Pt77JnQPKV2SW/BVZ3sE6DMcdpPtgCkUOgfvkFNGMcQzkLBdL6knijIrSS6MARi9DWlWu3DND byv5E3kiO1tA== X-IronPort-AV: E=McAfee;i="6000,8403,9785"; a="164431854" X-IronPort-AV: E=Sophos;i="5.77,419,1596524400"; d="scan'208";a="164431854" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Oct 2020 07:22:21 -0700 IronPort-SDR: zx/ut50ICtaU6P7xooH9x7iTUdM05LLmQswxh9qX7+rEM7BI64wCqazhLSfOmolsnyTLTO3OVK CzdsByKKeh+A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,419,1596524400"; d="scan'208";a="467941137" Received: from mattu-haswell.fi.intel.com (HELO [10.237.72.170]) ([10.237.72.170]) by orsmga004.jf.intel.com with ESMTP; 26 Oct 2020 07:22:18 -0700 Subject: Re: [PATCH] usb: remove unneeded break To: trix@redhat.com, balbi@kernel.org, gregkh@linuxfoundation.org, mathias.nyman@intel.com, johan@kernel.org, stern@rowland.harvard.edu, gustavoars@kernel.org, viro@zeniv.linux.org.uk, lee.jones@linaro.org Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, usb-storage@lists.one-eyed-alien.net References: <20201019150202.19713-1-trix@redhat.com> From: Mathias Nyman Autocrypt: addr=mathias.nyman@linux.intel.com; prefer-encrypt=mutual; keydata= mQINBFMB0ccBEADd+nZnZrFDsIjQtclVz6OsqFOQ6k0nQdveiDNeBuwyFYykkBpaGekoHZ6f lH4ogPZzQ+pzoJEMlRGXc881BIggKMCMH86fYJGfZKWdfpg9O6mqSxyEuvBHKe9eZCBKPvoC L2iwygtO8TcXXSCynvXSeZrOwqAlwnxWNRm4J2ikDck5S5R+Qie0ZLJIfaId1hELofWfuhy+ tOK0plFR0HgVVp8O7zWYT2ewNcgAzQrRbzidA3LNRfkL7jrzyAxDapuejuK8TMrFQT/wW53e uegnXcRJaibJD84RUJt+mJrn5BvZ0MYfyDSc1yHVO+aZcpNr+71yZBQVgVEI/AuEQ0+p9wpt O9Wt4zO2KT/R5lq2lSz1MYMJrtfFRKkqC6PsDSB4lGSgl91XbibK5poxrIouVO2g9Jabg04T MIPpVUlPme3mkYHLZUsboemRQp5/pxV4HTFR0xNBCmsidBICHOYAepCzNmfLhfo1EW2Uf+t4 L8IowAaoURKdgcR2ydUXjhACVEA/Ldtp3ftF4hTQ46Qhba/p4MUFtDAQ5yeA5vQVuspiwsqB BoL/298+V119JzM998d70Z1clqTc8fiGMXyVnFv92QKShDKyXpiisQn2rrJVWeXEIVoldh6+ J8M3vTwzetnvIKpoQdSFJ2qxOdQ8iYRtz36WYl7hhT3/hwkHuQARAQABtCdNYXRoaWFzIE55 bWFuIDxtYXRoaWFzLm55bWFuQGdtYWlsLmNvbT6JAjsEEwECACUCGwMGCwkIBwMCBhUIAgkK CwQWAgMBAh4BAheABQJTAeo1AhkBAAoJEFiDn/uYk8VJOdIP/jhA+RpIZ7rdUHFIYkHEKzHw tkwrJczGA5TyLgQaI8YTCTPSvdNHU9Rj19mkjhUO/9MKvwfoT2RFYqhkrtk0K92STDaBNXTL JIi4IHBqjXOyJ/dPADU0xiRVtCHWkBgjEgR7Wihr7McSdVpgupsaXhbZjXXgtR/N7PE0Wltz hAL2GAnMuIeJyXhIdIMLb+uyoydPCzKdH6znfu6Ox76XfGWBCqLBbvqPXvk4oH03jcdt+8UG 2nfSeti/To9ANRZIlSKGjddCGMa3xzjtTx9ryf1Xr0MnY5PeyNLexpgHp93sc1BKxKKtYaT0 lR6p0QEKeaZ70623oB7Sa2Ts4IytqUVxkQKRkJVWeQiPJ/dZYTK5uo15GaVwufuF8VTwnMkC 4l5X+NUYNAH1U1bpRtlT40aoLEUhWKAyVdowxW4yGCP3nL5E69tZQQgsag+OnxBa6f88j63u wxmOJGNXcwCerkCb+wUPwJzChSifFYmuV5l89LKHgSbv0WHSN9OLkuhJO+I9fsCNvro1Y7dT U/yq4aSVzjaqPT3yrnQkzVDxrYT54FLWO1ssFKAOlcfeWzqrT9QNcHIzHMQYf5c03Kyq3yMI Xi91hkw2uc/GuA2CZ8dUD3BZhUT1dm0igE9NViE1M7F5lHQONEr7MOCg1hcrkngY62V6vh0f RcDeV0ISwlZWuQINBFMB0ccBEACXKmWvojkaG+kh/yipMmqZTrCozsLeGitxJzo5hq9ev31N 2XpPGx4AGhpccbco63SygpVN2bOd0W62fJJoxGohtf/g0uVtRSuK43OTstoBPqyY/35+VnAV oA5cnfvtdx5kQPIL6LRcxmYKgN4/3+A7ejIxbOrjWFmbWCC+SgX6mzHHBrV0OMki8R+NnrNa NkUmMmosi7jBSKdoi9VqDqgQTJF/GftvmaZHqgmVJDWNrCv7UiorhesfIWPt1O/AIk9luxlE dHwkx5zkWa9CGYvV6LfP9BznendEoO3qYZ9IcUlW727Le80Q1oh69QnHoI8pODDBBTJvEq1h bOWcPm/DsNmDD8Rwr/msRmRyIoxjasFi5WkM/K/pzujICKeUcNGNsDsEDJC5TCmRO/TlvCvm 0X+vdfEJRZV6Z+QFBflK1asUz9QHFre5csG8MyVZkwTR9yUiKi3KiqQdaEu+LuDD2CGF5t68 xEl66Y6mwfyiISkkm3ETA4E8rVZP1rZQBBm83c5kJEDvs0A4zrhKIPTcI1smK+TWbyVyrZ/a mGYDrZzpF2N8DfuNSqOQkLHIOL3vuOyx3HPzS05lY3p+IIVmnPOEdZhMsNDIGmVorFyRWa4K uYjBP/W3E5p9e6TvDSDzqhLoY1RHfAIadM3I8kEx5wqco67VIgbIHHB9DbRcxQARAQABiQIf BBgBAgAJBQJTAdHHAhsMAAoJEFiDn/uYk8VJb7AQAK56tgX8V1Wa6RmZDmZ8dmBC7W8nsMRz PcKWiDSMIvTJT5bygMy1lf7gbHXm7fqezRtSfXAXr/OJqSA8LB2LWfThLyuuCvrdNsQNrI+3 D+hjHJjhW/4185y3EdmwwHcelixPg0X9EF+lHCltV/w29Pv3PiGDkoKxJrnOpnU6jrwiBebz eAYBfpSEvrCm4CR4hf+T6MdCs64UzZnNt0nxL8mLCCAGmq1iks9M4bZk+LG36QjCKGh8PDXz 9OsnJmCggptClgjTa7pO6040OW76pcVrP2rZrkjo/Ld/gvSc7yMO/m9sIYxLIsR2NDxMNpmE q/H7WO+2bRG0vMmsndxpEYS4WnuhKutoTA/goBEhtHu1fg5KC+WYXp9wZyTfeNPrL0L8F3N1 BCEYefp2JSZ/a355X6r2ROGSRgIIeYjAiSMgGAZMPEVsdvKsYw6BH17hDRzltNyIj5S0dIhb Gjynb3sXforM/GVbr4mnuxTdLXQYlj2EJ4O4f0tkLlADT7podzKSlSuZsLi2D+ohKxtP3U/r 42i8PBnX2oAV0UIkYk7Oel/3hr0+BP666SnTls9RJuoXc7R5XQVsomqXID6GmjwFQR5Wh/RE IJtkiDAsk37cfZ9d1kZ2gCQryTV9lmflSOB6AFZkOLuEVSC5qW8M/s6IGDfYXN12YJaZPptJ fiD/ Message-ID: <845e43b3-1c53-3eed-b540-4efa109f33a9@linux.intel.com> Date: Mon, 26 Oct 2020 16:23:47 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201019150202.19713-1-trix@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19.10.2020 18.02, trix@redhat.com wrote: > From: Tom Rix > > A break is not needed if it is preceded by a return or goto > > Signed-off-by: Tom Rix > --- > drivers/usb/gadget/function/f_hid.c | 9 --------- > drivers/usb/host/xhci-mem.c | 1 - > drivers/usb/misc/iowarrior.c | 3 --- > drivers/usb/serial/iuu_phoenix.c | 2 -- > drivers/usb/storage/freecom.c | 1 - > 5 files changed, 16 deletions(-) Would probably be better to split this into several patches. The xhci change looks good (as a separate patch) -Mathias