Received: by 2002:a05:6a10:9e8c:0:0:0:0 with SMTP id y12csp235842pxx; Mon, 26 Oct 2020 07:29:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzPXjQNMPbaCmkaH/A1u3GiLeKxAWlkuPJ9O4+D/86hDWPD5ypwDd/vDZfXhL9etQsuGFll X-Received: by 2002:a17:907:7083:: with SMTP id yj3mr16569339ejb.175.1603722590422; Mon, 26 Oct 2020 07:29:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1603722590; cv=none; d=google.com; s=arc-20160816; b=LSYRLEHndl+GzCsiddthH9oR5UZJEatMkFqMOP1Ax75ufmY50uDgFDGgdEJSwpI8QW PLkSdrya6hQuz8LFldN1uz032GPLmpoPeWmLquqnELZ/GofxkJCiUmRHKF0GxOdew546 9WuzlSbBN+ej6DijnfDxcg9SOLXNQ+Oa/GrI6G9QV9eLPv/KT6xtk7ihhatzofV2r4uY IMHNx0rXF+dBqqTN1LwVU5PE43BA8bp5+eDBKL25+DMct7pF4/6NP6lv/nlpAn+LtuoD uu4yS9RJVYFuGvgmt6ok+KCG8fk1N3Ke7YhRCpUsJ5AGsmq2hAt5WyRDmVXjj63EDYMt AelQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=BLuvvna6pWXp+uZmu5zfxCaWhMhHgO96bERXwEhDahE=; b=UkBs8U9OaO48QPRqg8xOXc6ZH3yioqWDdjfn33Xi3q0F3e6hTHX/g6ghZD6FpYGLCf /8ibzCvMaoV59Ud+cN4k5qh52AaiZhlZs2WzDt89sMrc56dShcjdY9cNnVp2Tgtbcbbh PfMK2P9Dbu/J83T3dsH0Cq4jAA4pElOCzu3fsxh57LVeHiTvLQGceUXFgge4pg6HJCDC glVX4boziRu2aKjzSHAUvIJiNOLoBWnaT5RCe9CeLjoHWGh6dh7o9YLF3pXWv+VWLJfK cSxsCy5ahE4WtzIEHLea1KNJgsmB8zbAxSissESD8iubXjTQUoYir9fwrS5XRa+u1kWj +TRQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=IwlSy2eH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o15si4442460edz.359.2020.10.26.07.29.26; Mon, 26 Oct 2020 07:29:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=IwlSy2eH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1781279AbgJZO1M (ORCPT + 99 others); Mon, 26 Oct 2020 10:27:12 -0400 Received: from mail-ej1-f65.google.com ([209.85.218.65]:36728 "EHLO mail-ej1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1780890AbgJZO1L (ORCPT ); Mon, 26 Oct 2020 10:27:11 -0400 Received: by mail-ej1-f65.google.com with SMTP id w27so13860536ejb.3 for ; Mon, 26 Oct 2020 07:27:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=BLuvvna6pWXp+uZmu5zfxCaWhMhHgO96bERXwEhDahE=; b=IwlSy2eHUnUydpxy2BD0ebebilvX57zYutDBchqKDHmNuUfP/DTe8nBSv0OBqTfjEn vG976ieXWuaW0jqkW1OprHGCeL2PcQ18DCxVDqSZ60sZtbt0LY0Uds1wJBeFoapKYPHY r5t1YYeRnLNfyUbF9x13MwN8vaw+HBb19OX7mr/knO9vkftgZAlOWlge04DCHV0odQrj cMLbanWCPFKortRGA2TiMpJcS6WMqVU2qwfLXeRDm/6nRxWdwrreYeMpdge309FFIZ00 A+jrY3vjrAuvW2MAzqt8PfcNu2OLV7wlQVSmRfBxrqLQgWUmHWtUdKD+Uwa3Z/ItyVJe 2WNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BLuvvna6pWXp+uZmu5zfxCaWhMhHgO96bERXwEhDahE=; b=e5DdvPOWsVTOVWeuHyBxI4o+S6YK4z2HChG36W4M+p0llyhWxH73Rnr6bbJfboVpR8 lXaGRx7X0GgRErh27juNk0UGyFG/UdJsTGOibvvVr6JXo971iEVw8aoGKpx7dlI29Hhf 8WbmcVI4U0/l+9jTbPmB6bOwlMpxKuzgDfheCvTkMc9Wz/ySE2WXtZcXoAtCXlfsf+DL JQsOZgqkdRVP/F7Y3ouoaJkCkvuvV3ryJeGPG/ynboBSNuDBr91tEeO66Y5fAbDQARwA BstIGwECh0bakUX4H5EwI4k2gopXGVBgDuWVevE2Xrv2PjoPp5Zh56fq+uCRCMYnJ/SM uwwQ== X-Gm-Message-State: AOAM530xrf1YtJAG3PFTVrxwUK2QY73xoty6vu4FEn28avJqTnKputNj KCQIW4EBd3ycyg9jXsImpvvUXyiWfp72nmyolqpd4Q== X-Received: by 2002:a17:906:d159:: with SMTP id br25mr16912973ejb.155.1603722430388; Mon, 26 Oct 2020 07:27:10 -0700 (PDT) MIME-Version: 1.0 References: <20201014062921.79112-1-warthog618@gmail.com> In-Reply-To: <20201014062921.79112-1-warthog618@gmail.com> From: Bartosz Golaszewski Date: Mon, 26 Oct 2020 15:26:59 +0100 Message-ID: Subject: Re: [PATCH v2] gpiolib: cdev: document that line eflags are shared To: Kent Gibson Cc: LKML , linux-gpio , Linus Walleij Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 14, 2020 at 8:29 AM Kent Gibson wrote: > > The line.eflags field is shared so document this fact and highlight it > throughout using READ_ONCE() and WRITE_ONCE() accessors. > > Also use a local copy of the eflags in edge_irq_thread() to ensure > consistent control flow even if eflags changes. This is only a defensive > measure as edge_irq_thread() is currently disabled when the eflags are > changed. > > Signed-off-by: Kent Gibson > --- > Patch applied, thanks! Bartosz