Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <DB4481A8-FD4E-4879-9CD2-275ABAFC09CF@fb.com> <CAKfTPtBiOFXwV9SkZ=YBw16xoS6LSrKVR4sFX6r2hZPZ9_5-+A@mail.gmail.com>
 <0014CA62-A632-495A-92B0-4B14C8CA193C@fb.com> <20201026142455.GA13495@vingu-book>
 <465597a2250d69346cff73dd07817794d3e80244.camel@surriel.com>
In-Reply-To: <465597a2250d69346cff73dd07817794d3e80244.camel@surriel.com>
From:   Vincent Guittot <vincent.guittot@linaro.org>
Date:   Mon, 26 Oct 2020 15:56:58 +0100
Message-ID: <CAKfTPtCVzass7GM5oj3o3y0ru4HQViWZc2+D-RpFoLvg=__FrA@mail.gmail.com>
Subject: Re: [PATCH] fix scheduler regression from "sched/fair: Rework load_balance()"
To:     Rik van Riel <riel@surriel.com>
Cc:     Chris Mason <clm@fb.com>, Peter Zijlstra <peterz@infradead.org>,
        Johannes Weiner <hannes@cmpxchg.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, 26 Oct 2020 at 15:38, Rik van Riel <riel@surriel.com> wrote:
>
> On Mon, 2020-10-26 at 15:24 +0100, Vincent Guittot wrote:
> > Le lundi 26 oct. 2020 =C3=A0 08:45:27 (-0400), Chris Mason a =C3=A9crit=
 :
> > > On 26 Oct 2020, at 4:39, Vincent Guittot wrote:
> > >
> > > > Hi Chris
> > > >
> > > > On Sat, 24 Oct 2020 at 01:49, Chris Mason <clm@fb.com> wrote:
> > > > > Hi everyone,
> > > > >
> > > > > We=E2=80=99re validating a new kernel in the fleet, and compared =
with
> > > > > v5.2,
> > > >
> > > > Which version are you using ?
> > > > several improvements have been added since v5.5 and the rework of
> > > > load_balance
> > >
> > > We=E2=80=99re validating v5.6, but all of the numbers referenced in t=
his
> > > patch are
> > > against v5.9.  I usually try to back port my way to victory on this
> > > kind of
> > > thing, but mainline seems to behave exactly the same as
> > > 0b0695f2b34a wrt
> > > this benchmark.
> >
> > ok. Thanks for the confirmation
> >
> > I have been able to reproduce the problem on my setup.
> >
> > Could you try the fix below ?
> >
> > --- a/kernel/sched/fair.c
> > +++ b/kernel/sched/fair.c
> > @@ -9049,7 +9049,8 @@ static inline void calculate_imbalance(struct
> > lb_env *env, struct sd_lb_stats *s
> >          * emptying busiest.
> >          */
> >         if (local->group_type =3D=3D group_has_spare) {
> > -               if (busiest->group_type > group_fully_busy) {
> > +               if ((busiest->group_type > group_fully_busy) &&
> > +                   (busiest->group_weight > 1)) {
> >                         /*
> >                          * If busiest is overloaded, try to fill
> > spare
> >                          * capacity. This might end up creating spare
> > capacity
> >
> >
> > When we calculate an imbalance at te smallest level, ie between CPUs
> > (group_weight =3D=3D 1),
> > we should try to spread tasks on cpus instead of trying to fill spare
> > capacity.
>
> Should we also spread tasks when balancing between
> multi-threaded CPU cores on the same socket?

My explanation is probably misleading. In fact we already try to
spread tasks. we just use spare capacity instead of nr_running when
there is more than 1 CPU in the group and the group is overloaded.
Using spare capacity is a bit more conservative because it tries to
not pull more utilization than spare capacity

>
> Say we have groups of CPUs
> (0, 2) and CPUs (1, 3),
> with CPU 2 idle, and 3 tasks spread between CPUs
> 1 & 3.
>
> Since they are all on the same LLC, and the task
> wakeup code has absolutely no hesitation in moving
> them around, should the load balancer also try to
> keep tasks within a socket spread across all CPUs?
>
> --
> All Rights Reversed.