Received: by 2002:a05:6a10:9e8c:0:0:0:0 with SMTP id y12csp411941pxx; Mon, 26 Oct 2020 11:17:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwpzRxqNVJ/Ys/fRjl2jbxVj8aX5saI4mbuVKQIq3jN0AM/q3yBxeBcGzBl0MPp+5+L4M2L X-Received: by 2002:aa7:d783:: with SMTP id s3mr17307000edq.214.1603736265516; Mon, 26 Oct 2020 11:17:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1603736265; cv=none; d=google.com; s=arc-20160816; b=qEcyeOfNUEg2CONTCNNgMY99b/G1LZncm8UUseWNdrQ4yPy288755BBqLq+n8VSF83 MPwZj0k4iWcRx4ZEyu0AG5Ix+9CXk4GMnP9EVDP+mgGQAIsQpfonTGVgzEMEEOujZ5Rd aXNJDbsEBVVRqpw9y5XjwsYlVWuP/uEfH1T1Rrv0NXK5Qbx7qA+130pIH59NpA5esb0a nsx19YCMwqFz3RHGbPTWVcLdR/pT4nKiAooEYuL0fA7AmaCKY9UyoB4iAMj9HK01OQjk 40eKafpNPBxz9oneKLZZoydLWnOsnpGvfia1Vw9jMVTR1koY9ihQLKjWTstRyVROWjJA UW5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :ironport-sdr:ironport-sdr; bh=DnAgfPw4QafrIPgW4QzXtcQmL7+BZuxFAjUEld44Dwk=; b=Po8HSlUn3SFfcl6cga2+gbG7HCvosTFI2IP1Fqc4dVRwMHKrRqmmTOjBYDu1ELqCh/ goBf6fsYLPxOFZA2ltVN9kbtcSZoqOqILiChTWty9sf6zGmj615JiOtKhzTehxBaACLg JGzpCQyIx/uSGKNUofy/quix8yg8FOJm1CIPKXtdhDFg0QTTzFWT96mhqR6CU7+kA/lu GZX+KkIBGPG3s1P3uRMzNtDI+prttRn0OiXrFv3Ud2r4TlfwTkwxRqo7OdqCMleX1RFe xiEA+IYY3zsXxQo52PdX5TMX1kkITsnVFA60aUeKokD1sZL1KbzpREoH30BeU3nSUrw+ wdJA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bm17si7484707edb.140.2020.10.26.11.17.23; Mon, 26 Oct 2020 11:17:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1783903AbgJZPby (ORCPT + 99 others); Mon, 26 Oct 2020 11:31:54 -0400 Received: from mga17.intel.com ([192.55.52.151]:64147 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1783897AbgJZPbx (ORCPT ); Mon, 26 Oct 2020 11:31:53 -0400 IronPort-SDR: yUGGHUg4V7QcFIae2F79HRr1yj3L/9m8/QB2hjvBNsVk+9KG/XLXdPkkWgim/qbcl3gSvfHsiO CTAJgRWwoQIA== X-IronPort-AV: E=McAfee;i="6000,8403,9785"; a="147795145" X-IronPort-AV: E=Sophos;i="5.77,420,1596524400"; d="scan'208";a="147795145" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Oct 2020 08:31:51 -0700 IronPort-SDR: 5rYE6EcBTdOMe+GccR8gvcxNgSZQUIIpQhXQpDOeRZUPsakbGqXgUah8u6BhLjPnMET5B1u/JU ++286BiylgqQ== X-IronPort-AV: E=Sophos;i="5.77,420,1596524400"; d="scan'208";a="350152841" Received: from lahna.fi.intel.com (HELO lahna) ([10.237.72.163]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Oct 2020 08:31:48 -0700 Received: by lahna (sSMTP sendmail emulation); Mon, 26 Oct 2020 17:31:45 +0200 Date: Mon, 26 Oct 2020 17:31:45 +0200 From: Mika Westerberg To: Jing Xiangfeng Cc: andreas.noever@gmail.com, michael.jamet@intel.com, YehezkelShB@gmail.com, andriy.shevchenko@linux.intel.com, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] thunderbolt: Add the missed ida_simple_remove() in ring_request_msix() Message-ID: <20201026153145.GE2495@lahna.fi.intel.com> References: <20201015084053.56158-1-jingxiangfeng@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201015084053.56158-1-jingxiangfeng@huawei.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 15, 2020 at 04:40:53PM +0800, Jing Xiangfeng wrote: > ring_request_msix() misses to call ida_simple_remove() in an error path. > Add a label 'err_ida_remove' and jump to it. > > Fixes: 046bee1f9ab8 ("thunderbolt: Add MSI-X support") > Signed-off-by: Jing Xiangfeng Applied to thunderbolt.git/fixes, thanks!