Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Coiby Xu <coiby.xu@gmail.com>
Date:   Mon, 26 Oct 2020 23:16:42 +0800
To:     Andy Shevchenko <andy.shevchenko@gmail.com>
Cc:     "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        Hans de Goede <hdegoede@redhat.com>,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] pinctrl: amd: print debounce filter info in debugfs
Message-ID: <20201026151642.r5uqfgiptvk4wrjv@Rk>
References: <20201024061552.4497-1-coiby.xu@gmail.com>
 <CAHp75VdRBPcdRaTjnDNk5nSN8fMY--Gq=042+fYGddv=Xs6uHw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <CAHp75VdRBPcdRaTjnDNk5nSN8fMY--Gq=042+fYGddv=Xs6uHw@mail.gmail.com>
Precedence: bulk

On Sun, Oct 25, 2020 at 07:12:16PM +0200, Andy Shevchenko wrote:
>On Sat, Oct 24, 2020 at 2:32 PM Coiby Xu <coiby.xu@gmail.com> wrote:
>>
>> Print out the status of debounce filter as follows,
>> $ cat /sys/kernel/debug/gpio|grep pin130
>> pin130          interrupt is disabled| interrupt is masked| disable wakeup in S0i3 state| disable wakeup in S3 state|
>>  disable wakeup in S4/S5 state| input is high|   pull-up is disabled| Pull-down is disabled|   output is disabled| debouncing filter (high) enabled| debouncing timeout is 124800 (us)| 0x503c8
>
>
>> +                               if (!tmr_large) {
>> +                                       if (!tmr_out_unit)
>> +                                               unit = 61;
>> +                                       else
>> +                                               unit = 244;
>> +                               } else {
>> +                                       if (!tmr_out_unit)
>> +                                               unit = 15600;
>> +                                       else
>> +                                               unit = 62500;
>> +                               }
>
>In all three if:s can you use positive conditionals?
>
Thank you for the suggestion! I've reversed the order of debounce
timeout in v2.

>--
>With Best Regards,
>Andy Shevchenko

--
Best regards,
Coiby