Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: srivasam=codeaurora.org@mg.codeaurora.org
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org E802BC433FF
Subject: Re: [PATCH] Asoc: qcom: lpass-sc7180: Fix MI2S bitwidth field bit
 positions
To:     Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
        agross@kernel.org, bjorn.andersson@linaro.org, lgirdwood@gmail.com,
        broonie@kernel.org, robh+dt@kernel.org, plai@codeaurora.org,
        bgoswami@codeaurora.org, perex@perex.cz, tiwai@suse.com,
        rohitkr@codeaurora.org, linux-arm-msm@vger.kernel.org,
        alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     V Sujith Kumar Reddy <vsujithk@codeaurora.org>
References: <1603373219-19374-1-git-send-email-srivasam@codeaurora.org>
 <335f1d55-8a85-8501-fd69-0397f44e21af@linaro.org>
From:   Srinivasa Rao Mandadapu <srivasam@codeaurora.org>
Organization: Qualcomm India Private Limited.
Message-ID: <242284b2-ca3f-fbe0-af97-c0e8e5fe640d@codeaurora.org>
Date:   Mon, 26 Oct 2020 21:34:32 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.4.0
MIME-Version: 1.0
In-Reply-To: <335f1d55-8a85-8501-fd69-0397f44e21af@linaro.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Precedence: bulk

Thanks for your time srinivas!!!

On 10/26/2020 8:31 PM, Srinivas Kandagatla wrote:
>
>
> On 22/10/2020 14:26, Srinivasa Rao Mandadapu wrote:
>> From: V Sujith Kumar Reddy <vsujithk@codeaurora.org>
>>
>> Update SC7180 lpass_variant structure with proper I2S bitwidth
>> field bit positions, as bitwidth denotes 0 to 1 bits,
>> but previously used only 0 bit.
>>
>> Fixes: commit cba62c8b49bead ("Merge series "ASoC: qcom: Add support 
>> for SC7180 lpass variant" from Rohit kumar <rohitkr@codeaurora.org>:")
> this should be 12 chars long, for this particular fix it should be!
>
> Fixes: 24caf8d9eb108 ("ASoC: qcom: lpass-sc7180: Add platform driver 
> for lpass audio")
>>
>
> No empty line after Fixes tag!
>
> Will coorect it in next patch.

>> Signed-off-by: V Sujith Kumar Reddy <vsujithk@codeaurora.org>
>> Signed-off-by: Srinivasa Rao Mandadapu <srivasam@codeaurora.org>
>> ---
>>   sound/soc/qcom/lpass-sc7180.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/sound/soc/qcom/lpass-sc7180.c 
>> b/sound/soc/qcom/lpass-sc7180.c
>> index c6292f9e..bc998d5 100644
>> --- a/sound/soc/qcom/lpass-sc7180.c
>> +++ b/sound/soc/qcom/lpass-sc7180.c
>> @@ -188,7 +188,7 @@ static struct lpass_variant sc7180_data = {
>>       .micmode        = REG_FIELD_ID(0x1000, 4, 8, 3, 0x1000),
>>       .micmono        = REG_FIELD_ID(0x1000, 3, 3, 3, 0x1000),
>>       .wssrc            = REG_FIELD_ID(0x1000, 2, 2, 3, 0x1000),
>> -    .bitwidth        = REG_FIELD_ID(0x1000, 0, 0, 3, 0x1000),
>> +    .bitwidth        = REG_FIELD_ID(0x1000, 0, 1, 3, 0x1000),
>>         .rdma_dyncclk        = REG_FIELD_ID(0xC000, 21, 21, 5, 0x1000),
>>       .rdma_bursten        = REG_FIELD_ID(0xC000, 20, 20, 5, 0x1000),
>>
> --srini

-- 
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.,
is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.