Received: by 2002:a05:6a10:9e8c:0:0:0:0 with SMTP id y12csp612082pxx; Mon, 26 Oct 2020 16:53:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwzW7uQGIAMajjH8wcP/AHXZc6kfTS9cT0HDM+CQMGULtoREVnkI8hJp00wDYrKU9HLjafN X-Received: by 2002:a17:906:a981:: with SMTP id jr1mr17478963ejb.99.1603756388472; Mon, 26 Oct 2020 16:53:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1603756388; cv=none; d=google.com; s=arc-20160816; b=NaOLOjfoqlwaBjzbc+KhGyQ6anVLwBG0RInNcFbokKTCP5j2tVWYvZI6kVFxtEzWFH OHRkamqwFSxxEzS3lbam4DXGIwPpUUP0NhlalNTjvnZVM63Dh1vbGf1wNUd0dFfJfhuJ linwkOl1Box/YsYFOFQYz7j7amfvp+9fAV1cxIk6JhCxQPMXxi3BZ7UbW0UiAFqUvOUq ay+7NxQf0QNxY6TN8e9n0xp0Yz4qQ1HZpIC9giGQIsvjalBMzDlOr1JKsBpqf0Qg4imT n0R1Mc9mlWZf2a5jY4CVbbWVRLiceQpiK8Xsx35/A0w69UqnTPvU0M1dbj8AzYW7qKs5 NgcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=x/jM2p70QXHiI9fxuts7743UHXpXU1hV7uUhKROQCrA=; b=YOfTozJZkkmhvdXkKVFv5tf201OIwx/bcv5s9q9VkqV1cV29vuJP6LsQGPJ+mPoZGu 4kHoH7/ZZBX+II3hX3kCdk7AjPkrZX4aR2+JfSsyrOEwk3TfmXc/3U4I8lvDDWM6VmKC 9P66f96YSAsL333CnoKW8rPMRMxDCYFYN/0PQJUPniWnyRQ4vPREj+JNlP+MU4eyByPY tbGVElf+t8WXoVqHlK5oPyNcKXOAfBXXtjwYk/BJm4Wbr8uKvcQ/y9Wt6ay1LU2JCdj8 c89RjMwuF1/d0a2IvxhBmOgcEjqmY1Ie6RotFKXb2L8y4B+WW8+v0hNaK2xNJxd+yeUi RX3A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=JckPPeS6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v27si7645419edx.414.2020.10.26.16.52.46; Mon, 26 Oct 2020 16:53:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=JckPPeS6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1790475AbgJZSwj (ORCPT + 99 others); Mon, 26 Oct 2020 14:52:39 -0400 Received: from mail.kernel.org ([198.145.29.99]:42836 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1790466AbgJZSwj (ORCPT ); Mon, 26 Oct 2020 14:52:39 -0400 Received: from kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net (unknown [163.114.132.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A1FB9207E8; Mon, 26 Oct 2020 18:52:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603738359; bh=t2EQbcyl5c3xdLTzNkFpT08fzGpuuYyPqlb0/xDd3r4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=JckPPeS6Q4j3QYgNH76zNGhEI+P2JRsz0T+do+ZJ0jXBaGM/h3iWH2jzj+1PmQ4yh qsl/JLRqufoBVgCw8TWFwiDAnMyBF0gzRXIKT8uv0Gm8e5QCTQZuBT9ARs90+bIeoM jA3gBYtw+K4gukXB97CGMg0jaj6i8HzU5aol5USc= Date: Mon, 26 Oct 2020 11:52:37 -0700 From: Jakub Kicinski To: Michal Suchanek Cc: Thomas Bogendoerfer , netdev@vger.kernel.org, Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Cristobal Forno , "David S. Miller" , Cris Forno , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ibmveth: Fix use of ibmveth in a bridge. Message-ID: <20201026115237.21b114fe@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> In-Reply-To: <20201026104221.26570-1-msuchanek@suse.de> References: <20201026104221.26570-1-msuchanek@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 26 Oct 2020 11:42:21 +0100 Michal Suchanek wrote: > From: Thomas Bogendoerfer > > The check for src mac address in ibmveth_is_packet_unsupported is wrong. > Commit 6f2275433a2f wanted to shut down messages for loopback packets, > but now suppresses bridged frames, which are accepted by the hypervisor > otherwise bridging won't work at all. > > Fixes: 6f2275433a2f ("ibmveth: Detect unsupported packets before sending to the hypervisor") > Signed-off-by: Michal Suchanek Since the From: line says Thomas we need a signoff from him.