Received: by 2002:a05:6a10:9e8c:0:0:0:0 with SMTP id y12csp612772pxx; Mon, 26 Oct 2020 16:54:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzu8eDHXljbqx23mNsN9ZvXwFar6ygDbeZJGsNyGhE0rZLY8j8Iwl182IHGMKvqqkOzMgQa X-Received: by 2002:a17:906:2dc7:: with SMTP id h7mr18190716eji.546.1603756489813; Mon, 26 Oct 2020 16:54:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1603756489; cv=none; d=google.com; s=arc-20160816; b=gONdlsSHsPHc5aWcBcgHtUSQikzEpJYqiQv6RlLGPObLr5vDLEPb0I/5Y+orUN4yu7 58D8dTMWv6UAMy4J/eHUluxXUu/y5NL0XXVMsav7mcMKW8HtGIiV2DGttKwD7S2g9aLg h3aUbPh21uTAS2tVIswgvPYVfFjiY9MweWxSj87O9EvXwyMQzDBqQaLgaODGoHO4N3i7 R4vKAuU5elGUcNH1bFjl/sUV+WcDgFVrkiy7FtP9/MtA7RBdfXZg5ROWsvRoJpphtDMi tatbflecFSvgOWGM1kQe/Va55EidiEZBThFeH5XQOpumkWGtUlIsMQW5iDIGlbXnMbXR Ttmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:references:in-reply-to :message-id:date:subject:cc:to:from:ironport-sdr:ironport-sdr; bh=hYz3i09bYgde1rM0vRaT4FyzhxaWTWU/cqJ37aNXCfU=; b=UEDBagZji8+Gh1pcmw8G38fRu1r26A05geUQqiUojbsyoxBs16BsugELkEeXSJhc/K +Mg9bnbrmN2CTUvuUWnwx1eDpqOa5mEVVNAmLm7M0nh1hvIJW+GNDNudQF9UHW+tTEZd 9/UTjC3P3FnNT76NYHqTULtjj571gFdmNMDZHIKAiT8BigebVsgQNQJyMvzgAQqRHu1G aZeFWt4Hhz8aI4rsAOl7uPXr1FObiqp0er5ajw0zrupWEeEe1whUClToXYHoj/mWLh1Y Z6egEaUqEwwfNyeLgc+J9nltnGaR/VwEdLUUBL8lyLY89qKA4eBUka9RtK7zn4COdh1V 4TRw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ck9si8197478ejb.445.2020.10.26.16.54.27; Mon, 26 Oct 2020 16:54:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1791064AbgJZS6Q (ORCPT + 99 others); Mon, 26 Oct 2020 14:58:16 -0400 Received: from mga03.intel.com ([134.134.136.65]:52492 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1791039AbgJZS6J (ORCPT ); Mon, 26 Oct 2020 14:58:09 -0400 IronPort-SDR: 4H4bbXMAyMu2jdyOxfh/Lr0p+xoGNj4ItFHl+B+pUIY1tMmVTZpkA8zKG5Ga3G+2fGshYaOtRZ 76/xwc7lpeLQ== X-IronPort-AV: E=McAfee;i="6000,8403,9786"; a="168073148" X-IronPort-AV: E=Sophos;i="5.77,420,1596524400"; d="scan'208";a="168073148" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Oct 2020 11:58:07 -0700 IronPort-SDR: ZxGJ7nXIwwtu8Ac4Rg28Jx88yhF3qFt7Wh3WbAzEwYpsNXiduhBDgXaoDBUS/WvB8qONgTVv2D Ia1KwPVcCBJA== X-IronPort-AV: E=Sophos;i="5.77,420,1596524400"; d="scan'208";a="525607463" Received: from dhrubajy-mobl.amr.corp.intel.com (HELO skuppusw-mobl5.amr.corp.intel.com) ([10.254.101.53]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Oct 2020 11:58:07 -0700 From: Kuppuswamy Sathyanarayanan To: bhelgaas@google.com Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, ashok.raj@intel.com, sathyanarayanan.kuppuswamy@linux.intel.com, knsathya@kernel.org Subject: [PATCH v10 4/5] PCI/portdrv: Remove redundant pci_aer_available() check in DPC enable logic Date: Mon, 26 Oct 2020 11:56:42 -0700 Message-Id: X-Mailer: git-send-email 2.17.1 In-Reply-To: References: In-Reply-To: References: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In DPC service enable logic, check for services & PCIE_PORT_SERVICE_AER implies pci_aer_available() is true. So there is no need to explicitly check it again. Also, passing pcie_ports=dpc-native in kernel command line implies DPC needs to be enabled in native mode irrespective of AER ownership status. So checking for pci_aer_available() without checking for pcie_ports status is incorrect. Signed-off-by: Kuppuswamy Sathyanarayanan --- drivers/pci/pcie/portdrv_core.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/pci/pcie/portdrv_core.c b/drivers/pci/pcie/portdrv_core.c index 2c0278f0fdcc..e257a2ca3595 100644 --- a/drivers/pci/pcie/portdrv_core.c +++ b/drivers/pci/pcie/portdrv_core.c @@ -252,7 +252,6 @@ static int get_port_device_capability(struct pci_dev *dev) * permission to use AER. */ if (pci_find_ext_capability(dev, PCI_EXT_CAP_ID_DPC) && - pci_aer_available() && (host->native_dpc || (services & PCIE_PORT_SERVICE_AER))) services |= PCIE_PORT_SERVICE_DPC; -- 2.17.1