Received: by 2002:a05:6a10:9e8c:0:0:0:0 with SMTP id y12csp617663pxx; Mon, 26 Oct 2020 17:03:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwrXMGQJIqguod0Gt/qoSUBqM4WLNsezT/Tsn7HE5dmhc5+HRgqEHRmVmxA1jBckkg2x0vg X-Received: by 2002:a17:906:1158:: with SMTP id i24mr17643774eja.304.1603757036886; Mon, 26 Oct 2020 17:03:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1603757036; cv=none; d=google.com; s=arc-20160816; b=vIt7nLeF7OcGhOyDjA4WM3Gi8gh4yHhJxSjqbOz2CM5V8zYXNiMmyUoBC2K5/ru/4d 5Addc06ui+Aw4d/b7Pp5WRArid0HwK1j72IbhQrwd5M6oHS81u3YZwT8ZvdjhCHcxmss CgbuD2rrlWhDAxzKKvIdVHwqD8rwuGfUkC1fcBK0AKlAjNarIzJHqFPt+HRyUkFhwKpN JxacZ3cSiCxk5Y/lEcz90N7wHBQ2Up2oQ3v/sBuM6k7T/1dXFTnfFcJl8S27C9zG46+W fVXNGVFjniczFYZIcEuRyCIxOfehXtwcQLzuo0KzXC0TRya2tmoQiQb36Usw9c5sVMPj GjKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=x4YhuX0iisDgAsM+KB7XaZtDcwmduQRIETDyGHldEjU=; b=de0GwcYb7SYrXGXIVtEbF+x53auWeRlamEQrOUBgOugD7+cEVqRjEd9D87dGn2rO7t 4uuERac9vKuzmJPqfcrWHiZ0E78wbJEAjJtu9HSQ4jVLbDXpt9VSvo6Km3OivBIkxSEe LidIjHj3yWVooBoaHJ4aPlCjisbwqbV/pQ8gJCF6OFyYe+FdZm+3WYRoISPIe3VbKIIS rdQWEDlwd8DdETmlLWiRiCQvD9yhn7gUQE0HlE5TStIzuk/Qdv/fQnvGRLf3SsMfu3JT f/vb+/N3yINXTwNv7fBMHFYinM29xggb8hVZpd1rgi1wZnXgbgIKhg+BEkkiO8/rK18s 7NGw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=dhlcFomi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k9si7577574edf.377.2020.10.26.17.03.35; Mon, 26 Oct 2020 17:03:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=dhlcFomi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729483AbgJZVDQ (ORCPT + 99 others); Mon, 26 Oct 2020 17:03:16 -0400 Received: from mail-ej1-f66.google.com ([209.85.218.66]:42764 "EHLO mail-ej1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729469AbgJZVDQ (ORCPT ); Mon, 26 Oct 2020 17:03:16 -0400 Received: by mail-ej1-f66.google.com with SMTP id h24so15786240ejg.9; Mon, 26 Oct 2020 14:03:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=x4YhuX0iisDgAsM+KB7XaZtDcwmduQRIETDyGHldEjU=; b=dhlcFomiQe2Cw+akZarQWRYDr++5ZEb89CcZI+NOfo9R/UWp964KuYA+8RGOwjPXQ9 XjqnGpUZDh7cJmgXkxuZ5mQyO3k18jU5mu93Bjl6PbP9JFla//6UGE3cbdZY8ACGUpmC l3D4FUgNQhrpgoCeB4exyZ+DisL+nrL1ea6kGVzgT6HGdkjHRklgtw6QknDRzXhM4CoE eLLj4uVgqMY6TLkuM0RhaMfmE9i7Hfnd5y06ONZJJPj8867XQpq146Px/oVP5WGMqH5r cz92pkwrklXUvWXMOFRqAF2UMK4ia2N9gyokvflA4rIBkman4Ygi4xlykgzyt+XNT4fY cJ+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=x4YhuX0iisDgAsM+KB7XaZtDcwmduQRIETDyGHldEjU=; b=uL9Trj+KuvHk58KDhNb8D95Y0lxVF5SkqE0KHGmOeQlX7NI4YAebE2FLm7lZvS8xs3 Ptn66KWryEuPORwPEGiDmJIwm6zzP/cjek+miYEYIQkwd6xVBEOLKFr6y13AQKXNa7Qi DgQWdff7EaMgH7MjnypbXSTqkdMTlZJDTqnGenuRrXPI5yIjlF5enf0QGfbmUvYGBDvY SAqJgu+/nRv5r258Bk5W3ArNa2Fiv+tal+oiA7fQ0PrVrFt5S1TBOGNB2SMGXXlNKgR6 +C6k0/VEmE+MnatQjIYOaMh4mP1A4EzwPByLc1RHAThjGvle4PioT8HkdoRy6V6+6xDv farw== X-Gm-Message-State: AOAM533ATSSTkdPhUicQzujtWeI5F9LKZOadewOoBtviOEv62uAhy31b E3BWQ3KFllT3Y2BSYtXrosk= X-Received: by 2002:a17:906:3e91:: with SMTP id a17mr17421048ejj.82.1603746194313; Mon, 26 Oct 2020 14:03:14 -0700 (PDT) Received: from ltop.local ([2a02:a03f:b7fe:f700:19a8:8f98:6135:ae35]) by smtp.gmail.com with ESMTPSA id a1sm5862160edk.52.2020.10.26.14.03.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Oct 2020 14:03:13 -0700 (PDT) Date: Mon, 26 Oct 2020 22:03:12 +0100 From: Luc Van Oostenryck To: Arnd Bergmann Cc: Arnd Bergmann , Dennis Zhou , Christoph Lameter , linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] asm-generic: percpu: avoid Wshadow warning Message-ID: <20201026210312.byq3mdo4e2ei6ee2@ltop.local> References: <20201026155353.3702892-1-arnd@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201026155353.3702892-1-arnd@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 26, 2020 at 04:53:48PM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > Nesting macros that use the same local variable names causes > warnings when building with "make W=2": > > include/asm-generic/percpu.h:117:14: warning: declaration of '__ret' shadows a previous local [-Wshadow] > include/asm-generic/percpu.h:126:14: warning: declaration of '__ret' shadows a previous local [-Wshadow] > > These are fairly harmless, but since the warning comes from > a global header, the warning happens every time the headers > are included, which is fairly annoying. > > Rename the variables to avoid shadowing and shut up the warning. Looks good to me. Fell free to add my: Reviewed-by: Luc Van Oostenryck