Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201026155730.542020-1-tasleson@redhat.com>
In-Reply-To: <20201026155730.542020-1-tasleson@redhat.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Tue, 27 Oct 2020 00:07:09 +0200
Message-ID: <CAHp75Vfno9LULSfvwYA+4bEz4kW1Z7c=65HTy-O0fgLrzVA24g@mail.gmail.com>
Subject: Re: [PATCH] buffer_io_error: Use dev_err_ratelimited
To:     Tony Asleson <tasleson@redhat.com>
Cc:     Alexander Viro <viro@zeniv.linux.org.uk>,
        Linux FS Devel <linux-fsdevel@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Oct 26, 2020 at 10:59 PM Tony Asleson <tasleson@redhat.com> wrote:
>
> Replace printk_ratelimited with dev_err_ratelimited which
> adds dev_printk meta data. This is used by journald to
> add disk ID information to the journal entry.


> This re-worked change is from a different patch series
> and utilizes the following suggestions.
>
> - Reduce indentation level (Andy Shevchenko)
> - Remove unneeded () for conditional operator (Sergei Shtylyov)

This should go as a changelog after the cutter '---' line...

> Signed-off-by: Tony Asleson <tasleson@redhat.com>
> ---

...somewhere here.

...

> -       if (!test_bit(BH_Quiet, &bh->b_state))
> -               printk_ratelimited(KERN_ERR
> -                       "Buffer I/O error on dev %pg, logical block %llu%s\n",
> -                       bh->b_bdev, (unsigned long long)bh->b_blocknr, msg);
> +       struct device *gendev;
> +
> +       if (test_bit(BH_Quiet, &bh->b_state))
> +               return;
> +

> +       gendev = bh->b_bdev->bd_disk ?
> +               disk_to_dev(bh->b_bdev->bd_disk) : NULL;

I'm not sure it's a good idea to print '(null)'.

Perhaps

if (bh->b_bdev->bd_disk)
  dev_err_ratelimit(disk_to_dev(bh->b_bdev->bd_disk), ...);
else
  pr_err_ratelimit(...);

?

> +       dev_err_ratelimited(gendev,
> +               "Buffer I/O error, logical block %llu%s\n",

> +               (unsigned long long)bh->b_blocknr, msg);

It's a u64 always (via sector_t), do we really need a casting?

>  }

-- 
With Best Regards,
Andy Shevchenko