Received: by 2002:a05:6a10:9e8c:0:0:0:0 with SMTP id y12csp794179pxx; Mon, 26 Oct 2020 23:56:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxWB6DfVKl6sgPD0yErX561wtl6NW5aaLFJGR3Edl9nTNUJHi6tUhLmTsyuIs+31n88NTnB X-Received: by 2002:aa7:d394:: with SMTP id x20mr740516edq.14.1603781774227; Mon, 26 Oct 2020 23:56:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1603781774; cv=none; d=google.com; s=arc-20160816; b=rbSn/QqNrvnF1kN/KFVjqm6HevJwtCMp8EsiNUSolR32dhnFaQrzymVoMb09PGPuSL t6MondvruvyO8D+MLuiODQiqTeUcHEU+o7Ai8ebQ+F75qZKxF3Ni6pXZKwsSFo2Vs8yC Ve4+OhNk4/EDOH+7pJ5CdZ1f2IR6airvKCImrooOar44NJruv7JuFH84RUpwZXhzlVvm 6PfokTbMIskX08NkFs611Fex/VlA42jhJ5lJk/d7InMHXEsKNZTvNCwl1LP05g0PjXAr UgOTPUbA/NwcAmh1Y5dHC1X1Ez3QYRLtYWWGWOUmV3FPSdb0WoPKYUPnlkszyvTUQkMc TboA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=8KLUIb8OS6YSmjZyYN9hokEpdgO30AV/TW7YIz+gh0w=; b=Qcz3Ud9fT9mWnaSEM1+FkQjLRa/81WoPEeg0aJTqH8ZUCokalgEwfFbacmBgY8y4Ak +ho8MBZvojQ3MYDHsBqeRfMRqn7+9X/KNq5aLyXAGnI90K+Wn5cqbyM96tdCu3nADN6L Yzdrn28v8qAVSYR8Pleg6zcFP3oRZxTNzss8vAH0t8MFWGwekBfShif3IqKEpXqw0V2D ICmcM8CAURosgqr+aupOuPO8KPZFAr/J6LXRWQp8hTxikecgGAdD7DWb73mSJh4R3HPy cdVHmdWgKOS/G1kVf7Juf2DEOjZGmfABhgmO6qS67SnGlv6Pi+mWLjwj/g09T8NpsqB8 k0rw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h1si345109ejx.541.2020.10.26.23.55.52; Mon, 26 Oct 2020 23:56:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728999AbgJZUOw (ORCPT + 99 others); Mon, 26 Oct 2020 16:14:52 -0400 Received: from mail-ed1-f68.google.com ([209.85.208.68]:33399 "EHLO mail-ed1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726694AbgJZUOw (ORCPT ); Mon, 26 Oct 2020 16:14:52 -0400 Received: by mail-ed1-f68.google.com with SMTP id w23so10886226edl.0; Mon, 26 Oct 2020 13:14:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=8KLUIb8OS6YSmjZyYN9hokEpdgO30AV/TW7YIz+gh0w=; b=NkFpjhJITAgp2TIk2nqBl3IOPc/V3uhB3BNZkII+eV0O+K2MVmzcFjE2UzbzWfJYsU o+7XhpVuNiKPxPp+rQwZa0eZy6TN3JnciqRXQ52nYUH4JKYlx0T1wA1lP8YGXabr5kAh 94l0uXuerB3H7bqLJVrCnA+jhwghxEDwpfvBI8rmi6y1hk3APcfmn8MVhC5/oM8GjJfY lnLAxzMh/yPJ2mRKjjMP/BHPrm/8IZNoFsS/H7FoWu7spSU+SYL0NYObJ5yjqBALYqCc fzfyfoOIAUixMOJde52i56dpiSDZQIk7l6eGHyKumyKRQnNZyKsu9L5dbj7dKg4hPxrB yvUg== X-Gm-Message-State: AOAM530gqqdpKsG5ZA56f7ca5He60Zoyc53reKuusVpKIYS9Wcefogea 1g8P47sXe9dIqOpI2aL0gwQHXZivynrUlw== X-Received: by 2002:aa7:de97:: with SMTP id j23mr17739492edv.45.1603743289955; Mon, 26 Oct 2020 13:14:49 -0700 (PDT) Received: from kozik-lap ([194.230.155.184]) by smtp.googlemail.com with ESMTPSA id k23sm6593061ejk.0.2020.10.26.13.14.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Oct 2020 13:14:48 -0700 (PDT) Date: Mon, 26 Oct 2020 21:14:46 +0100 From: Krzysztof Kozlowski To: Nicolin Chen Cc: thierry.reding@gmail.com, robh+dt@kernel.org, jonathanh@nvidia.com, linux-tegra@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/5] memory: tegra: Correct la.reg address of seswr Message-ID: <20201026201446.GA248919@kozik-lap> References: <20201008003746.25659-1-nicoleotsuka@gmail.com> <20201008003746.25659-2-nicoleotsuka@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20201008003746.25659-2-nicoleotsuka@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 07, 2020 at 05:37:42PM -0700, Nicolin Chen wrote: > According to Tegra X1 TRM, ALLOWANCE_SESWR is located in field > [23:16] of register at address 0x3e0 with a reset value of 0x80 > at register 0x3e0, while bit-1 of register 0xb98 is for enable > bit of seswr. > So this patch fixes it. Either use the imperative form ("Fix foo bar register address") or just skip the last sentence as it is quite obvious. https://elixir.bootlin.com/linux/latest/source/Documentation/process/submitting-patches.rst#L151 Thanks, applied. Best regards, Krzysztof