Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 0/3] drm/amd/display: Fix kernel panic by breakpoint
To:     Alex Deucher <alexdeucher@gmail.com>,
        Luben Tuikov <luben.tuikov@amd.com>
Cc:     Takashi Iwai <tiwai@suse.de>,
        amd-gfx list <amd-gfx@lists.freedesktop.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Maling list - DRI developers 
        <dri-devel@lists.freedesktop.org>
References: <20201023074656.11855-1-tiwai@suse.de>
 <1d3e22ef-a301-f557-79ca-33d6520bb64e@amd.com>
 <CADnq5_OY8tRqs-bao9mkKxgcXC=305-_71U=04C5z9HM0+5MuQ@mail.gmail.com>
From:   "Kazlauskas, Nicholas" <nicholas.kazlauskas@amd.com>
Message-ID: <22ab9117-0281-2ff3-8328-d7780e353643@amd.com>
Date:   Mon, 26 Oct 2020 16:22:19 -0400
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.12.1
In-Reply-To: <CADnq5_OY8tRqs-bao9mkKxgcXC=305-_71U=04C5z9HM0+5MuQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from [172.31.148.234] (165.204.55.211) by YTBPR01CA0007.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:14::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.18 via Frontend Transport; Mon, 26 Oct 2020 20:22:22 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-HT: Tenant
X-MS-Office365-Filtering-Correlation-Id: 76cdf65b-8ec1-427d-7e3f-08d879ecd8cc
X-MS-TrafficTypeDiagnostic: BY5PR12MB4273:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <BY5PR12MB42731D108AC7D28B55E79596EC190@BY5PR12MB4273.namprd12.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8273;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: wbsIHzCNpYPw97v25JN2Shwrbr/hfmcGBlNW3feLf1Z+AdktJ4qtHV0xP6gokPDTe3Cmh+YGRyAobJ2w7/VnZIlmC5BNCnlBaLdVL2x+jbh76nzlYU/WM6ED0EmKUj0xUS1ggL40XWy92/clsBrwzdfALB6aOrYSMG4mmAN9vgRJU/r+UPfiRqpDNVPTdnSKGXGWUH4+SB8ASjZXOhjLYVwRWcM/fnq+zvEIGvM3c6oBgw6wOQNfsb18IOg01xV/hm3+ZkSpTfDLVCKYasL8glffbwcPSibxXYZlJGyVtnWZ9LOHs5qzfT9ZtcdpxfAmwZl0kjS9UBNqYsXlFPeKysUUEvXCSLsIWUpjps7Ql2HCh2m4UTJlgvMwlQW1kMe2klfKnU68oVXrkD9U7Kaj+qLiScPPia7rCfa7R84gohU=
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR12MB3560.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(346002)(376002)(366004)(396003)(39860400002)(956004)(8676002)(16526019)(6636002)(31696002)(66946007)(2906002)(86362001)(8936002)(83380400001)(36756003)(66556008)(66476007)(4001150100001)(52116002)(2616005)(110136005)(966005)(186003)(16576012)(26005)(31686004)(478600001)(4326008)(5660300002)(6486002)(54906003)(53546011)(6666004)(316002)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: Hqda6JH9kEt0yITUZ2vlKYs217Oi+QSx/fuCf6fSCEhmjbMB5hoGg0IhTtkHVvPftdSgO6FAgc1Ku0A+k14Zpu5E/AND1kqQSmDMkXVClGZazU4KC6RfWYP2GkkjxtEL1bOzU0zKwF8D3tC5jaPfK2QblK2GYhKvUJL2HxkR5/PQbLl2PgPdVxIG7d7qEkoCV+rmhreCLK16821qE4Z2jvPb9ZvLw4Olo4ivbYI16opOSn1FI6S2/rUSkjzAW8GRNWnTzygsCRyBY6mk3WFUSsiBZLO6eFCrGAkZ+ylm96alKZQ0414c4R605heAHDSnUbpV5B0Y9hB7S234cd3FLkHkwJrgccCGhlQkdJKFVtv6+aQ2co1+jVH6ImiVmeU+V9uQQJsgqlFTkisE1BC+zE4zekGMVhW/+vXbmiGql6P38d4X6RyHffz7RK3w+hqumBQuayjkS5E9q2RaHgTkwn+0lRKYx11R8XFK1y+W2ZAO/0qTx18gLGRsigzZoVv5k2hawoY5EznwMkCh66s09TABNWhP7Ysml64STOq9KinMwc+I40yph/nQHp8UDdSygu8XsQWFKiVgABnNB0bGAlHyJ6nekfVdwZXc3uvlVcbf/C/YFIk0vfpHqLo72uaJCtQzow84XIBP5FkR2KfACA==
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 76cdf65b-8ec1-427d-7e3f-08d879ecd8cc
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB3560.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2020 20:22:23.2856
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: v0pNmK4/WQctCPLlPMaf/tdgg/S8zBIJ0z9pO6X7iVjmtvx1BkQUYs/Hyh9P1Rfc3nM0YKZfDgLfaUObutL2Fg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4273
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>

Looks fine to me. Feel free to apply.

Regards,
Nicholas Kazlauskas

On 2020-10-26 3:34 p.m., Alex Deucher wrote:
> Yes, looks good to me as well.  Series is:
> Acked-by: Alex Deucher <alexander.deucher@amd.com>
> I'll give the display guys a few more days to look this over, but if
> there are no objections, I'll apply them.
> 
> Thanks!
> 
> Alex
> 
> On Fri, Oct 23, 2020 at 7:16 PM Luben Tuikov <luben.tuikov@amd.com> wrote:
>>
>> On 2020-10-23 03:46, Takashi Iwai wrote:
>>> Hi,
>>>
>>> the amdgpu driver's ASSERT_CRITICAL() macro calls the
>>> kgdb_breakpoing() even if no debug option is set, and this leads to a
>>> kernel panic on distro kernels.  The first two patches are the
>>> oneliner fixes for those, while the last one is the cleanup of those
>>> debug macros.
>>
>> This looks like good work and solid. Hopefully it gets picked up.
>>
>> Regards,
>> Luben
>>
>>>
>>>
>>> Takashi
>>>
>>> ===
>>>
>>> Takashi Iwai (3):
>>>    drm/amd/display: Fix kernel panic by dal_gpio_open() error
>>>    drm/amd/display: Don't invoke kgdb_breakpoint() unconditionally
>>>    drm/amd/display: Clean up debug macros
>>>
>>>   drivers/gpu/drm/amd/display/Kconfig             |  1 +
>>>   drivers/gpu/drm/amd/display/dc/gpio/gpio_base.c |  4 +--
>>>   drivers/gpu/drm/amd/display/dc/os_types.h       | 33 +++++++++----------------
>>>   3 files changed, 15 insertions(+), 23 deletions(-)
>>>
>>
>> _______________________________________________
>> amd-gfx mailing list
>> amd-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
>