Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 2/2] i2c: imx: remove id_table entry
To:     Krzysztof Kozlowski <krzk@kernel.org>, peng.fan@nxp.com
Cc:     shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com,
        kernel@pengutronix.de, linux-imx@nxp.com,
        linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org,
        Geert Uytterhoeven <geert@linux-m68k.org>,
        linux-m68k@lists.linux-m68k.org,
        Angelo Dureghello <angelo.dureghello@timesys.com>
References: <1603441103-17735-1-git-send-email-peng.fan@nxp.com>
 <1603441103-17735-2-git-send-email-peng.fan@nxp.com>
 <20201023152842.GA5227@kozik-lap>
From:   Greg Ungerer <gerg@linux-m68k.org>
Message-ID: <e9dd314f-8bb4-f5f5-3dae-9bd4574ff20d@linux-m68k.org>
Date:   Tue, 27 Oct 2020 09:53:59 +1000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20201023152842.GA5227@kozik-lap>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 24/10/20 1:28 am, Krzysztof Kozlowski wrote:
> On Fri, Oct 23, 2020 at 04:18:23PM +0800, peng.fan@nxp.com wrote:
>> From: Peng Fan <peng.fan@nxp.com>
>>
>> The legacy platform device code has been removed under arch/arm/mach-imx,
>> so we no need id_table entry here.
> 
> Cc: Greg, Geert, Angelo,
> 
> Aren't you breaking Coldfire platforms?

Well spotted Krzysztof. It is used by quite a few of the ColdFire parts.

Regards
Greg


> Best regards,
> Krzysztof
> 
>>
>> Signed-off-by: Peng Fan <peng.fan@nxp.com>
>> ---
>>   drivers/i2c/busses/i2c-imx.c | 14 --------------
>>   1 file changed, 14 deletions(-)
>>
>> diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c
>> index ba9d639223ec..7ea36a78abb0 100644
>> --- a/drivers/i2c/busses/i2c-imx.c
>> +++ b/drivers/i2c/busses/i2c-imx.c
>> @@ -233,19 +233,6 @@ static struct imx_i2c_hwdata vf610_i2c_hwdata = {
>>   
>>   };
>>   
>> -static const struct platform_device_id imx_i2c_devtype[] = {
>> -	{
>> -		.name = "imx1-i2c",
>> -		.driver_data = (kernel_ulong_t)&imx1_i2c_hwdata,
>> -	}, {