Received: by 2002:a05:6a10:9e8c:0:0:0:0 with SMTP id y12csp1040122pxx; Tue, 27 Oct 2020 06:59:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxsWIOtJNW5OB5Rpd2oqKrznzzQt50+9BL9QFP17/LDlMrGfagHYXo0P6YNWV8NRtpo+s8V X-Received: by 2002:a17:906:6d48:: with SMTP id a8mr2486233ejt.502.1603807152579; Tue, 27 Oct 2020 06:59:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1603807152; cv=none; d=google.com; s=arc-20160816; b=Om7wvHCVJbgssvAqEhf/KBt5TOGjRE3DjLG0jIS6fjf4RNIkqTNFs3DmMw6XnSprzy z3f8q1l3npy8YpiPPpLN5ADm6CIwegmWZYdi8wdGvcysjNvzsiWnMElGKPX9DTsJdw3I I/EmG1vRcZTtaq/NjZGDtOL3ALtv1A4kvtx/aZN6ZJsDQEZAxMsHesUeSNLnX26G3keF BbVvnZoE6+VzBv0jSrfVzfvZDpVUXMLITEj18Ask7avN/azh0xV5oQZsA89x5epMQ+u8 YW3D/UZZEzMr9GoXvWcLae3aOOk0BI37P1T2tgvEwRdL7/gutQx2ABDuEuMvtKrNzI3y Co3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:message-id:references:in-reply-to :subject:cc:to:from:date:content-transfer-encoding:mime-version :sender:dkim-signature; bh=GxlUBsgWpRmzq1zbsPQ+RSymFtnjB5bpOntoDLsD6lY=; b=VuLt2y21nOIcd5W+H7JDYG1gLvjz30J3bIl2Ga61ZlFqV/XdIwKHGmTeIskXvnUu/6 DMVmMI+ucRWXMTAqo4LR7hJheAJqgTZ/XqPg+UR2PvZMNhOCPZ+5MwLHkPgcu/19kB1T mV2utzJKfmhpmTroS8pD+bqCwmBxjxnDNLMbTci4TpQ21CVHFBqyMb74zlHm5VyfDXWA taIYblhGEFPB1R+UB7CtsOBOtMmKJvNsb1jCKpJ3rrNG2VFoPtOgYI0ZNOc/wC4rsor3 ZuENSBciSMlXT9HkeOtafCxIFpdxU2VdvRq3P5qIXrwiwv1pzs/eiGQR6tk0M2TycVFq N+sg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=Yzg1qVe8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s19si1012251ejd.408.2020.10.27.06.58.49; Tue, 27 Oct 2020 06:59:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=Yzg1qVe8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2504350AbgJ0CGH (ORCPT + 99 others); Mon, 26 Oct 2020 22:06:07 -0400 Received: from z5.mailgun.us ([104.130.96.5]:63777 "EHLO z5.mailgun.us" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2504342AbgJ0CGH (ORCPT ); Mon, 26 Oct 2020 22:06:07 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1603764366; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=GxlUBsgWpRmzq1zbsPQ+RSymFtnjB5bpOntoDLsD6lY=; b=Yzg1qVe8lJL2ClFbKTmvrgBUsdTNKj5KshUIG+qeGUjuo8WWe3rdyExVt5xYU5qa2JZneO2f 91tZqRXTWjA1KheKv04sQ5MTGc7FozrFI1qod/RCD45nENhR9QgE91nDw2V9+3TEWcWGO9Eb xyC6oblK+wL1g7jdnEDMnI0FJc8= X-Mailgun-Sending-Ip: 104.130.96.5 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n04.prod.us-east-1.postgun.com with SMTP id 5f97808e1e4642bf75eebb50 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Tue, 27 Oct 2020 02:06:06 GMT Sender: cang=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id AF996C433FE; Tue, 27 Oct 2020 02:06:05 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=ALL_TRUSTED,BAYES_00, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: cang) by smtp.codeaurora.org (Postfix) with ESMTPSA id 0400DC433C9; Tue, 27 Oct 2020 02:06:04 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 27 Oct 2020 10:06:04 +0800 From: Can Guo To: Asutosh Das Cc: martin.petersen@oracle.com, linux-scsi@vger.kernel.org, linux-arm-msm@vger.kernel.org, Andy Gross , Bjorn Andersson , Alim Akhtar , Avri Altman , "James E.J. Bottomley" , linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 2/2] ufs: qcom: Enable aggressive power collapse for ufs hba In-Reply-To: <0716681006075e9eebbf0decd28505824e22d637.1603754932.git.asutoshd@codeaurora.org> References: <0716681006075e9eebbf0decd28505824e22d637.1603754932.git.asutoshd@codeaurora.org> Message-ID: <8f03a3a7a4209d2e1dfb07c6981a6ec6@codeaurora.org> X-Sender: cang@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-10-27 07:30, Asutosh Das wrote: > Enabling this capability to let hba power-collapse > more often to save power. > > Signed-off-by: Asutosh Das Reviewed-by: Can Guo > --- > drivers/scsi/ufs/ufs-qcom.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/scsi/ufs/ufs-qcom.c b/drivers/scsi/ufs/ufs-qcom.c > index f9d6ef3..9a19c6d 100644 > --- a/drivers/scsi/ufs/ufs-qcom.c > +++ b/drivers/scsi/ufs/ufs-qcom.c > @@ -863,6 +863,7 @@ static void ufs_qcom_set_caps(struct ufs_hba *hba) > hba->caps |= UFSHCD_CAP_AUTO_BKOPS_SUSPEND; > hba->caps |= UFSHCD_CAP_WB_EN; > hba->caps |= UFSHCD_CAP_CRYPTO; > + hba->caps |= UFSHCD_CAP_AGGR_POWER_COLLAPSE; > > if (host->hw_ver.major >= 0x2) { > host->caps = UFS_QCOM_CAP_QUNIPRO |