Received: by 2002:a05:6a10:9e8c:0:0:0:0 with SMTP id y12csp1040474pxx; Tue, 27 Oct 2020 06:59:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzacJoGIn3stDdKKHPK5iEriID7rE2/Gl2s5d8Pe0vRY2OUifXjtfQ3Su3iSoawfXh76iTq X-Received: by 2002:a17:906:e116:: with SMTP id gj22mr2666260ejb.313.1603807184494; Tue, 27 Oct 2020 06:59:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1603807184; cv=none; d=google.com; s=arc-20160816; b=alFjSdSGGuePlzUfkxCx8zOa1zwa9W0Edv1geA9RRrct7cI701D9Bn3FI4njzvO5RM BMkzTSpzWFMZpWR9G/uoI4hnHhwZbZrBT/I6kNt8nciLGpRu4B7mg0vNjAtW9AxV878i zrJ+0IEP1Wrvspbx5zDOtaF5nSueQetnZgf93RqjbtFmJH13PC3PWnHp/A7CJQ2xOxmH jryfv5wO/hcNx9/gYirQKDt3zf04nWzlVGw2F019X7uTk5tjYRgUAvG9gbxBYwZPfW8q jE9iUm4JgQwYJlCqGUnsQcP5FN6/Uq6B/Tc0DtznEVboRhDgFWVqYgGZ9kVaeKF6uVXu qOTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=Z7k2jFeuyFxR40oKjqp6f6jzB45rr1tSUQm9Sp7Fuu8=; b=Sg0G71ZxB0u83DCFmqo5h4DvPf7THr23G92ULzA743aldQZT/NSO0wXCGAamnxqmcP YPwg/gsPvhbkklykU+H39ybLQRjV+2LcN2+bRZbaHMxut2JQWE8lOwTt0fQ8x7KXnZ5u +ee9aoCqip7IUtJjly0d8W+1RkYZoWAJDPHjlinxPxUnAvutdVnXlU6bj65Pbcgd1Tdc r4AbDwS4KiYp0A/HeLL3ejZxJ2IyRhKB21bU02l2ElLB/go3Ce00P7bYeTR45N6Frkzy aJi7hzXbHPfnHnrDySnVc22USKVB/EzsViwC9XXBiJrLODqxtoV9bW3/d0sqRN6FRm7M 7N0w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@jms.id.au header.s=google header.b=emCTFPfb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bs10si893303edb.190.2020.10.27.06.59.22; Tue, 27 Oct 2020 06:59:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@jms.id.au header.s=google header.b=emCTFPfb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2504461AbgJ0CS4 (ORCPT + 99 others); Mon, 26 Oct 2020 22:18:56 -0400 Received: from mail-qk1-f195.google.com ([209.85.222.195]:34172 "EHLO mail-qk1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2504454AbgJ0CS4 (ORCPT ); Mon, 26 Oct 2020 22:18:56 -0400 Received: by mail-qk1-f195.google.com with SMTP id x20so10429469qkn.1; Mon, 26 Oct 2020 19:18:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jms.id.au; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Z7k2jFeuyFxR40oKjqp6f6jzB45rr1tSUQm9Sp7Fuu8=; b=emCTFPfbMA8sqwapkNGv73E7/ekn1Du95YiS6OJf6VKhj83eNKepggO/2T4LRV4NO1 PkbCx2E+A5beMSWBNmgrliLMH6pDiIY1xkZqGjRmOjAoodhsLVTIOzxsGPre5zCjbbss dPrY42iAFezg5u4Dt2arPi7ADacfYvJUbN2xU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Z7k2jFeuyFxR40oKjqp6f6jzB45rr1tSUQm9Sp7Fuu8=; b=LUoJj30pR8TDGscW52gJtfAdRL6oJ9JTDTnD7vWh3+LRY8v3zwgwUC5vUCdEVFaiNi o2I2ntEaGMZNhjWwTcIM4OBJf9OK5VtRUV2c51k5u+Kqky9qz3wt5n2rojuOrT2Q86al LB042AnTwN10zEm9JQShwSvMKjAbzurYAN+umU54JF+ioJdaFz+lOQzeqmim2/NqOJjU PORm9h19tnShzgYDRw/USIeNDhWxCJikyhc8CGJ++GooLUqJ3Iyrt6ATm05mYmnQK9/g OZm7JXGGA/18DD6UPYMs66V5qb2IC0RRB76W+zrz8sc159ls7O1mU+I0QD30ZTNyEXbl fRtQ== X-Gm-Message-State: AOAM530dI9SOyCT01mKPlDq5y2Txhtmg8eXTMpamlaOr0/RxKbG/rsER d0QBkwvTWaLe4Yia5YudYYPa5lB23VPIdbI9xas= X-Received: by 2002:a37:a81:: with SMTP id 123mr39228qkk.487.1603765133628; Mon, 26 Oct 2020 19:18:53 -0700 (PDT) MIME-Version: 1.0 References: <20201019073908.32262-1-dylan_hung@aspeedtech.com> <20201019120040.3152ea0b@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <32bfb619bbb3cd6f52f9e5da205673702fed228f.camel@kernel.crashing.org> <529612e1-c6c4-4d33-91df-2a30bf2e1675@www.fastmail.com> In-Reply-To: From: Joel Stanley Date: Tue, 27 Oct 2020 02:18:41 +0000 Message-ID: Subject: Re: [PATCH] net: ftgmac100: Fix missing TX-poll issue To: Benjamin Herrenschmidt Cc: Dylan Hung , Andrew Jeffery , BMC-SW , linux-aspeed , Po-Yu Chuang , netdev , OpenBMC Maillist , Linux Kernel Mailing List , Jakub Kicinski , David Miller Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 26 Oct 2020 at 22:22, Benjamin Herrenschmidt wrote: > > On Fri, 2020-10-23 at 13:08 +0000, Dylan Hung wrote: > > The issue was found on our test chip (ast2600 version A0) which is > > just for testing and won't be mass-produced. This HW bug has been > > fixed on ast2600 A1 and later versions. > > > > To verify the HW fix, I run overnight iperf and kvm tests on > > ast2600A1 without this patch, and get stable result without hanging. > > So I think we can discard this patch. > > This is great news. Thanks ! That is excellent news. I agree; we do not need fixes for A0 issues to be kept in the mainline kernel. Thanks for updating us Dylan. Cheers, Joel