Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751768AbWHNT5I (ORCPT ); Mon, 14 Aug 2006 15:57:08 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752052AbWHNT5I (ORCPT ); Mon, 14 Aug 2006 15:57:08 -0400 Received: from e1.ny.us.ibm.com ([32.97.182.141]:34229 "EHLO e1.ny.us.ibm.com") by vger.kernel.org with ESMTP id S1751768AbWHNT5G (ORCPT ); Mon, 14 Aug 2006 15:57:06 -0400 Subject: Re: aic7xxx broken in 2.6.18-rc3-mm2 From: Dave Hansen To: Daniel Ritz Cc: Greg KH , Marcus Better , Andrew Morton , James Bottomley , Linux Kernel Mailing List , linux scsi , ak@suse.de In-Reply-To: <200608142021.18551.daniel.ritz-ml@swissonline.ch> References: <1155334308.7574.50.camel@localhost.localdomain> <200608141858.37465.daniel.ritz-ml@swissonline.ch> <1155575804.7574.166.camel@localhost.localdomain> <200608142021.18551.daniel.ritz-ml@swissonline.ch> Content-Type: text/plain Date: Mon, 14 Aug 2006 12:56:43 -0700 Message-Id: <1155585403.12700.10.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.4.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1133 Lines: 36 On Mon, 2006-08-14 at 20:21 +0200, Daniel Ritz wrote: > errm...sorry, i didn't mean that patch but the alternative i sent later. attached. > it should use direct access while not breaking legacy PCI probing. in theory.. > > thanks, > -daniel > > diff --git a/arch/i386/pci/init.c b/arch/i386/pci/init.c > index c7650a7..51087a9 100644 > --- a/arch/i386/pci/init.c > +++ b/arch/i386/pci/init.c > @@ -14,8 +14,12 @@ #endif > #ifdef CONFIG_PCI_BIOS > pci_pcbios_init(); > #endif > - if (raw_pci_ops) > - return 0; > + /* > + * don't check for raw_pci_ops here because we want pcbios as last > + * fallback, yet it's needed to run first to set pcibios_last_bus > + * in case legacy PCI probing is used. otherwise detecting peer busses > + * fails. > + */ > #ifdef CONFIG_PCI_DIRECT > pci_direct_init(); > #endif That one works on my box without any issues. Thanks! -- Dave - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/