Received: by 2002:a05:6a10:9e8c:0:0:0:0 with SMTP id y12csp1086638pxx; Tue, 27 Oct 2020 08:00:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzzqY+DmOF9gdmlm5HXpX+PEIyeMoUOtiG10w51QJ0JZLk7bq+uKfdsJHthZ80io2eSUiFl X-Received: by 2002:a17:906:b043:: with SMTP id bj3mr2721568ejb.543.1603810815509; Tue, 27 Oct 2020 08:00:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1603810815; cv=none; d=google.com; s=arc-20160816; b=PlFOd9EAeFPphw9Hi6dEOHzt49VcfJ8b7BuvremRnuFWI5gFTpaOdM6x4fmaInizrt WLEdjsjQcrWHydjFoHov+xj1fyfCwTHcDtMINqJ+DrYq7AlSMjDBKaZimvlkahvzWJS3 MrWwCjBQa/3Yo7P8UjchteWnSRShqgzY1Lak3ODvHRbNXrJ7OcewE6yJExTFCdhtahd5 mrcOyrExOZHOjS1vDNCXvHVETyjhfIrOyHY/WwZxGOxx+GvylXOCLMWMjBEf5XnKtKC3 hY7K8DkmPHl5sIsxtCH9ltnbDBv6xA1Oh0IoKT6Ur/DkYhLVkGL4vFjHKROzDWZ4aslQ dwAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=NulUrodgoNIbmmmHbOLRpOdMllJMP5bKAN+DJassrL8=; b=HLHsFdUiPQR/b3ik8g6/8In/LhgC/mX/44ZjaG2c5MyyRgp09HEKILfnX6E05LHcDH bOXiBaZtKkD//4ScC+/PHrIaVkPTMIvA+GPkC+KAiWnJ3+jM9qVCy/Gmu/b/8NKHFIvV B/ca84ks9Q3QsxC58YDgkpGiuD+4dRwP0Q8D8ZnDKZ/wU9AwqXsPv5qZCPCLzd/Zh/Gd CqTIA4HzV7fYMCfWtN5s/7hhyELso+UHjRD3HaWkkZ9mVtYRD0Bq7ATFSQNZIMjhmqNn 4Rnhxx61yikqvF+SWe7IUBLOo/pQmQtNNY7N5cRj0ShRMx/W5KBEPKVJlwrf+qLy3tD5 7e+Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=qwEhsAqA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b9si1137243eje.59.2020.10.27.07.59.50; Tue, 27 Oct 2020 08:00:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=qwEhsAqA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753229AbgJ0OA5 (ORCPT + 99 others); Tue, 27 Oct 2020 10:00:57 -0400 Received: from mail.kernel.org ([198.145.29.99]:46848 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753246AbgJ0N7X (ORCPT ); Tue, 27 Oct 2020 09:59:23 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BFD922068D; Tue, 27 Oct 2020 13:59:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603807163; bh=jqDXK0s6p9Ni/uBdvRk9fAiRHa1Efno5M6IXDNS++3s=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=qwEhsAqAsQaaF/0ytXt/RoBtH54Ib6cDw6f2PJS4vsWeT6TS0rRCqGmmV6AKES3+s iyD70Fw8sqCIx3cZH0rLj4Vw4vBpsQjCVf7KstUAtLyLZ/N4FkECBEU+765+FI/uF1 IzRWBA3QMsfAkOd2rgDSUYrzo4/z7wya1wabolKI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Tom Rix , Hans Verkuil , Mauro Carvalho Chehab , Sasha Levin Subject: [PATCH 4.4 025/112] media: tc358743: initialize variable Date: Tue, 27 Oct 2020 14:48:55 +0100 Message-Id: <20201027134901.755445472@linuxfoundation.org> X-Mailer: git-send-email 2.29.1 In-Reply-To: <20201027134900.532249571@linuxfoundation.org> References: <20201027134900.532249571@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Tom Rix [ Upstream commit 274cf92d5dff5c2fec1a518078542ffe70d07646 ] clang static analysis flags this error tc358743.c:1468:9: warning: Branch condition evaluates to a garbage value return handled ? IRQ_HANDLED : IRQ_NONE; ^~~~~~~ handled should be initialized to false. Fixes: d747b806abf4 ("[media] tc358743: add direct interrupt handling") Signed-off-by: Tom Rix Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/i2c/tc358743.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/i2c/tc358743.c b/drivers/media/i2c/tc358743.c index bc630a7197761..1e95fdb61041b 100644 --- a/drivers/media/i2c/tc358743.c +++ b/drivers/media/i2c/tc358743.c @@ -1325,7 +1325,7 @@ static int tc358743_isr(struct v4l2_subdev *sd, u32 status, bool *handled) static irqreturn_t tc358743_irq_handler(int irq, void *dev_id) { struct tc358743_state *state = dev_id; - bool handled; + bool handled = false; tc358743_isr(&state->sd, 0, &handled); -- 2.25.1