Received: by 2002:a05:6a10:9e8c:0:0:0:0 with SMTP id y12csp1101472pxx; Tue, 27 Oct 2020 08:16:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwOnun+UxBHci+SAq/4Nr92OoBHg8FRQmHv0tSA5y5CGRm5y7ltRDWx6DGI1JxJ7Jp/rEDc X-Received: by 2002:a50:e442:: with SMTP id e2mr2874478edm.186.1603811810694; Tue, 27 Oct 2020 08:16:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1603811810; cv=none; d=google.com; s=arc-20160816; b=KUKb+SMuU0fp3Z1GhLxaSeCAQBAVg0Fkbr/75Jkx+Q630r0fiQy2MNL2GM2olg3Yga 6/VW8+EPJcJ+07FgOZ1c3YxXSVTSsicfLREkECjwIvKDP/0KSGu8gPranwfMW2QUFMlh yvMmxmw5WVSIBQjbGCLLIr8fyoQnUG7eNbTbwyTpEonK+xOCyeb2f37zAoNZKzTJ61Sm QB7lhpOB1hycX1bRUUWkIR2lT5Y2n+mYrzHgFJGNisuBuWNS85KT0bQ8CqLcER67SFSA WyQ8kpWg9xaWLcHdWg8jdyRLRnU1PHQltdup4NBwxDcfpKykIfhK4vSjO17y5XlB7Svp 2p6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:organization :from:references:cc:to:subject:ironport-sdr:ironport-sdr; bh=vDII1IWTP+S4mbsmuqvnyI++4VJIw7ZDxNONshs3Nsg=; b=GrAOU6e51shJp5nhKrmB+Q2y7VFiqtFWmFn7BLHiuNPtzHm1Ah1XEoAtQYQu+NZtrr 3tlL5D56D9+8jRuzH0gGtQcIV3IaAPq1GJgeKuvm/uzh+fQ0idD/kMtob29oPPhDRo6X VBqOhS+Kehxa2u/gX9WJhD168kQ6nBzEV98BLeQ/iYEZHSFwZ/ciQia+Pwh4AazpoF+w AtRwZeiBqveGYpeIV2p/taosynfDj2RV0dGcNSRkp+iVrImy92IzIGTRhxCX7v/ScsnC MaaXnxirf1Z/fq73uuFcrGDjHJAyGcZp64zHR7sTY3ALUWRaPnZ75hpNGnNnspbS8hqg ZVIA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h12si1077018edr.102.2020.10.27.08.16.20; Tue, 27 Oct 2020 08:16:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757457AbgJ0OTk (ORCPT + 99 others); Tue, 27 Oct 2020 10:19:40 -0400 Received: from mga07.intel.com ([134.134.136.100]:23038 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757215AbgJ0OQu (ORCPT ); Tue, 27 Oct 2020 10:16:50 -0400 IronPort-SDR: JBo4E2vxG8nJDKl9/tmzQ5+hpMWlWHmbsbLS7hSTogwmLPd163o9dSjKKLsfswQS4VnZc6nzHP PxEEZOf6/RAw== X-IronPort-AV: E=McAfee;i="6000,8403,9786"; a="232272101" X-IronPort-AV: E=Sophos;i="5.77,424,1596524400"; d="scan'208";a="232272101" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Oct 2020 07:16:49 -0700 IronPort-SDR: T0y2qF8NNkQs2vYMglbUHnHxKh7TKeyRDOQQFhI3Ob1K5RpkTngQONUWKLULRKH1etLmos963O ccpynm68JGug== X-IronPort-AV: E=Sophos;i="5.77,424,1596524400"; d="scan'208";a="535812090" Received: from abudanko-mobl.ccr.corp.intel.com (HELO [10.249.227.194]) ([10.249.227.194]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Oct 2020 07:16:46 -0700 Subject: Re: [PATCH v2 12/15] perf record: introduce thread local variable for trace streaming To: Jiri Olsa , Alexei Budankov Cc: Arnaldo Carvalho de Melo , Namhyung Kim , Alexander Shishkin , Adrian Hunter , Andi Kleen , Peter Zijlstra , Ingo Molnar , linux-kernel References: <1ec29ed6-0047-d22f-630b-a7f5ccee96b4@linux.intel.com> <20201024154357.GD2589351@krava> <6eb97205-4d13-6487-8e15-a85f63d3f0cc@gmail.com> <20201026103426.GC2726983@krava> <78ca09c2-50da-3206-2dff-19523699d82b@gmail.com> <20201027120130.GD2900849@krava> From: Alexey Budankov Organization: Intel Corp. Message-ID: Date: Tue, 27 Oct 2020 17:16:43 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <20201027120130.GD2900849@krava> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 27.10.2020 15:01, Jiri Olsa wrote: > On Mon, Oct 26, 2020 at 05:11:30PM +0300, Alexei Budankov wrote: >> Why do you complain about per thread variable in this case? >> It looks like ideally fits these specific needs. > > I think there's misunderstanding.. I think we should move > samples to per thread 'thread' object and have just one > copy of that.. and do not increase separate variables for > thread and non-thread cases Aw, I see. Using the same __thread object by main thread in serial and threaded modes. That makes sense. I will correct in v3. Alexei