Received: by 2002:a05:6a10:9e8c:0:0:0:0 with SMTP id y12csp1112427pxx; Tue, 27 Oct 2020 08:31:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzhXwwqUgsPS6631+Dgi4a57cBBw3Wu7Fq6KBe1HziDRbPogeReAVmq5fTBkjYFWnBniQj+ X-Received: by 2002:a50:e04d:: with SMTP id g13mr2881469edl.72.1603812683942; Tue, 27 Oct 2020 08:31:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1603812683; cv=none; d=google.com; s=arc-20160816; b=L2b4VO8t5bIdSlscqI3BNGfj+XQrl3beqorFcWfXhnOMvZFEHTXRT5SPOjLMwX8BWx a9unZ10NYLAzT7c6J5z6SciX+gBkiztmGiMz4Ut/KboFS/u9ZO3O36IVP0+NOvsWXTmB f/vVnagNTrqn5U1mhHHn4ArTGtkLP+y8D5wkrWLfKMetHlCvDTYGZkUoNLEETTFgsZNP TQLKOTbfHhpmR/i3lky8eITr3RGk9tRrYAjBskVf8rrik37tDgLxFoUdPcHC+Bdz0tEW Su0onvDAcgF9xyGdBcQNGpB+r76xRSWnoLcgHHVO10lQ/tNWRy3aSlV/2DC3rWUggtfH E3Yg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=6LKTHr1+Cul4Tf1SvdIz0D7q0uv1WRFoESeHGCQHbaM=; b=y/TZzjujt4ttiZJXlWLH/gWpriGGetk+iG8HjEaBawCxvKK3JEu5QBZxjpZqOmnroh zIlw3pbJ6UuAk3/tLN10KsQuTbFMP5LbYVdPScj9JfcFunEDr5lMtMjnkxWq7FL035Ye umDyjFyta1ouXrkQi+ao9dFpsr6RkD75uLKwDq9wSRTwDKc/hNqRdr29oMoa74ixlkt+ 9pZoGV+3iyddaKOeLzb2vmTKibe+ltKbZPX83I/Qjvzg10JVbNcKYklQGKtK/LS+Xats LGNK3bHjr1aUxLac/FmRlQG39Sl/MV+EMGl1KlZz8OCJXdAjQRHzDUR3VjzLoycmOezs jyLw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="wQX/lzbN"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l11si1428329ejx.254.2020.10.27.08.31.00; Tue, 27 Oct 2020 08:31:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="wQX/lzbN"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760681AbgJ0Ofw (ORCPT + 99 others); Tue, 27 Oct 2020 10:35:52 -0400 Received: from mail.kernel.org ([198.145.29.99]:33862 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760557AbgJ0OfH (ORCPT ); Tue, 27 Oct 2020 10:35:07 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6917322202; Tue, 27 Oct 2020 14:35:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603809307; bh=eT0ceFRk/iuU9MUwUY2nKLoERlcqX5PPx5dsG3Pe9nY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=wQX/lzbNMLNKXL7Ha6z80voRG5g6DLpyCkc33YR8ARuDISAO6iy3r/2rlYApIZ0Ds S05PBBAZmK4K+VKcKrIzG/QCImRXVq1aG0JGb56xeRYtYhYTQSjVVna3pM/U2ofWXq B1w3SGM8DmZPvx/vOf3cpnXpmZ0h+LQIr/F3ACl8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Quinn Tran , Tianjia Zhang , "Martin K. Petersen" , Sasha Levin Subject: [PATCH 5.4 119/408] scsi: qla2xxx: Fix wrong return value in qlt_chk_unresolv_exchg() Date: Tue, 27 Oct 2020 14:50:57 +0100 Message-Id: <20201027135500.626372692@linuxfoundation.org> X-Mailer: git-send-email 2.29.1 In-Reply-To: <20201027135455.027547757@linuxfoundation.org> References: <20201027135455.027547757@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Tianjia Zhang [ Upstream commit bbf2d06a9d767718bfe6028d6288c03edb98554a ] In the case of a failed retry, a positive value EIO is returned here. I think this is a typo error. It is necessary to return an error value. [mkp: caller checks != 0 but the rest of the file uses -Exxx so fix this up to be consistent] Link: https://lore.kernel.org/r/20200802111528.4974-1-tianjia.zhang@linux.alibaba.com Fixes: 0691094ff3f2 ("scsi: qla2xxx: Add logic to detect ABTS hang and response completion") Cc: Quinn Tran Signed-off-by: Tianjia Zhang Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/qla2xxx/qla_target.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c index a7acc266cec06..d84d95cac2a13 100644 --- a/drivers/scsi/qla2xxx/qla_target.c +++ b/drivers/scsi/qla2xxx/qla_target.c @@ -5677,7 +5677,7 @@ static int qlt_chk_unresolv_exchg(struct scsi_qla_host *vha, /* found existing exchange */ qpair->retry_term_cnt++; if (qpair->retry_term_cnt >= 5) { - rc = EIO; + rc = -EIO; qpair->retry_term_cnt = 0; ql_log(ql_log_warn, vha, 0xffff, "Unable to send ABTS Respond. Dumping firmware.\n"); -- 2.25.1