Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 27 Oct 2020 17:12:17 +0100
From:   Jean Delvare <jdelvare@suse.de>
To:     Kai-Chuan Hsieh <kaichuan.hsieh@canonical.com>
Cc:     linux-kernel@vger.kernel.org
Subject: Re: [PATCH] firmware/dmi: Include product_sku info to modalias
Message-ID: <20201027171217.4c05a8a2@endymion>
In-Reply-To: <ba8ca9b3-da06-4543-6804-ac0d47f26b06@canonical.com>
References: <20201022064047.9827-1-kaichuan.hsieh@canonical.com>
        <20201022144255.667ca9ce@endymion>
        <ba8ca9b3-da06-4543-6804-ac0d47f26b06@canonical.com>
Organization: SUSE Linux
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Kai-Chuan,

On Thu, 22 Oct 2020 21:11:32 +0800, Kai-Chuan Hsieh wrote:
> There are multiple product skus share the same product name, like 
> clamshell and 2-in-1 for Latitude series.
> Both of them have 3-axis accelerator, but rotation is only disable for 
> clamshell model.
> Originally, it should be descriminated by chassis_type, but found that 
> chassis_type is not trustful.
> https://github.com/systemd/systemd/pull/17084#issuecomment-706931881
> Therefore, I would like to propose a change to include the product_sku 
> for applying customized configuration easier.

OK. On the principle I'm fine with the change. As far as the
implementation details go, I'd rather stick to 3 letters maximum as we
did for other fields, to keep the overall string as short as possible.
This also has the nice effect that you wouldn't need to realign
everything, which would make the patch more readable too.

So please go with either "sku" (my preference) or "psk".

Thanks,
-- 
Jean Delvare
SUSE L3 Support