Received: by 2002:a05:6a10:9e8c:0:0:0:0 with SMTP id y12csp1214527pxx; Tue, 27 Oct 2020 10:53:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxfX29g1Ah44UDXEyEM+XTBugYiYy/bwqE+u/Awz4eT0gv4GwINj5JvERrmXbpx5KAs86KE X-Received: by 2002:aa7:c955:: with SMTP id h21mr3510921edt.315.1603821227673; Tue, 27 Oct 2020 10:53:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1603821227; cv=none; d=google.com; s=arc-20160816; b=UGVUK15px63NTLoX6A2nou1o9NG2mm8MheNZlhOxFwS50S8ukCQE4WcWElSWJgaPc3 KKb7Q95kVMG3PFwjNRNcLAKoNGakkyCfkGEvdjVxZD2DHg23PBU24j8FvdKWQE2GK/PC vBcnrDuqyLqu7xWyFqI0iMCEs1H3/6kN1d9DFy9BDFRU01cnYonHpBlO1z2lXsq8kQX4 KxxR0b2fYfyfWX5P5IFX1Ze9bY9cK6WgZaSH6g85gKZ3Lsj3fSeCJJB+0KIwdga/G1Uu KsWu+b2CZpYsw641Q40t3eGJ/wLHm3cnQUNbT6k+J5zGp2FaUB4/tLanSB8DO1i5NdLW 7e6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=LaCGh72lCiN3vfGt5CNxt5/m4Fav/7JhEpsVTQ3IJx8=; b=UHhdx4hMc+73JGuhjCewezu5U5UxXdT/AlD4x+3bacSF5AzttAXAoWV2MOZXCZUYy5 /LcFMZTY6ryD7xqDQWH5D++Ny9cH9pL5ekTHoAccjla+lbzMq5w3f0CS7i80pie7qj65 h2Rf0eSgd180r5azjscMarD+KOi5Fa/qCbeYxSdcjyF6tsuZf1Xx6bWxcTDXgXbQO2J2 pqPymlAZQuBcmx5IrgH25Kwm4GEGLP+kwWvJf4IP7f8C18Mj7fA7LRk5EcjVrLKZ7W4h HtVFQGcICCphkFVMguAHDvBZjjSu5LMKk7cPuzvgr4pLovG7PXPBs4wE1h2hM/0zE9aq rqBg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=SCbuLEjY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b24si1470926edu.147.2020.10.27.10.53.25; Tue, 27 Oct 2020 10:53:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=SCbuLEjY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1818723AbgJ0RWw (ORCPT + 99 others); Tue, 27 Oct 2020 13:22:52 -0400 Received: from mail.kernel.org ([198.145.29.99]:55438 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S368502AbgJ0Oyy (ORCPT ); Tue, 27 Oct 2020 10:54:54 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 63A6820679; Tue, 27 Oct 2020 14:54:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603810494; bh=4PkUEfHxS/KjCdvgfPEmgpJdvkPJH7IJYVCMeuanvwk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=SCbuLEjYcyTVVR5NmK29gHk3TwWlSdq78T4B1KDXJG1ETklya37CPuwiVERKtbuNg qbTPwlCT0DV72VHPiGCIZe8iOFz7fMyWTbrfCDIDCRR+L1uRecBO6T1rDwxJjvKoBs LjJpJt/rYWtPKsREJ87CePZtpeDNJmTkCVTlgeg8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Qinglang Miao , Daniel Vetter , Sasha Levin Subject: [PATCH 5.8 159/633] drm/vkms: add missing platform_device_unregister() in vkms_init() Date: Tue, 27 Oct 2020 14:48:22 +0100 Message-Id: <20201027135530.138615218@linuxfoundation.org> X-Mailer: git-send-email 2.29.1 In-Reply-To: <20201027135522.655719020@linuxfoundation.org> References: <20201027135522.655719020@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Qinglang Miao [ Upstream commit 7995bd13296111d672d8c5959f5e81dbbbda5286 ] When vkms_init() get into out_put, the unregister call of vkms_device->platform is missing. So add it before return. Fixes: ac19f140bc27 ("drm/vkms: Use drmm_add_final_kfree") Signed-off-by: Qinglang Miao Signed-off-by: Daniel Vetter Link: https://patchwork.freedesktop.org/patch/msgid/20200810130011.187691-1-miaoqinglang@huawei.com Signed-off-by: Sasha Levin --- drivers/gpu/drm/vkms/vkms_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkms/vkms_drv.c index 1e8b2169d8341..e6a3ea1b399a7 100644 --- a/drivers/gpu/drm/vkms/vkms_drv.c +++ b/drivers/gpu/drm/vkms/vkms_drv.c @@ -188,8 +188,8 @@ static int __init vkms_init(void) out_put: drm_dev_put(&vkms_device->drm); + platform_device_unregister(vkms_device->platform); return ret; - out_unregister: platform_device_unregister(vkms_device->platform); out_free: -- 2.25.1