Received: by 2002:a05:6a10:9e8c:0:0:0:0 with SMTP id y12csp1287671pxx;
        Tue, 27 Oct 2020 12:49:27 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJxYuRbJEDkWpPB0Hy+f158wXvkd/BgTPsAx7Q46kQRQ76i6Y0vUWAe5e9wVR4hqCO87GUBc
X-Received: by 2002:a17:906:eb48:: with SMTP id mc8mr4265714ejb.254.1603828167616;
        Tue, 27 Oct 2020 12:49:27 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1603828167; cv=none;
        d=google.com; s=arc-20160816;
        b=b6GSkq4f3ipEzjXcfjG/MW7k5Z1VcDu2O6tiiCEK+jEihoJeo5NVospXPwK3JdGOmA
         P+v8i91OVjXIW8TbiXtQUoEvb8PawhPkKdVg+7b9iRHAi91C73GejCaJ0kcHYRl7bspU
         Mf8uEmx08fIL3h+y5EfCgmvRtPWGy0PZK5+/00gTjUhbxIZtjtK0cY2+Rp56JzQzrMo7
         Zmhzp9Db1kta+4F3fv7rwXo8dIqds6RS/gth6evGTY6NQrfPzWxodTy2nkZIS0ReCWsa
         lCr2KLnMxbo4ko1yYm9JDv4GSZsRmMnDYic4mIfIMfUM3TrR6S72de9+FPnpOCmgyqsv
         wADg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:content-transfer-encoding:mime-version
         :references:in-reply-to:message-id:subject:cc:to:from:date
         :dkim-signature;
        bh=Tf46nFQo5Q1KLIgLaFv2cmEa9fdqHW5aa/RA9Ph69Po=;
        b=pZ4EGiPJ5i3pujDdcNgMd7gt9o2ygcyTCINGIw/mKRVlFcD/McFyni8p1eNNJPskId
         wu2XF+AKRqWOIJF5HXsdA4CF1YX0gknLzIw/T/D6bZIFU6azzMBC0Ctz1ZQMJqq4tk73
         t2Bk/We5W6FA9CUjFUO9RDPqIJzm3qbo675NaGf6rcp0umNFsRlirw+kGh+vyIAH1egj
         6iBkxsrVNrXeTYsjh/Ha4D5xF21sv+kXqzCnpA0edb1iM0aH4D93/kjfDamMTa3AA7NT
         sx0xKvsKw6mkcKHVSeHy/aVn2QYG6iB//9nnqNdEmn5RgQvQWBz30Y45IU1HORO9a8XU
         ND8A==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@kernel.org header.s=default header.b=1KY0t2nt;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id g10si1598924edm.124.2020.10.27.12.48.49;
        Tue, 27 Oct 2020 12:49:27 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@kernel.org header.s=default header.b=1KY0t2nt;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S2503944AbgJ0B0A (ORCPT <rfc822;atom.tux.beastie@gmail.com>
        + 99 others); Mon, 26 Oct 2020 21:26:00 -0400
Received: from mail.kernel.org ([198.145.29.99]:38498 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S2503939AbgJ0BZ7 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 26 Oct 2020 21:25:59 -0400
Received: from kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net (unknown [163.114.132.6])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by mail.kernel.org (Postfix) with ESMTPSA id 1E3B32080A;
        Tue, 27 Oct 2020 01:25:58 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=default; t=1603761958;
        bh=eRxg91Vif7Hr1e9AN7SedTexl2F5jN3mSWEmfAproKU=;
        h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
        b=1KY0t2ntYJ3C5zqSePGezBS83g1RvdMkdcL4lpFB5yIHlx1twpHVGAgCsrqgGFjoA
         VN+/v/m69y+0B3fFCREfR5JUdoQnJLhhULBWnFgaev5F+fnaNuvNzpRvXy4U3EESZ1
         lPLrYcx6KE4g984ykHIbpUy1v30E+p1+ChFGV7/8=
Date:   Mon, 26 Oct 2020 18:25:57 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     Yunsheng Lin <linyunsheng@huawei.com>
Cc:     Zenghui Yu <yuzenghui@huawei.com>, <yisen.zhuang@huawei.com>,
        <salil.mehta@huawei.com>, <davem@davemloft.net>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <wanghaibin.wang@huawei.com>, <tanhuazhong@huawei.com>
Subject: Re: [PATCH net] net: hns3: Clear the CMDQ registers before
 unmapping BAR region
Message-ID: <20201026182557.43dcb486@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
In-Reply-To: <bca7fb17-2390-7ff3-d62d-fe279af6a225@huawei.com>
References: <20201023051550.793-1-yuzenghui@huawei.com>
        <3c5c98f9-b4a0-69a2-d58d-bfef977c68ad@huawei.com>
        <e74f0a72-92d1-2ac9-1f4b-191477d673ef@huawei.com>
        <20201026161325.6f33d9c8@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
        <bca7fb17-2390-7ff3-d62d-fe279af6a225@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 27 Oct 2020 09:24:10 +0800 Yunsheng Lin wrote:
> > Fixes: 862d969a3a4d ("net: hns3: do VF's pci re-initialization while PF doing FLR")  
> 
> The correct Fixes tag should be:
> 
> Fixes: e3338205f0c7 ("net: hns3: uninitialize pci in the hclgevf_uninit")

Why is that?

Isn't the issue the order of cmd vs pci calls? e3338205f0c7 only takes
the pci call from under an if, the order was wrong before.