Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201026215004.3893088-1-arnd@kernel.org> <b185c2d6-e890-6e56-3349-2ab023637af0@kleine-koenig.org>
In-Reply-To: <b185c2d6-e890-6e56-3349-2ab023637af0@kleine-koenig.org>
From:   Arnd Bergmann <arnd@kernel.org>
Date:   Tue, 27 Oct 2020 09:41:03 +0100
Message-ID: <CAK8P3a30xWy5nOZqYF16nuODfThsKxjqp6J2-PanKiv09SxVYg@mail.gmail.com>
Subject: Re: [PATCH] printf: fix Woverride-init warning for EDEADLK errno
To:     =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= <uwe@kleine-koenig.org>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Petr Mladek <pmladek@suse.com>,
        Rasmus Villemoes <linux@rasmusvillemoes.dk>,
        Andy Shevchenko <andy.shevchenko@gmail.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, Oct 27, 2020 at 7:55 AM Uwe Kleine-K=C3=B6nig <uwe@kleine-koenig.or=
g> wrote:
> On 10/26/20 10:49 PM, Arnd Bergmann wrote:
> > Make that line conditional on the two values being distinct.
> >
> > Fixes: 57f5677e535b ("printf: add support for printing symbolic error n=
ames")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > ---
> >  lib/errname.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/lib/errname.c b/lib/errname.c
> > index 0c4d3e66170e..6adff0bf2445 100644
> > --- a/lib/errname.c
> > +++ b/lib/errname.c
> > @@ -169,7 +169,9 @@ static const char *names_0[] =3D {
> >       E(ECANCELED), /* ECANCELLED */
> >       E(EAGAIN), /* EWOULDBLOCK */
> >       E(ECONNREFUSED), /* EREFUSED */
> > +#if EDEADLK !=3D EDEADLOCK
> >       E(EDEADLK), /* EDEADLOCK */
> > +#endif
>
> The comments suggest that duplicates are expected. Would it make sense
> to add similar conditions to the other three entries?

The other ones are always aliases, so there is no point in having
an #ifdef. The reason we need to handle EDEADLK separately
is that it's an alias on most architectures but not on on others,
specifically mips, powerpc and sparc.

       Arnd